Received-SPF: pass (google.com: domain of linux-kernel+bounces-22393-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <639c0b0a-dfbc-4612-aeaf-460a68c9e6a0@suse.cz>
Date: Wed, 10 Jan 2024 16:03:25 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/4] mm/slub: unify all sl[au]b parameters with
 "slab_$param"
Content-Language: en-US
To: sxwjean@me.com, 42.hyeyoo@gmail.com, cl@linux.com, linux-mm@kvack.org
Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
 roman.gushchin@linux.dev, corbet@lwn.net, keescook@chromium.org,
 arnd@arndb.de, akpm@linux-foundation.org, gregkh@linuxfoundation.org,
 quic_jjohnson@quicinc.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, Xiongwei Song <xiongwei.song@windriver.com>
References: <20231215034150.108783-1-sxwjean@me.com>
 <20231215034150.108783-3-sxwjean@me.com>
From: Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20231215034150.108783-3-sxwjean@me.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 12/15/23 04:41, sxwjean@me.com wrote:
> From: Xiongwei Song <xiongwei.song@windriver.com>
> 
> Since the SLAB allocator has been removed, so we can clean up the
> sl[au]b_$params. With only one slab allocator left, it's better to use the
> generic "slab" term instead of "slub" which is an implementation detail,
> which is pointed out by Vlastimil Babka. For more information please see
> [1]. Hence, we are going to use "slab_$param" as the primary prefix.
> 
> This patch is changing the following slab parameters
> - slub_max_order
> - slub_min_order
> - slub_min_objects
> - slub_debug
> to
> - slab_max_order
> - slab_min_order
> - slab_min_objects
> - slab_debug
> as the primary slab parameters for all references of them in docs and
> comments. But this patch won't change variables and functions inside
> slub as we will have wider slub/slab change.
> 
> Meanwhile, "slub_$params" can also be passed by command line, which is
> to keep backward compatibility. Also mark all "slub_$params" as legacy.
> 
> Remove the separate descriptions for slub_[no]merge, append legacy tip
> for them at the end of descriptions of slab_[no]merge.
> 
> [1] https://lore.kernel.org/linux-mm/7512b350-4317-21a0-fab3-4101bc4d8f7a@suse.cz/
> 
> Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Thanks.