Received-SPF: pass (google.com: domain of linux-kernel+bounces-22412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240109214828.252092-1-tj@kernel.org> <20240109214828.252092-3-tj@kernel.org>
In-Reply-To: <20240109214828.252092-3-tj@kernel.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 10 Jan 2024 16:18:36 +0100
Message-ID: <CAMuHMdWD==XWQrcZVfxaL0wSjG5hFPoUubpi6mjrJSPU+nOoJg@mail.gmail.com>
Subject: Re: [PATCH 2/3] kernfs: Rearrange kernfs_node fields to reduce its
 size on 64bit
To: Tejun Heo <tj@kernel.org>
Cc: gregkh@linuxfoundation.org, andrea.righi@canonical.com, ast@kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Tejun,

On Tue, Jan 9, 2024 at 10:49=E2=80=AFPM Tejun Heo <tj@kernel.org> wrote:
> Moving .flags and .mode right below .hash makes kernfs_node smaller by 8
> bytes on 64bit.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>

Thanks for your patch!

> --- a/include/linux/kernfs.h
> +++ b/include/linux/kernfs.h
> @@ -206,6 +206,9 @@ struct kernfs_node {
>
>         const void              *ns;    /* namespace tag */
>         unsigned int            hash;   /* ns + name hash */
> +       unsigned short          flags;
> +       umode_t                 mode;
> +
>         union {
>                 struct kernfs_elem_dir          dir;
>                 struct kernfs_elem_symlink      symlink;
> @@ -220,8 +223,6 @@ struct kernfs_node {
>          */
>         u64                     id;
>
> -       unsigned short          flags;
> -       umode_t                 mode;
>         struct kernfs_iattrs    *iattr;

Note that there is now a hole at the end of the structure on 32-bit
architectures
where the alignment of u64 is 8 bytes.

Hence, sizeof(struct kernfs_node) grew from 104 to 112 bytes on (at
least) arm32 and rv32.
It did shrink by 8 bytes on amd64, arm64, mips64, and rv64.
Size is unchanged on ia32, m68k and sh.

I didn't check any other architectures.

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds