Received-SPF: pass (google.com: domain of linux-kernel+bounces-22440-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <557cf463-5ffa-4d81-8b38-44f610b26163@gmail.com>
Date: Wed, 10 Jan 2024 16:41:47 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: Add initial MT7981B and Xiaomi
 AX3000T
Content-Language: en-US
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
 Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: Daniel Golle <daniel@makrotopia.org>, Hsin-Yi Wang <hsinyi@chromium.org>,
 =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= <nfraprado@collabora.com>,
 jason-ch chen <Jason-ch.Chen@mediatek.com>,
 Macpaul Lin <macpaul.lin@mediatek.com>, Sean Wang <sean.wang@mediatek.com>,
 devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
 =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20240110095118.25598-1-zajec5@gmail.com>
 <20240110095118.25598-2-zajec5@gmail.com>
 <34bda5e0-0587-459b-b31c-46112b1b10fa@collabora.com>
From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
In-Reply-To: <34bda5e0-0587-459b-b31c-46112b1b10fa@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10.01.2024 14:38, AngeloGioacchino Del Regno wrote:
> Il 10/01/24 10:51, Rafał Miłecki ha scritto:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> MT7981B (AKA MediaTek Filogic 820) is a dual-core ARM Cortex-A53 SoC.
>> One of market devices using this SoC is Xiaomi AX3000T.
>>
>> This is initial contribution with basic SoC support. More hardware block
>> will get added later. Some will need their bindings (like auxadc).
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>>   arch/arm64/boot/dts/mediatek/Makefile         |   1 +
>>   .../dts/mediatek/mt7981b-xiaomi-ax3000t.dts   |  15 +++
>>   arch/arm64/boot/dts/mediatek/mt7981b.dtsi     | 108 ++++++++++++++++++
>>   3 files changed, 124 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts
>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt7981b.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
>> index 0a189d5d8006..8bff11acfe1f 100644
>> --- a/arch/arm64/boot/dts/mediatek/Makefile
>> +++ b/arch/arm64/boot/dts/mediatek/Makefile
>> @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7981b-xiaomi-ax3000t.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts b/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts
>> new file mode 100644
>> index 000000000000..a314c3e05e50
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts
>> @@ -0,0 +1,15 @@
>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
>> +
>> +/dts-v1/;
>> +
>> +#include "mt7981b.dtsi"
>> +
>> +/ {
>> +    compatible = "xiaomi,ax3000t", "mediatek,mt7981b";
>> +    model = "Xiaomi AX3000T";
>> +
>> +    memory@40000000 {
>> +        reg = <0 0x40000000 0 0x10000000>;
>> +        device_type = "memory";
>> +    };
>> +};
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
>> new file mode 100644
>> index 000000000000..ce878ad55204
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
>> @@ -0,0 +1,108 @@
>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
>> +
>> +#include <dt-bindings/clock/mediatek,mt7981-clk.h>
>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +/ {
>> +    compatible = "mediatek,mt7981b";
>> +    interrupt-parent = <&gic>;
>> +    #address-cells = <2>;
>> +    #size-cells = <2>;
>> +
>> +    cpus {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        cpu@0 {
>> +            compatible = "arm,cortex-a53";
>> +            reg = <0x0>;
>> +            device_type = "cpu";
>> +            enable-method = "psci";
>> +        };
>> +
>> +        cpu@1 {
>> +            compatible = "arm,cortex-a53";
>> +            reg = <0x1>;
>> +            device_type = "cpu";
>> +            enable-method = "psci";
>> +        };
>> +    };
>> +
>> +    oscillator-40m {
>> +        compatible = "fixed-clock";
>> +        clock-frequency = <40000000>;
>> +        clock-output-names = "clkxtal";
>> +        #clock-cells = <0>;
>> +    };
>> +
>> +    psci {
>> +        compatible = "arm,psci-0.2";
> 
> PSCI 0.2? I invite you to check a kernel log for a string like this one:
> 
> `PSCIv%d.%d detected in firmware`
> ...because of course if it says v1.0, this should be "arm,psci-1.0".
> 
> This is just a nitpick anyway, so you can already get my
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> P.S.: but please, confirm or deny that PSCI thing ASAP :-)
> P.P.S.: For next time - I'd be happy if you could add a cover letter to your
> patch series..!

You were right, good catch!

[    0.000000] psci: probing for conduit method from DT.
[    0.000000] psci: PSCIv1.1 detected in firmware.
[    0.000000] psci: Using standard PSCI v0.2 function IDs
[    0.000000] psci: MIGRATE_INFO_TYPE not supported.
[    0.000000] psci: SMC Calling Convention v1.0

I'll fix that in V2. Thanks!