Received-SPF: pass (google.com: domain of linux-kernel+bounces-22531-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <fdf40fac-2884-426e-87f7-5cb1788616fb@quicinc.com>
Date: Wed, 10 Jan 2024 09:24:07 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 1/3] check-uapi: Introduce check-uapi.sh
To: Masahiro Yamada <masahiroy@kernel.org>
CC: Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers
	<ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        "Jonathan
 Corbet" <corbet@lwn.net>, <linux-kbuild@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-arm-msm@vger.kernel.org>, <kernel@quicinc.com>,
        Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>,
        Rob Herring <robh@kernel.org>, Carlos O'Donell
	<carlos@redhat.com>,
        Randy Dunlap <rdunlap@infradead.org>, Arnd Bergmann
	<arnd@arndb.de>,
        Bjorn Andersson <andersson@kernel.org>, Todd Kjos
	<tkjos@google.com>,
        Matthias Maennich <maennich@google.com>,
        Giuliano Procida
	<gprocida@google.com>, <kernel-team@android.com>,
        <libabigail@sourceware.org>, Dodji Seketeli <dodji@redhat.com>,
        Trilok Soni
	<quic_tsoni@quicinc.com>,
        Satya Durga Srinivasu Prabhala
	<quic_satyap@quicinc.com>,
        Jordan Crouse <jorcrous@amazon.com>
References: <20231212020259.2451253-1-quic_johmoo@quicinc.com>
 <20231212020259.2451253-2-quic_johmoo@quicinc.com>
 <CAK7LNASZzeJzZV0hiMrcKd6FUtQXqfuvUqux8Bf+WvBmjCwNCA@mail.gmail.com>
Content-Language: en-US
From: John Moon <quic_johmoo@quicinc.com>
In-Reply-To: <CAK7LNASZzeJzZV0hiMrcKd6FUtQXqfuvUqux8Bf+WvBmjCwNCA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

On 12/22/2023 9:50 AM, Masahiro Yamada wrote:
> On Tue, Dec 12, 2023 at 11:04 AM John Moon <quic_johmoo@quicinc.com> wrote:
> 
> The code looks OK. I think it should work as designed.
> 
> Line 197 is inconsistently indented by spaces instead of a space,
> but I can fix it up locally.
> 
> 
> I just thought requiring target commits as positional parameters
> ("check-uapi.sh treeA treeB" just like "git diff treeA treeB")
> might be intuitive, but I guess everything is specified
> by a short option is a design. I can live with that.
> 
> 
> 
> I will wait a few days, and if there is nothing more,
> I will pick up 1/3 and 2/3.
> 
> 

Thank you Masahiro! If anyone else has comments please let me know.

Cheers,
John