Received-SPF: pass (google.com: domain of linux-kernel+bounces-22584-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <9db8310c-e74f-4f66-bc4e-7af795ec5879@nvidia.com>
Date: Wed, 10 Jan 2024 23:34:44 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2] PCI/MSI: Fix MSI hwirq truncation
To: Thomas Gleixner <tglx@linutronix.de>, bhelgaas@google.com,
 rdunlap@infradead.org, ilpo.jarvinen@linux.intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 treding@nvidia.com, jonathanh@nvidia.com, sdonthineni@nvidia.com,
 kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com,
 Marc Zyngier <maz@kernel.org>
References: <20240105134339.3091497-1-vidyas@nvidia.com>
 <20240108120522.1368240-1-vidyas@nvidia.com> <87il41jy48.ffs@tglx>
Content-Language: en-US
From: Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <87il41jy48.ffs@tglx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cEM1Q2lOWUg4SmRidExId3kwUlI5S1NUVTRQZ04yUFNlUk9Oc2NzbEp6bzFW?=
 =?utf-8?B?MWN5MEFzbCtJR0xkbHJ5bEp5RktIRlNsTnNMYmlrT0FxZjRCT3h3cFgwbmU2?=
 =?utf-8?B?bE4vNEFMSFBTV0cvU3ZLT0l4QTREU0pnZnpYZE5UNzlJbDlObjA5MHIvTW44?=
 =?utf-8?B?dXlYUFRuYTk4MFA1cXNVSFNoLzBiTnQvZXAzS0xlWXp0cXpsMlhwMWp4Sjh3?=
 =?utf-8?B?WjRYMGlIWTIzb2hIVUZXS0ZqaFN6ZzF0MUxzR3NpcGFtTmw3am1qaDIrTGRn?=
 =?utf-8?B?OGRyTWhkRTloYldJZm1yODJJazk5SjVwbTViT2psZzlKcWIrVGdpOXZKV1c2?=
 =?utf-8?B?UklVcHFyNHhpWFRDTmh1anFORm9VNGdYUGtkOFRFVm9XcUxYZUlFd0VMY1ZU?=
 =?utf-8?B?U2NCNEJmc0hEMmZjQmE2bUZ4WERabmdOK0E4YVF6NnQwdnpTRVM0dXl0NllZ?=
 =?utf-8?B?UElCc0h3MnBRdEYwZStFRW1rdXdsWlE2R0xLcERmUUlpZkd0WUlWeVJ0a0tw?=
 =?utf-8?B?ZCtiUTRtZ3M2QkJ3YkxRUmFtUnE0L05aUUpYa1c0UmNRQ2cwOHp3RjRDSE1D?=
 =?utf-8?B?S1FTRVYrR25qdkthVTJ0ckdpR04yWXJFZUhIUDRuaWVrYVZHN0NZc2VMRmpj?=
 =?utf-8?B?L2NMRWpTYzJQMTJJQnN2SDk5aWtiQ0h5ZzZ1cm5GSVpObVpDbXYwM3VuOEcv?=
 =?utf-8?B?amdQdVdmY2NGVWlZZmk2aFBqOGZXYkdwblNXZTAzeWNTamIvSGVOZEtiTnU0?=
 =?utf-8?B?Y2UvcHF6MmlNYjJ3dHBOaU9ycGpYNXVVZlJXWlM5cHR5aFZETGJtdEUrRDZK?=
 =?utf-8?B?NmhOSHlOb0FNRk5aall2ZVl4VjRrV0I5RGVtQ2pPWEkzb0xKSWR0bUswTTJQ?=
 =?utf-8?B?QUhSY0RXWUZKbkxPZUk4UFJIR3pDSFpIanQ5VmVTWHVZdG9NVmtkUVBZUGFT?=
 =?utf-8?B?bFVVWXNYZGVOUE5iNGtVMzZKdVpxSVk4M0dWWWdQQXV2bGcwaGc1OGsrdjZQ?=
 =?utf-8?B?UVZWRU0rdGdoelBQRWhuWEpBQXlRUndxS2VnQ0hsd1MyOUdBdXdJRVVGMG1q?=
 =?utf-8?B?b01VOThERU5IQTltRWs0NEZ6Vmg0L0JwOXU4UERYOHdRMGZBSjl5VVFsajU0?=
 =?utf-8?B?R0lSUGNBbE51NzRib01HQTdTaHBtZGNxaTBGN2haYVNPRmV2ZWtGbjhnSmlz?=
 =?utf-8?B?OXYwSVVPMEJWK1gvNUIxNXpWWkhMV0llMElheVFyZUFwdGdZN2VBd0pjdUlR?=
 =?utf-8?B?cXpBam9JODlzdlJIQVBqNFoyOHdvcmVFWHJnRklrcnMwUnc4QWxrRWwxSExX?=
 =?utf-8?B?c0VXOVJGRW1kV2FIUDYyQjF5NlJrK2ZXTXN4RmlPcjRDcFpGRUF4bnZuNXZt?=
 =?utf-8?B?ZDEvenZiT1cxK1d1emdRcnNMOC84RS9nSUo2RGYxZTdkL2E1L2RvN2hkUHpo?=
 =?utf-8?B?Wkt2UWhTeGNpMy9BeUJEU0J6THJ5Zkd5OEJSQXhZT04rTklwekROM25UNlRp?=
 =?utf-8?B?OEVYRXR5NTVqZlQ5b1BpdFBpcUFrUFZ2MU9lZm5CQlVlSkpBaGMvb1NjTXlR?=
 =?utf-8?B?MWF1cHoyWnhuUG1EWWNXN2k1bitzQWVaWCtTR1pLdnY3eWExbENLTGhnK3hw?=
 =?utf-8?B?ZmtXNVhPYmdieTBSdVIrVHNVai8ycGtEN2I4TmNZdU50ZDdpM1I3MWl4MHZD?=
 =?utf-8?B?dW1VN2JXS0Z0WjlKNGpQalg2VEFaVGx4dVJjNE5lUGlZdGJ6bmIrdXJveDFn?=
 =?utf-8?B?MzdXSzB4MUNxYkVhZU5YbHp6SVBXdHhyMUp4SkdqbW5MNFhZZFljbCtHemZH?=
 =?utf-8?B?ZnEzZmJ3SmswTDRzOXIwUXY1bGxFRW96Rk5rQ2hUbDUyb2kzWmNqTWpUQXg4?=
 =?utf-8?B?d0ZyWVhlTnZJbFJ1VXYzOUdnMVlsR3Z4c2dxamVYRGwxenFHVHA2aEhLTlBC?=
 =?utf-8?B?YWp6aWFpU2JlZXBTUU45ek1ZeWRVUzk5UEZML2FlSWtIZElqYUNFMVV6TUZ3?=
 =?utf-8?B?MHJrN29rbFM3M296OTFmMmxUeFFsTDQ1Y1ZvNC9GZDBWL0RLdDc3bk1lU0dl?=
 =?utf-8?B?VDJYaTc5QUVkVGMwUndvbzJOcjQ5aVBaUzZBSFRUMzVqbDNIOUFHYittKzl2?=
 =?utf-8?Q?VLiCKatYXTYY7NOONshmzonuo?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81160bc9-927c-4973-35a6-08dc1206a587
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB6674.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 18:04:54.0452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZPlH5cZDir2p77tGT0CSBPEv6XR+cIWRleWqey8wyV27SKrz/R9cETiv2E9dvbZtBgz2GwhCHzotrQLK1NmmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8121


On 1/10/2024 3:42 PM, Thomas Gleixner wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Mon, Jan 08 2024 at 17:35, Vidya Sagar wrote:
> 
>> While calculating the hwirq number for an MSI interrupt, the higher
>> bits (i.e. from bit-5 onwards a.k.a domain_nr >= 32) of the PCI domain
>> number gets truncated because of the shifted value casting to u32. This
>> for example is resulting in same hwirq number for devices 0019:00:00.0
>> and 0039:00:00.0.
>>
>> So, cast the PCI domain number to u64 before left shifting it to
>> calculate hwirq number.
>>
>> Fixes: 3878eaefb89a ("PCI/MSI: Enhance core to support hierarchy irqdomain")
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>> V2:
>> * Added Fixes tag
>>
>>   drivers/pci/msi/irqdomain.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/msi/irqdomain.c b/drivers/pci/msi/irqdomain.c
>> index c8be056c248d..cfd84a899c82 100644
>> --- a/drivers/pci/msi/irqdomain.c
>> +++ b/drivers/pci/msi/irqdomain.c
>> @@ -61,7 +61,7 @@ static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
>>
>>        return (irq_hw_number_t)desc->msi_index |
>>                pci_dev_id(dev) << 11 |
>> -             (pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
>> +             ((irq_hw_number_t)(pci_domain_nr(dev->bus) & 0xFFFFFFFF)) << 27;
> 
> This is not casting to u64. It's casting to unsigned long:
> 
>    typedef unsigned long irq_hw_number_t;
> 
> So this works only correctly on 64bit. On 32bit kernels unsigned long is
> still 32bit. It's probably arguable that the 32bit case is not a
> problem, but the changelog and the change do not match. This needs a
> proper explanation why we don't care about this on 32bit.
Agree that the change and the commit message do not match.
I'll update the commit message to use 'irq_hw_number_t' instead of u64.

Thanks,
Vidya Sagar

> 
> Thanks,
> 
>          tglx