Received-SPF: pass (google.com: domain of linux-kernel+bounces-22586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <ae49227b-5026-43a4-8e19-aeeb63865a6a@broadcom.com> <20231213195947.GA1056194@bhelgaas>
In-Reply-To: <20231213195947.GA1056194@bhelgaas>
From: Jim Quinlan <jim2101024@gmail.com>
Date: Wed, 10 Jan 2024 13:05:21 -0500
Message-ID: <CANCKTBvaFBXAVTBtr4tpz5mYcyP1w84nAEGHbOnGJugogHx4fQ@mail.gmail.com>
Subject: Re: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ# mode
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Cyril Brulebois <kibi@debian.org>, 
	Jim Quinlan <james.quinlan@broadcom.com>, linux-pci@vger.kernel.org, 
	Nicolas Saenz Julienne <nsaenz@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, 
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Phil Elwell <phil@raspberrypi.com>, 
	bcm-kernel-feedback-list@broadcom.com, Conor Dooley <conor+dt@kernel.org>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>, 
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, 
	open list <linux-kernel@vger.kernel.org>, 
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@lists.infradead.org>, 
	Lorenzo Pieralisi <lpieralisi@kernel.org>, Rob Herring <robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 13, 2023 at 2:59=E2=80=AFPM Bjorn Helgaas <helgaas@kernel.org> =
wrote:
>
> On Tue, Dec 12, 2023 at 03:51:12PM -0800, Florian Fainelli wrote:
> > On 11/26/23 12:19, Cyril Brulebois wrote:
> > > Hi Jim,
> > >
> > > Jim Quinlan <james.quinlan@broadcom.com> (2023-11-13):
> > > > V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
> > > >     -- Squashed last two commits of v7 (Bjorn)
> > > >     -- Fix DT binding description text wrapping (Bjorn)
> > > >     -- Fix incorrect Spec reference (Bjorn)
> > > >           s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
> > > >     -- Text substitutions (Bjorn)
> > > >           s/WRT/With respect to/
> > > >           s/Tclron/T_CLRon/
> > > >
> > > > v7 -- Manivannan Sadhasivam suggested (a) making the property look =
like a
> > > >        network phy-mode and (b) keeping the code simple (not counti=
ng clkreq
> > > >        signal appearances, un-advertising capabilites, etc).  This =
is
> > > >        what I have done.  The property is now "brcm,clkreq-mode" an=
d
> > > >        the values may be one of "safe", "default", and "no-l1ss".  =
The
> > > >        default setting is to employ the most capable power savings =
mode.
> > >
> > > Still:
> > >
> > > Tested-by: Cyril Brulebois <cyril@debamax.com>
> >
> > Thanks Cyril! Bjorn, Lorenzo, any chance this can be applied soon? Than=
ks!
>
> Seems OK to me if Lorenzo or Krzysztof W. are OK with it.
>
Bjorn,

What is the status of this submission?  Stock Linux on RPi4 CM4
systems with a PCIe device  panic on boot until this commit is
applied.

Regards,
Jim Quinilan
Broadcom STB/CM