Received-SPF: pass (google.com: domain of linux-kernel+bounces-22784-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2f0efed5-f9f3-4a5c-9fd4-a4837cada298@prevas.dk>
Date: Wed, 10 Jan 2024 21:47:56 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] workqueue.c: Increase workqueue name length
Content-Language: en-US, da
To: Audra Mitchell <audra@redhat.com>, linux-kernel@vger.kernel.org
Cc: tj@kernel.org, jiangshanlai@gmail.com, hirokazu.yamauchi.hk@hitachi.com,
 ddouwsma@redhat.com, loberman@redhat.com, raquini@redhat.com
References: <20231215193954.1785069-1-audra@redhat.com>
 <20240110202959.249296-1-audra@redhat.com>
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <20240110202959.249296-1-audra@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVZGN0JaV2Y5cXBVOVE0dG9LWEhPcE1rK3B1WTNjQUpXeWtUd0lPbHpmS2tE?=
 =?utf-8?B?MlpncTJTSVdqY3BzYUVvaVMvbkQ4QnF0RThsTkMzaXJDNWRZZTFtZ3RvM1Ex?=
 =?utf-8?B?TEplUS9ObVJjS0RES3VTM0k5Ujl1Y1lTVks1NFNoWGRkRWhUVFVjZFBYZUR2?=
 =?utf-8?B?UEVJVWFYNzBha0J4SGtIeENnKyt6b0lyeExjZEEzKzBaWGFsMkN1UHdOQTZJ?=
 =?utf-8?B?Vzg0YzZQa1YzcEhhU1M3QXVBVExubGZBK2JvNjdUQTc1R09xcEZHcGFNcEVN?=
 =?utf-8?B?Sk1OZitvVmpJNGhOV2hXZ1ZwL01ydUV6SEQvYmlTY0RpYzVBZkMrT2dlTXVm?=
 =?utf-8?B?NVN2Tm9DZEdHek0wTkRhSTIweUdRYkpnNXk2aHAvUHNwSzJJZjRNWDNoOTkv?=
 =?utf-8?B?THo3c2RLRnFLdnhBZkJSemtEYVZnbHNJOFk4MzdoL3J0UFAvRm4rZE5Kck9J?=
 =?utf-8?B?NlpONnUwM2hCazhaNE41MmVvVEtEWjBSbkRtbUZkRWxoU3kxTlI2RGZFenhr?=
 =?utf-8?B?QzQzU2M0eWxUb1lNc1JNQjFVYXJPN2VGQ0dvWVQvc0sxcWc2eFQzR3g3bmRL?=
 =?utf-8?B?SDJvRnRnN3hleTEzajV6RzIyUSs2M3lvaHRUWDdJWThrZTVZczdUV3lFR1lC?=
 =?utf-8?B?amUwTmFKcFo5ZWJwc1Q3UVMzTWQ4ZVR1aGxJSlVxRmRjc1Fab21KUCt1REdn?=
 =?utf-8?B?bkUydjRpQ1h1c01sT2luNDNSajlVUDJFeGJhaVBDMUlXMm4xZnhpQTVjeDA3?=
 =?utf-8?B?dHZVc2l4VFNhVG5EQ2VOSHp4bVVTeUR0TVpMODA2MC9xYVFFR0ovbFdTRHZV?=
 =?utf-8?B?SmovbDl2aWdkU3M2U0xmWndsS1dsODh1aFY2M05pSTZaRWhSY3R1dTdzekZL?=
 =?utf-8?B?L3FDRXlPWFpCTnNUQ2hvQjR4K082RUtYS2lqOXdvVEw0WStxN1JKMk93V3JR?=
 =?utf-8?B?NGw2UG9ydGlSNEVXT3ZnbSsxbGlYQUlaTFBPTHh6NFdDeHZMSjJmam9aenBC?=
 =?utf-8?B?L29DdTJaRFJjclZ5am03eUpNQUgyM2o3Z1ltZkNTUmtQV0k0QjFBNk52YWJL?=
 =?utf-8?B?cCtRNm5WTFFzbHhXZXBQeE94dmFnQ2Jta0F3VTF2bFpWU3pkMjVyN1pHWjl5?=
 =?utf-8?B?K3lSNzFGVkt4VFdXYkdXRGh1eW5KdHloRG9LWVFQOU1abUpZdnVVTXV4MEZy?=
 =?utf-8?B?OXU3K3Q2NEJhdHl0bkxNVTJDTW50L2N1U1dmTjdzTWt0YWRaTmh0VTFEamZv?=
 =?utf-8?B?Wm5YWmxuTE5XRUZKMnlDa0RNbFZiVlAzY0tOWWlEM21ZRFZweW5PbXdVTnEw?=
 =?utf-8?B?RlRWVkt0ME9SZjM0ZkQ2WHNkaUdPVU42TjUyejZsSmRiQ3FJMTlGd2huMVh2?=
 =?utf-8?B?ZzN1T1RCUTRzcHgyeHdPbEFuM1F6RllVSEhCdmFGQmlob3h0eUEvMEJwNzhW?=
 =?utf-8?B?M0N6dStqSU1zOVpEU3NGbWs2QnM2WWVmV2pIK21jUFFBOXlEVGJoSWwyQ054?=
 =?utf-8?B?eTJQR3M4bWEzRmtHVVBMcnFVQk92dDNEelFTYXJNb0djZlRQWFMxQkRZWnp5?=
 =?utf-8?B?NEJQenhlR3QrMitrTmpZTnE1dEp5RnB2d0hpbmIvY2haN1VHbjQ3LzFKdlhF?=
 =?utf-8?B?R1hydXdjY2pMdWxCcVJEdXp3WTBXSE5HTTJOQkZ3Q25uSUJ4R3FScFNEY3kz?=
 =?utf-8?B?cjJjRDE2WnlKc0ZoamlnUmU5TkNQRCthYTE3dU4yb0E0M0c4cVNXcWNPbThG?=
 =?utf-8?B?bXpyVnNsQitpdUd6T2o2SzZOdmp0ckU0QzB3V2d6TlBCakxTNTJSS2ZHeGlt?=
 =?utf-8?B?WE1mUFM3dHFMYnJENUREOUdEMUlxRlZFSlQzL1N3VUNHOFBEQ3RraE9MRkFj?=
 =?utf-8?B?aVJVTG5uY1o1WXRGYXJmRm9SRm5RTmF2Z01QMTUwdzJ3ait5RXlSVHRHb1lu?=
 =?utf-8?B?bnNGWWtycGgyZlZxR09HYTVaOUxROUNvekkvdlcxclEraXA0dlZHQmYrR1RY?=
 =?utf-8?B?OFMxSmpLNHdIOGFkUkRxbjViUTg0ME1nTWl3R3g2T2dIUkRwVUoza05JcWgv?=
 =?utf-8?B?ZnA2c0VoZklnOFF6TW1UaG9vczA0UlFjRWF4YXk0NGpwdjFFSjVTMVhkV1ZZ?=
 =?utf-8?B?bnplTTdPemk1L2pXeHlqZVBUU2J4OTRRQklzTHBHd3cvMkUvcHhraTdKWFR2?=
 =?utf-8?B?Y2c9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: 72d3654b-7dae-4d43-283a-08dc121d6e3d
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 20:47:59.3998
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2d9VYm1eMJtOYKvK6wyJcwbW4gPJWXa9Arm2w+tRapnP/VKS4TL7jETKDjoajlSLVYINVmZZF+7SiXQr5UHCaibjb932bsywSRD4Vp1DdI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB7002

On 10/01/2024 21.29, Audra Mitchell wrote:

> @@ -4663,9 +4663,10 @@ struct workqueue_struct *alloc_workqueue(const char *fmt,
>  					 unsigned int flags,
>  					 int max_active, ...)
>  {
> -	va_list args;
> +	va_list args, args_copy;
>  	struct workqueue_struct *wq;
>  	struct pool_workqueue *pwq;
> +	int len;
>  
>  	/*
>  	 * Unbound && max_active == 1 used to imply ordered, which is no longer
> @@ -4692,6 +4693,13 @@ struct workqueue_struct *alloc_workqueue(const char *fmt,
>  	}
>  
>  	va_start(args, max_active);
> +	va_copy(args_copy, args);
> +	len = vsnprintf(NULL, 0, fmt, args_copy);
> +	WARN(len > WQ_NAME_LEN,
> +		"workqueue: wq->name too long (%d). Truncated to WQ_NAME_LEN (%d)\n",
> +		len, WQ_NAME_LEN);
> +
> +	va_end(args_copy);
>  	vsnprintf(wq->name, sizeof(wq->name), fmt, args);

Eh, why not just _not_ throw away the return value from the existing
vsnprintf() and do "len >= sizeof(wq->name)" to know if truncation
happened? There's really no need need to do vsnprintf() twice. (And yes,
you want >=, not >).

Oh, and definitely not WARN,  pr_warn() or pr_warn_once() please.

Rasmus