Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1236547rdd; Wed, 10 Jan 2024 13:01:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3LPh3HfaCpPoo4qFPIAE528ga0FomJMREgNGEAX7ybUR4mBe5FJk8powelYNR74fo3zDV X-Received: by 2002:a17:906:d78a:b0:a27:9365:ef73 with SMTP id pj10-20020a170906d78a00b00a279365ef73mr53511ejb.38.1704920501906; Wed, 10 Jan 2024 13:01:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704920501; cv=none; d=google.com; s=arc-20160816; b=dFdxwn5o/laonoX7Jkrw1V1WyH64SKBKrVb43jlqBr/ofdnJXM7MEW9Znyf0VBqBDO Ub86brdnHmvp4IZiMbnBehuf6Ci2UNxQ33/InQd7anUbdcW3ut4XliS1iuhI3EmT2NMo gNZo1N5FSu9eTEpx480nwxyM6923TpEq0nDh2Q1UzeXO8mXqyo1QBiyZ9/I3+rRv126d 9XOK1WzLVn9lXHF4PnXedG5/9ssTCM75vw2ivtDrCDjBYu5eFz2Ti4p829fz1HAzcQfy CgExnT6U+JC1sCJ1CRb3tLlmWwvGCz/YarOifX4BWXB5eUrK6Wnp5s0X3ioW5Nab54SZ SK5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=Sa5fnqqzjddF1S3Y2dhVdJ4/5d6xTgX/nkIl0hi4V34=; fh=DJQSGXLaFp5i11p10UTsjZlaGOUH7G3i3FzH88dCAKk=; b=p9JBQpq9J7rfDwbCCd3lNmOuODOoMM0Ztr3zSEgNou+XdjeZZm0qQP0HRGJic6a89d d8O3BXjNuZmBbXTSxxH4dP+IwqH4oBylU0gxxSHnPvWOhSVU6oUInvNfS5NP1bvT4fxz v4RJrTs1XoQ7ussdhchBuYIeAgBYqLHt6PpU7rUzQlrwBrH9N+3bT8t4fz+jueeiWjUp 8fNd8uEG5D/KtOi6J0ghfP1noZ2rSAPwC8rXEGfKAhTKPbbrKjFAYi16wF5degSFPucu BkbAdb0x9ye9lJeXakHklojN+FprodcvoYdZUluMSNl6HzbX+6OfDvzUPVNP72MKZFfe 07Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=sIf9EmCN; spf=pass (google.com: domain of linux-kernel+bounces-22786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22786-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id bu2-20020a170906a14200b00a28a963d3f8si2073352ejb.1049.2024.01.10.13.01.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 13:01:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=sIf9EmCN; spf=pass (google.com: domain of linux-kernel+bounces-22786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22786-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1BCA21F2340A for ; Wed, 10 Jan 2024 20:51:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A21AF524BD; Wed, 10 Jan 2024 20:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="sIf9EmCN" Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1561D51028; Wed, 10 Jan 2024 20:48:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1704919718; x=1705524518; i=markus.elfring@web.de; bh=mjRumUd/MQiEBX/hnG0E6F4D3lIQxntbIeEL/wnSQDQ=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=sIf9EmCNdVoXDZb/cGz6fkXGBepk8yuZpzid1qfkbZm8REX52C5JFSeC8D6Ita0M E7FH7LX+CqCPfI/l/XlNfpFyBRxGcAnWcIPJ1n7DyskHpaPNAuPWK4kC/YM93laxo XXFxRgV7cz/KYo0ZiAsokd6glAzuyZrdWKp09zUNQyhZsc0FJfsG8NtHv5XysU7VM /m1r92mhvFijB8Y6M4On6yLb+krgsIVzFltDYyIMavak70bCNxQZCYd5a7wlpLQJB sN2XBdhlb9JGEV64BfiDLauOh92ujMqyxUP9B72fuBdz3W0HCPV8NBlaQSHeIa66Q xKo8DXqB+8sEJ6Z5/w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.86.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M8T7K-1rJHmw2Zu4-004vkg; Wed, 10 Jan 2024 21:48:38 +0100 Message-ID: Date: Wed, 10 Jan 2024 21:48:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/2] io_uring: Delete a redundant kfree() call in io_ring_ctx_alloc() Content-Language: en-GB From: Markus Elfring To: io-uring@vger.kernel.org, kernel-janitors@vger.kernel.org, Gabriel Krisman Bertazi , Jens Axboe , Pavel Begunkov Cc: LKML References: <6cbcf640-55e5-2f11-4a09-716fe681c0d2@web.de> <878r4xnn52.fsf@mailhost.krisman.be> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:tptgrZvV5PfMbUHwW6P4eDBBUBiG1tmbpEQj6/acmNCuSqQx27g K+ga9sH7CSPTmn6XL19Wc9V+Z0s5fwVNUXYa6xwM5qpweC9uLfXSFer0olwGLBV7fQxGXAQ hERce4VbaG0G4j+XcVesEU/syab3gkyaLCUsgUF1hmAOOdKYf00Lt8bIpIRVmFRy84POqSl O598LlZB6lQCQZLr7Fgpw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:YmH1HGl/x+c=;RX8z9bvCEUZpdLFXHMwnVfQ41/8 Hgi5MWw62zwwMVmDQc8hAf3iwJYWmtftnrXnytC6L77ndrsVebKAT6ESKVZIfjC5nFq/DFP2B bSCyn2hJrTYzW0SfP2Pw1s2xuVV10mDjdZrEf07HQDKeoavdizFGNfSmAOWx/08wxq60YYrmq pq4C6voELMEb1zJ0+HrCgsRlHyjtmaBIh28doYqAg4/obeM+XVVSRcRr6uoSKl8/gB0QefgC7 XCmi6Y/lSKQPOL/Fbc7IuMkw0KW6dU/LlhRFevoJsVvQiqduaNr59UkHuQYyaLGUwHDCeD1t8 fFbFygIJRnbafDZRgqXM2I4JTWkWyfWjxZVCjY8UKdindOgUA98TVq2oTsu5Jiq7GZQtDv71g mXU1ys2Q7Q7OJc9gtbPR1AcFe4Y4/SQFRzoX4qPWLFWKiktNkeVAW0QII06a5CjprPE1s6oaK kaYDpIXvKAdMO4snSKF5VA+u3ZGjw8GtrPr4nMGOGMeUy1Gw+FQOeK8yx7MEHOiPQyRfp8kq1 QiaZ6Yg+cdZ4TM4aiD9rB4UTskM/UB2eORu2/DAS2qRQHcF/mH7rdqb2mLz/YZXqkHgeDLINN NY6s4M3GUz8us5KH8gCLuWLfjnPMlJOBMOTM7CpSYeDcqUhiQSl+CliJB4/QoggyTifL44PzR 0mkuCfn7dBd7qA5Dz5JYvXYSX8A+toWnoCasG/AXp52jrSEW+0DwWrCAxRtyQc88F9ToFndRF Oyqlk7zaEbdSZ9M5Q81N2bx+GFShmdMSq9rQbsj3VylQNC6Yi8ILwco9+OmGT47uHlhfqwFpI 8Clo9xA6O7l/diBLcX5K2UbNtdk9qM3IdP2FkpqK5IXYbrSoFtb1j/cOf7KMvpo6Yq9/E4X87 x7kBzqwHmalAvmTinIbXzI7IMCwNHg9jhqeh8FthnJnC3B0uneDu9cJFyhrovBIIgqvcCVjK6 EFsHLA== From: Markus Elfring Date: Wed, 10 Jan 2024 20:54:43 +0100 Another useful pointer was not reassigned to the data structure member =E2=80=9Cio_bl=E2=80=9D by this function implementation. Thus omit a redundant call of the function =E2=80=9Ckfree=E2=80=9D at the = end. Signed-off-by: Markus Elfring =2D-- v2: A change request by Gabriel Krisman Bertazi was applied here. io_uring/io_uring.c | 1 - 1 file changed, 1 deletion(-) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 86761ec623f9..c9a63c39cdd0 100644 =2D-- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -344,7 +344,6 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(st= ruct io_uring_params *p) err: kfree(ctx->cancel_table.hbs); kfree(ctx->cancel_table_locked.hbs); - kfree(ctx->io_bl); xa_destroy(&ctx->io_bl_xa); kfree(ctx); return NULL; =2D- 2.43.0