Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1254548rdd; Wed, 10 Jan 2024 13:39:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+yP/OvYykBia3GKeFJaiEvNH3DCaDl4Lel3CDXAQCmRPyIgu7p5z7OpL3Z6LVhnmRYrkL X-Received: by 2002:a17:902:bd87:b0:1d4:e04b:62b7 with SMTP id q7-20020a170902bd8700b001d4e04b62b7mr183596pls.94.1704922781360; Wed, 10 Jan 2024 13:39:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704922781; cv=none; d=google.com; s=arc-20160816; b=nyNifs8eelnNGVbWMuQZKS7VEFRSaZbkliCf5BZ4VFWC3opcWsGXdqKqk/JLZ1LkWT t0Ro1ohuLf0awJe79YybyD0onvmjmIM6hjcptKNQ/qj3aVrErSOBK5mVY/byYY+HkxOp OKgoGbk2LQBViEWeQS6beZtce+4GuhIZK2ZJs+827voQ3H3wHZHVnePkoV/jvPFJ5I6f 4C5L/Ygq2rPwpWKdOVEF6qJcJASPCNPsd6FtWcuZyK40a1EaDIUOGrSBqbL3QCGKVBFo 5AC5NVHgyEllfU+bRAdUtbr/m4VkYtFyRaXplvHVfvV0nk0e4EQ2nXMnshJGcajXVKTn LYww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DJs/aqXUnhvaEv09n+IiVk3ga2FH60y+Ukrx6o4jZbQ=; fh=TJM+t2b4q/Ru5jrWemqL4qvDsEM78FSxrObmDUUlOG0=; b=wqLAeu6FsiaCFsguPSeyDJWqZpYoys4Tg0ARC4X+PeQFfhh5LpREu5i95CGvmtRzTy MMCkE4WdcTxR9QmdNMmoenjLG3chnCmhOyO7CKPaDQfoOW3qF/bmdw2VPSs3fUIuUpmm GCE72e0PgqewzR6bznqAldk5IOLGoQNobPzY8WP1QZhRAhbYujZ0rzQc8V+PeKRDL/7M pzJVKWsEgwQ6xfRVPoD6nRWs0J6Ifv9NL2Svu2Yi1Jxtzu2w3LacvPJ6eOfbLUd8WM0W rRN2SVERLm7t1nLYm23fKRD+LFCb8mmBHGdheHVhUyB+eVHCi82nLdBuh6fk0ODxsVTo OKcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S7yBG0E2; spf=pass (google.com: domain of linux-kernel+bounces-22827-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22827-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u15-20020a170902e5cf00b001d361219d38si4121797plf.627.2024.01.10.13.39.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 13:39:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22827-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S7yBG0E2; spf=pass (google.com: domain of linux-kernel+bounces-22827-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22827-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3B863289798 for ; Wed, 10 Jan 2024 21:39:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E3894F886; Wed, 10 Jan 2024 21:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S7yBG0E2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D2CA4F881; Wed, 10 Jan 2024 21:39:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88B2EC433C7; Wed, 10 Jan 2024 21:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704922770; bh=+Wf7dFM17PCABnP3QlI61RztpXdJ/Fz/yzIT4/4Spug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S7yBG0E2a1Sz84oeUwEKBr44W50AjEf9pnpurhmA0TqQQSArk8VhOFEvVw0sISm26 en2s3k6O57umIjEYLVCs3nbA1594KwVL5a8EnHth9ZEZNvudeE/G6/V9kK3g/+ymcG 7bhnNVlWYHnhWwQbZrej1shbDauFtUPmJM93tKND5qjt8KYxEnxswddIbjLT+y8aDU iKttw+UBKMjKjrrWV/26ecB6TrBBU+zIleL6TbLovs67UyBUgN1O/yd+vCCl0tz5wl Sfa0S1Et5VR8RdzAXWFANC8hh/Mn030iP7G3JGALDfrSw6Fns3hJjuL3HLnwpkSNUI oNSgBf//GQNkw== Date: Wed, 10 Jan 2024 21:39:23 +0000 From: Mark Brown To: David Lechner Cc: Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , Nuno =?iso-8859-1?Q?S=E1?= , Frank Rowand , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonathan Corbet , linux-spi@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen Subject: Re: [PATCH 05/13] spi: axi-spi-engine: add SPI offload support Message-ID: References: <20240109-axi-spi-engine-series-3-v1-0-e42c6a986580@baylibre.com> <20240109-axi-spi-engine-series-3-v1-5-e42c6a986580@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vA0E8xm0iXmuRqc+" Content-Disposition: inline In-Reply-To: <20240109-axi-spi-engine-series-3-v1-5-e42c6a986580@baylibre.com> X-Cookie: Do you have lysdexia? --vA0E8xm0iXmuRqc+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 10, 2024 at 01:49:46PM -0600, David Lechner wrote: > This adds an implementation of the SPI offload_ops to the AXI SPI Engine > driver to provide offload support. >=20 > Offload lookup is done by device property lookup. SPI Engine commands > and tx data are recorded by writing to offload-specific FIFOs in the > SPI Engine hardware. Glancing through here I'm not seeing anything here that handles DMA mapping, given that the controller will clearly be doing DMA here that seems surprising. --vA0E8xm0iXmuRqc+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWfDooACgkQJNaLcl1U h9CJ8wf+IdN87MPrgtB1OLZ7i6VO0ejFYyduotqQrFiECH4HDV73++1TiR9FGcG/ hqgtxpVCkSyWFqpqDhkdBaOFRZp4YNbTlaOkjkFGXmNQSnBqJwQHbQW0Ipi57mB+ jm+GbuJTZODou/WIWxWBiYF0C4nVQz9XtwU5aOJVuo+2kNTZjcCK+SN8uZIZEw3j SbyxkVUA/6thCgvZK38hpPPuP8P12Hkdpb1lrA3AdyP3TYQXYOpxmzFciCGk5OM3 DS0wx7m1Cgvq+Dj8XfdxBgpTaBAw9IGfDdEU5ArSKBv9Wrg0tqXkxEsZ4oPD47dQ uvru/KvjQwUFC4S6UVreNedMuupfKw== =Wfhe -----END PGP SIGNATURE----- --vA0E8xm0iXmuRqc+--