Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1304918rdd; Wed, 10 Jan 2024 15:39:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/ehCLJWKWa+oOBcZb4ZPahWWooWHcYiNYPxth1r4xalqGE9mzLZlP9xv4vgJft63fE3Ir X-Received: by 2002:a05:620a:2943:b0:781:5fbf:eedf with SMTP id n3-20020a05620a294300b007815fbfeedfmr530617qkp.38.1704929974984; Wed, 10 Jan 2024 15:39:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704929974; cv=none; d=google.com; s=arc-20160816; b=nY3BPWFNKtQPWgNTLWq9dNANfS+dTfh9/SnBWIyZBXjIlH30ds3WRF6wOoJD6P1qrV fzhZEtUY0ttmBZga/VaWK8qRkuhNhwLKy0fe5+51sku2wE01Y1AmJzBQWQM4lNANZ60x OQ+s1N6PU+oxEzwRGmqhKkg5uFj3/jb5guRJtTysx5Lex8f9oUjwrybtmoUArn8RcdFr wyOyVfnmRPbRc1d+8UZzRd9f3fynVJuATZBmEI7gtVbJ/tv6lRNqdOeA9+fJfqyi+LsW ZWrhgQ1eCh1IM0M3yGiuLsZ7nmvmCw4i+bvjwUlHwjbgvZgKSckiUxkM9lqHCKIdYlyR +HUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=zRipWfFdSVdCns+xvov2FS2oYSIqI3pCJzj5zKaV9k0=; fh=IiVD4F5tAYj0Vvz4/JyrbCqYxm9Q13H44CQVIH/R4Hk=; b=b+GKOwbybyfO8PY7RL96I3E+QZiUY3SihS4xE5jESRd83nP3WDO6KYcezLLlLptY6g 582VkkmolpdaPkHYgLo4nZLu408LvPSDCOtRL+DR/GAa9Mb0CKs0HFR9aaTC2Ljlj0oQ iA6oZ3poVPrHD9L6/asIpMxDgg8cWv2gRdakqHDCIWR7KbxCZ+FwbimmAObMc9BkWMt4 tiPEscBcljP6TPQjC8u5LBSGjuARZ0G5lkWmTRQDVL9Ht5DTZZWJIbym+X4VZMBxaL48 zXstq1pVqMxCBHHdnbPgQfbDsjKaw4CYKqVhlYzCv9sP7aLkDIbmCHHNI879UYDXKMr/ QR7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=VLA8PK2U; spf=pass (google.com: domain of linux-kernel+bounces-22891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22891-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id bq38-20020a05620a46a600b0078326f3e552si5536777qkb.334.2024.01.10.15.39.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 15:39:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=VLA8PK2U; spf=pass (google.com: domain of linux-kernel+bounces-22891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22891-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A85341C22EC6 for ; Wed, 10 Jan 2024 23:39:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DEC5250251; Wed, 10 Jan 2024 23:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="VLA8PK2U" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C847750243; Wed, 10 Jan 2024 23:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40ANQ5HD009384; Wed, 10 Jan 2024 23:39:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=zRipWfFdSVdCns+xvov2FS2oYSIqI3pCJzj5zKaV9k0=; b=VL A8PK2UolkVn334isYXNt0I0qfMwKiHcBUHxUCmZ4mztGkjbASDhUY6igaZVQ9KOp bwuzCuBY0+dNvcgLZkd4LJmRYONICBXCWINlniQT+2X4XFMhPnocG1xjqSuofM1r 4nwyfjT4qZ3/ucvgjTK2sKoa8MIgMXdAZLGMx5k1IqlBafQQaj3p1FNNoQW+M4uS mAw/vreCUCHX/FvjGzfFZ4gx9TfW0fjMEbH56sxtIOh9DoLVHaCMfanMxQRbuZ/j IqIk3IZfnlHcLopwhIWBuclIOa3Lw3vu5w2LZ9Kr3o1oUHnkq9GfnJEKT8MbTgx0 /9g8U0Mmy/BpAhTN4DGA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vhvhp16wg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 23:39:02 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40ANd1VS017282 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 23:39:01 GMT Received: from [10.71.109.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 10 Jan 2024 15:39:00 -0800 Message-ID: Date: Wed, 10 Jan 2024 15:39:00 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1] drm/msms/dp: fixed link clock divider bits be over written in BPC unknown case Content-Language: en-US To: Kuogee Hsieh , , , , , , , , , , , CC: , , , , , References: <1704917931-30133-1-git-send-email-quic_khsieh@quicinc.com> From: Abhinav Kumar In-Reply-To: <1704917931-30133-1-git-send-email-quic_khsieh@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Pk_YRuNpcRqcaHgNxKc7DX7asfTftLic X-Proofpoint-ORIG-GUID: Pk_YRuNpcRqcaHgNxKc7DX7asfTftLic X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 impostorscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401100187 On 1/10/2024 12:18 PM, Kuogee Hsieh wrote: > Since the value of DP_TEST_BIT_DEPTH_8 is already left shifted, in the > BPC unknown case, the additional shift causes spill over to the other > bits of the [DP_CONFIGURATION_CTRL] register. > Fix this by changing the return value of dp_link_get_test_bits_depth() > in the BPC unknown case to (DP_TEST_BIT_DEPTH_8 >> DP_TEST_BIT_DEPTH_SHIFT). > > Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 5 ----- > drivers/gpu/drm/msm/dp/dp_link.c | 10 +++++++--- > 2 files changed, 7 insertions(+), 8 deletions(-) > Reviewed-by: Abhinav Kumar