Received-SPF: pass (google.com: domain of linux-kernel+bounces-23014-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Chukun Pan <amadeus@jmu.edu.cn>
To: krzysztof.kozlowski@linaro.org
Cc: amadeus@jmu.edu.cn,
	andersson@kernel.org,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	konrad.dybcio@linaro.org,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: ipq6018: enable sdhci node
Date: Thu, 11 Jan 2024 11:10:26 +0800
Message-Id: <20240111031026.2175521-1-amadeus@jmu.edu.cn>
In-Reply-To: <4f070678-63b6-4657-ad4f-c32256adbf1f@linaro.org>
References: <4f070678-63b6-4657-ad4f-c32256adbf1f@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On 10/01/2024 16:10, Chukun Pan wrote:
> Changes from v2:
> * arm64: dts: qcom: ipq6018: add LDOA2 regulator
> No Changes:
> * arm64: dts: qcom: ipq8074: add MicroSD node

I wrote it wrong in cover-letter, it's ipq6018, not ipq8074.
No Changes:
  arm64: dts: qcom: ipq6018: enable sdhci node

On 10/01/2024 16:22, Krzysztof wrote:
> How? It is disabled...

Disable it because not all devices have eMMC or MicroSD connected.
I enabled it on the dts of the device and tested it on my ipq6000.

> Aren't these three properties of the board?

These are just general properties.

Thanks,
Chukun

-- 
2.25.1