Received-SPF: pass (google.com: domain of linux-kernel+bounces-23021-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <cc9b456f-31f6-46f0-a6e6-f553779a775b@kylinos.cn>
Date: Thu, 11 Jan 2024 11:21:46 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ubifs: Remove unreachable code
Content-Language: en-US
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: richard@nod.at, Artem.Bityutskiy@nokia.com, kunwu.chan@hotmail.com,
 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20231111143314.1518314-1-chentao@kylinos.cn>
 <CAFLxGvzAncnBTEbHZ0pA-oF6n9P+wKFMugz8c+8UQKoPeBiYig@mail.gmail.com>
From: Kunwu Chan <chentao@kylinos.cn>
In-Reply-To: <CAFLxGvzAncnBTEbHZ0pA-oF6n9P+wKFMugz8c+8UQKoPeBiYig@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable


On 2024/1/5 23:55, Richard Weinberger wrote:
> On Sat, Nov 11, 2023 at 3:33=E2=80=AFPM Kunwu Chan <chentao@kylinos.cn>=
 wrote:
>>
>> Because there is no break statement in the dead loop above,it is
>> impossible to execute the 'err=3D0' statement.Delete the code that
>> will never execute and initialize 'err' at the start of the function.
>>
>> Fixes: 6fb324a4b0c3 ("UBIFS: allocate ltab checking buffer on demand")
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> ---
>>   fs/ubifs/lpt_commit.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
>> index c4d079328b92..d4751628fe70 100644
>> --- a/fs/ubifs/lpt_commit.c
>> +++ b/fs/ubifs/lpt_commit.c
>> @@ -1589,8 +1589,8 @@ static int dbg_is_node_dirty(struct ubifs_info *=
c, int node_type, int lnum,
>>    */
>>   static int dbg_check_ltab_lnum(struct ubifs_info *c, int lnum)
>>   {
>> -       int err, len =3D c->leb_size, dirty =3D 0, node_type, node_num=
, node_len;
>> -       int ret;
>> +       int len =3D c->leb_size, dirty =3D 0, node_type, node_num, nod=
e_len;
>> +       int ret, err =3D 0;
>>          void *buf, *p;
>=20
> Now it is still dead code.
> A few lines later err will be used for the result of ubifs_leb_read().
> So you can remove the initialization of err completely.

Thanks, I will modify in v2 patch.

>=20
>>          if (!dbg_is_chk_lprops(c))
>> @@ -1646,7 +1646,6 @@ static int dbg_check_ltab_lnum(struct ubifs_info=
 *c, int lnum)
>>                  len -=3D node_len;
>>          }
>>
>> -       err =3D 0;
>>   out:
>>          vfree(buf);
>>          return err;
>> --
>> 2.34.1
>>
>=20
>=20