Received-SPF: pass (google.com: domain of linux-kernel+bounces-23025-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 11 Jan 2024 11:25:18 +0800
From: Huang Rui <ray.huang@amd.com>
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Erwan Velu <e.velu@criteo.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] cpufreq/amd-pstate: Adding Zen4 support in
 introduction
Message-ID: <ZZ9fntJX4bTDK46b@amd.com>
References: <20240109175844.448006-1-e.velu@criteo.com>
 <CAJZ5v0ipYQURmFGGwmS5oyOuAOFDbG7TaaaWg4Ze-7PpBnSwkQ@mail.gmail.com>
 <ZZ7RnYy1xINapcSC@amd.com>
 <CAL2Jzuzq-HVnhGZ8W0bSH6xibpYWXdXc30kC1Ub4vESfc4w7xA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAL2Jzuzq-HVnhGZ8W0bSH6xibpYWXdXc30kC1Ub4vESfc4w7xA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDg0YWtWdkVYckdKblEwcWpDd1pkZWpaSnVIUkh1VjRCUXQ5QkJzeGVYUlV6?=
 =?utf-8?B?bG4va2ZvZ3ZlZDluMGRuZFZzZ2JNSythU1c3Z0FlTTdHZnhrbUFXRTNwWkpZ?=
 =?utf-8?B?N1pHRTV0TVBLME15WUE0T25GM21jKytHNUNNc3ZrNStwN3VRRE5DL1MyQ3JM?=
 =?utf-8?B?bnRZQXhJRG5mZXJzZGN2UThyNHBzMERSRitrbVJkUy9vS0pjVjYzNVJpc2xE?=
 =?utf-8?B?UUszbG5JVVV1WlAvc2h2a3c5Ukhmc2MyYjBOdDhTSnJVejhlcWNSeGZSRUpn?=
 =?utf-8?B?ckFzd2FreG8vWldmaEJkL1MrK1hIcHdBOUlrT0l5MlBldmFBRGozZ2hpaS9j?=
 =?utf-8?B?R2VRbnJVMWhpWnpkcWlhVkRkWjhXR2VtRUpwUVZTV0hoaWl2c2ZRME0rVERj?=
 =?utf-8?B?ZmxpK2VIMFUzRTd4VFZ6R3czV3lyTktyWlRWY3l4VitEY0xhWmYzZ3lHN3N5?=
 =?utf-8?B?K3NoM2owQzRVejdqQURzaXNxTG8xZ3hzNE1nd290Mk1rQ1paK1hFdmZ4MUhS?=
 =?utf-8?B?Z1V0ZzBNVUFMa1FyS2FhdVd2YTdSU1dMTTlQUG5JTnpqTnBvRU0ySlplOVU3?=
 =?utf-8?B?S1VHUmJHd21DeUtiMEFpL3grRFNkOFYwNldwcEpjbCtmVzh6MHVCUm1oVUQ5?=
 =?utf-8?B?YVZvdjcwUG9XSElVMUdBNnBIL1NBZVJWQ2tUdndac1o5TFk4R09qRDJoTG1G?=
 =?utf-8?B?THpPSEtwekJYcjUybmhyc1lLTkFkSmQvTzBEVmxRZUNvYWg4ZnY4dGluSWY4?=
 =?utf-8?B?WEtPSzdKR0xKNDMyTDRxZjUwTlRzZ3NlRS95VjErTGh1Y1BpcERKZ2cyZlNL?=
 =?utf-8?B?TTdHZkkzVWN4VlVBbzFYaDJvZ1FIR1ZjalVKK25hRHJ6aTNic1ZsamJ4TndQ?=
 =?utf-8?B?MVROZ3Bma2pFOWwyTU5XazdlZmJKMk5yRUxKSEhRbWZOaFR2aGJlbjNNWVhh?=
 =?utf-8?B?cGxodm9kb1NibTU2UDBHMEtkZXlKK21zcExiZ1d2K2Y5Wm1vVzBUZEdhbjNn?=
 =?utf-8?B?NDkvdTQyRG0wZHBPcU5OajdkMjFGREpLMWNsU0FsYkJUeGM5bUc0YTJqTHJp?=
 =?utf-8?B?aWRRbm4xYk9xd29HVmJlTTUwNlIxUmVxSUo1Q2l2enJnVXZxYXVhNXM5allp?=
 =?utf-8?B?UUdOTWcycG45bzd2c2RJaFZFNDJUb2Z6K0VvTEZ6V09HaUlaNVlpcWdvaDlm?=
 =?utf-8?B?NGpDV1luSjdXV2F1a2FhWEtoNHZYWWV1Q0pNblBLenV0TnBoQTNMQ0pNc0ha?=
 =?utf-8?B?dVRSRWYwSU4vR3Z3M0QzdUZFUE02ckcxaXhnYTZ6RmUvZzBPQWJqWTFiaDB6?=
 =?utf-8?B?L1Z6U0hUaTJuRHN3bTJOMXQrT3JUZkJRWTNWOVlSK1ZCUFUwMzNadEpKbXFh?=
 =?utf-8?B?RERuNTRKOHk3ZE1TYzdaekwrbG1GZzgrWVU5WSt2YXZSbTVUQ3hjY0Fyd3Bs?=
 =?utf-8?B?SEppa09FY0k0SlhVT0hmZVRrbEhReE9ka1VvT2l5MklVdTAzRUhhby9HY1dM?=
 =?utf-8?B?Qm1QbVlUQndTNWRVU1pJN3lOaCtSWGltdVc0MnlONTEwWEliWlBlaHpSQm5y?=
 =?utf-8?B?ek1iT2hSeGV2S29ISXpXc2o2T2xCMU1Nek5OU1hIWUhXVDRvalJoZnkzVVli?=
 =?utf-8?B?L2t3Z1RCSHgyS0VmMzg3bnE5eWN0NW9HMUM4M05UQnp4QzJkSG84RGd1TGV3?=
 =?utf-8?B?K0QrNzNTbXlZTkJOZkFIcWxJanFjV0pkbThPNUhSWUlrWk9nbk5qbjhWQXZx?=
 =?utf-8?B?bWYwZ0lFMEtJNmF6VXBHRVl3MDFaTVlJd2NReEorQUIvU29keGk3RmVabFJU?=
 =?utf-8?B?RWMvcTM5djJ2bjUrUHZ3ZlF5Tjhla2FGcTRmQ01rRXo2Z1VxZlhHQm1SYkZm?=
 =?utf-8?B?WjBvT2ZRUjZpajVTckRVYU9hblVGalFPM3pIN1Mwa0krRkdXSEhiMW03QWpn?=
 =?utf-8?B?c2lRbCswdVQrVEd1L0duSGhSTTRSZ21VQWNrY3BsMnViWC80K2hXeUlnaERs?=
 =?utf-8?B?TW5seFB2SjArUzZId2twWDl2Uk9EL0Z5V3BtYWRoRUJ6VXdaUnVEQkxvM1dX?=
 =?utf-8?B?NHpjV2JnamVhd2RKcXY2TlBGcXh0WmczYVhST1dVNmJWeVkxWTlNWWVKbmk5?=
 =?utf-8?Q?nBUMguAL3bYklLkPSC4/KRCSf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5da8c340-a40a-4fb7-0a1a-08dc1254fa98
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 03:25:37.2989
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cs9uOM3R759l85ABtpCkDzgCTBEr1XnKZYANxdeqMZq2H9b6skfjafp5uMy/k8ukT/U64gzYXqjeVeaxmGU5FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7507

On Thu, Jan 11, 2024 at 01:49:27AM +0800, Erwan Velu wrote:
> > How about modifying here as "partial Zen2, Zen3, and future processors"?
> And all processors starting Zen4 ?

"partial Zen2 and all processors starting Zen3"

Thanks,
Ray

> 
> Le mer. 10 janv. 2024 à 18:19, Huang Rui <ray.huang@amd.com> a écrit :
> >
> > On Wed, Jan 10, 2024 at 10:21:20PM +0800, Rafael J. Wysocki wrote:
> > > On Tue, Jan 9, 2024 at 6:58 PM Erwan Velu <erwanaliasr1@gmail.com> wrote:
> > > >
> > > > amd-pstate is implemented on Zen4, adding this architecture in the
> > > > introduction.
> > > >
> > > > Signed-off-by: Erwan Velu <e.velu@criteo.com>
> > > > ---
> > > >  drivers/cpufreq/amd-pstate.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > > > index 1f6186475715..9a8d083f6ba5 100644
> > > > --- a/drivers/cpufreq/amd-pstate.c
> > > > +++ b/drivers/cpufreq/amd-pstate.c
> > > > @@ -14,7 +14,7 @@
> > > >   * communicate the performance hints to hardware.
> > > >   *
> > > >   * AMD P-State is supported on recent AMD Zen base CPU series include some of
> > > > - * Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tables of AMD
> > > > + * Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACPI tables of AMD
> > >
> > > IMO, it would be really nice to avoid extending this line so much, but
> > > this is up to the AMD people.
> >
> > Agree. Actually, we will use this driver for all future AMD CPU generations
> > that starts from paritial Zen2.
> >
> > >
> > > Also, while you are at it, "include" in the first sentence should be
> > > "including" and a new paragraph after "processors." would make this
> > > comment easier to follow from the logical standpoint, because the
> > > first sentence is about the supported platforms and the second one is
> > > about additional requirements (ie. something else).
> > >
> >
> > How about modifying here as "partial Zen2, Zen3, and future processors"?
> >
> > Thanks,
> > Ray
> >
> > > >   * P-State supported system. And there are two types of hardware implementations
> > > >   * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution.
> > > >   * X86_FEATURE_CPPC CPU feature flag is used to distinguish the different types.
> > > > --