Received-SPF: pass (google.com: domain of linux-kernel+bounces-23034-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f79900b4-f924-48cd-bea5-e65989618f10@linux.dev>
Date: Thu, 11 Jan 2024 11:34:32 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH v3 1/7] hugetlb: code clean for hugetlb_hstate_alloc_pages
Content-Language: en-US
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: linux-mm@kvack.org, Mike Kravetz <mike.kravetz@oracle.com>,
 David Rientjes <rientjes@google.com>, linux-kernel@vger.kernel.org,
 David Hildenbrand <david@redhat.com>, ligang.bdlg@bytedance.com,
 Muchun Song <muchun.song@linux.dev>,
 Andrew Morton <akpm@linux-foundation.org>
References: <20240102131249.76622-1-gang.li@linux.dev>
 <20240102131249.76622-2-gang.li@linux.dev>
 <46769d44703b2f8d2e279d6e95db960c8a87e39c.camel@linux.intel.com>
From: Gang Li <gang.li@linux.dev>
In-Reply-To: <46769d44703b2f8d2e279d6e95db960c8a87e39c.camel@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/1/11 05:55, Tim Chen wrote:
> On Tue, 2024-01-02 at 21:12 +0800, Gang Li wrote:
>> The readability of `hugetlb_hstate_alloc_pages` is poor. By cleaning the
>> code, its readability can be improved, facilitating future modifications.
>>
>> This patch extracts two functions to reduce the complexity of
>> `hugetlb_hstate_alloc_pages` and has no functional changes.
>>
>> - hugetlb_hstate_alloc_pages_node_specific() to handle iterates through
>>    each online node and performs allocation if necessary.
>> - hugetlb_hstate_alloc_pages_report() report error during allocation.
>>    And the value of h->max_huge_pages is updated accordingly.
> 
> Minor nit, I think hugetlb_hstate_alloc_pages_errcheck() is more
> descriptive than hugetlb_hstate_alloc_pages_report().

Thanks! This looks more intuitive.

> 
> Otherwise
> 
> Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
>