Received-SPF: pass (google.com: domain of linux-kernel+bounces-23042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fb688bd2-f669-4407-b7c0-d50da7df7118@linux.dev>
Date: Thu, 11 Jan 2024 11:44:46 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages
Content-Language: en-US
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
 Mike Kravetz <mike.kravetz@oracle.com>, linux-kernel@vger.kernel.org,
 David Rientjes <rientjes@google.com>, David Hildenbrand <david@redhat.com>,
 ligang.bdlg@bytedance.com, Muchun Song <muchun.song@linux.dev>,
 Gang Li <gang.li@linux.dev>
References: <20240102131249.76622-1-gang.li@linux.dev>
 <20240102131249.76622-3-gang.li@linux.dev>
 <9b95c0ac0e5d560f1482af3753df54211a057b9d.camel@linux.intel.com>
From: Gang Li <gang.li@linux.dev>
In-Reply-To: <9b95c0ac0e5d560f1482af3753df54211a057b9d.camel@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/1/11 07:12, Tim Chen wrote:
> On Tue, 2024-01-02 at 21:12 +0800, Gang Li wrote:
>> +static unsigned long __init hugetlb_hstate_alloc_pages_gigantic(struct hstate *h)
>> +{
>> +	unsigned long i;
>> +
>> +	for (i = 0; i < h->max_huge_pages; ++i) {
>> +		/*
>> +		 * gigantic pages not added to list as they are not
>> +		 * added to pools now.
>> +		 */
> 
> This comment unnecessary as now we don't have mix gigantic and non-gigantic code,
> which uses foilio list.  And folio_list is not in this routine.
> 
> Can be removed.
> 
> Otherwise Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
> 

Thanks!