Received-SPF: pass (google.com: domain of linux-kernel+bounces-23074-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "Liu, Yi L" <yi.l.liu@intel.com>,
	"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>, "peterx@redhat.com"
	<peterx@redhat.com>, "jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>,
	"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>
Subject: RE: [PATCH v11 0/8] Add iommufd nesting (part 2/2)
Thread-Topic: [PATCH v11 0/8] Add iommufd nesting (part 2/2)
Thread-Index: AQHaREQfMgcp3Gmjvk6R+p1VFKDDpLDUG6gQ
Date: Thu, 11 Jan 2024 05:51:14 +0000
Message-ID: <BN9PR11MB52769BA4CF43CAB1066437338C682@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240111041015.47920-1-yi.l.liu@intel.com>
In-Reply-To: <20240111041015.47920-1-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4KYfqXRP7h8U57aWrKJ9liyXSpVlEe0aUz57cz5u6nvOOfuVy+8+UOuzUqd2?=
 =?us-ascii?Q?mPNYbDLRixot3D5pumCWhsdJ0lpsD/bFeD5R86bkHmCl64em35Xd8ich6pMf?=
 =?us-ascii?Q?XDY2an6BrzxHvSvb7IO4QrJVJXEw03nFx697GFHIn9tfdZ8LMfcA14lH/iTU?=
 =?us-ascii?Q?kp6A6Coc8FO0gLyQVfpUT5EwmfgTD+ZEi9eI0r4w1t2bABINz4oacKXOXcbZ?=
 =?us-ascii?Q?dLZuVQIZtnc8xUnF1/QbzzU33kEVMguOIo62dzGC3wRnLqg8EYA2dAY2UgIg?=
 =?us-ascii?Q?xDjt5j/PwZ1LuS4VBxu4UAI803iwzMwWPcRgiQLWzwGUpEgzmGPXQSy0ErrQ?=
 =?us-ascii?Q?t9ukv5s8aoS6j4zEUflPblyLCt3fqUCl2FY1Xfej+D7r/e/kLteWdkTIylsF?=
 =?us-ascii?Q?9xGBGOJ9RZRnULDske2G08+cUCXQNIpU00819XwpradDS85T1qJzCk4x2KHq?=
 =?us-ascii?Q?9ZRI2oeShWdqdC1O+zjn2eOMMndxvlWyC489B4oO2eUUjys/2myD32lxl56b?=
 =?us-ascii?Q?GhL9YsEiLbdbD3/okYwLHU+JgrnO2pqFO7mVZ1aUx8BD0wb+6wq/43+Hb13S?=
 =?us-ascii?Q?xEVPY7NquPwFqcUftebm+7cr/r72mULQKFjmWxK9DxZTKoHEkHG24MQziAOl?=
 =?us-ascii?Q?tKlXeFTEZnqO0RhlreXJmoZNOTzGQPwVG7Xrltwc+tc/HlcKUD1UAbU0DAJv?=
 =?us-ascii?Q?aiq6+VvHD32t05jtDxb+1rMTIWe/qLBtYOEpinyvOxH/pG27spWls5uKcLq5?=
 =?us-ascii?Q?YRVWqCH2BZB9WGignWOJlvD0h4Hyn0cosAMijOX86+2mLuZ4HgIoEyzKRJCr?=
 =?us-ascii?Q?oflytMTMt0WevC0bfyT6ayIoZJg4mLkkjxXD2RXc+fxtvXa2NQleX1z9f85K?=
 =?us-ascii?Q?fGGF0xMeIhZz2JF/mgxjDvrft/lCZIQesItx3ITBqXRZOci2UFCrFdM2guGn?=
 =?us-ascii?Q?Se51/mtUO9AOWjJ0Igm9r/2DRNfGmCznm+kv01pTMxhJo4DaOfx0Q+9nzyVb?=
 =?us-ascii?Q?mbEbLUGkp2aJlSWO8OA2r57/TJN7PIcDQiwr4VOMwxahkggLdkPXvejXB+C6?=
 =?us-ascii?Q?9x5zh1nCQj8ePTGWr+KJ89VUryYHvYNkQ453AsR4JHJ8G0lhb95VwByApjt6?=
 =?us-ascii?Q?qQ8M7pJoJgXJtCqx2BMVwQYu41pdWUh5eC8HvmauZruPTLc5kNbxBSTrOKA6?=
 =?us-ascii?Q?EWptfv84fJ1kDfj9YGRdvdpYaJAFBIAGQ3u+260xC63EiZVGLW6qkLV26XAF?=
 =?us-ascii?Q?OF1KYreIujv5uyJXJwrHDII+EbxqwvfvRcR6Cwxa0d6fQykKTuTn8ovQ7rGS?=
 =?us-ascii?Q?k9NILEUAgGEiGHCxI92tz86Kc883NRTBK5yo/dbkF0RUkY1G9MeAftRffYey?=
 =?us-ascii?Q?QIcn7b5QTBZzHc17FAFjgFWmPLGeWZoW7+PWH0GkLcfrcgRPms9BT+M7Uo5d?=
 =?us-ascii?Q?EROkrpqN90dtroUAMGvdAw6o3PtxSiVaK3uocKNjG0nCdOAGqwPAPYZroHc9?=
 =?us-ascii?Q?RmfPsI9juLioTeKqlT5RyjgVOk+PQwz0by6l6m5vfhLo7d/rN+8TOuln9EqS?=
 =?us-ascii?Q?10Zj8ZQlHOmOa4m4tq00ek45QX+xyCw83wtZUZ++?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49f67f2b-ed62-4916-26cb-08dc12695275
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2024 05:51:14.3798
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SxEVMOORZ6dJVIw0PE+3Kh8K0Yyja28lQvgNVElKSseYil7qMWlAKIBGOKmeQftZQlIG/mtyuu/lVC0ehBxNug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5670
X-OriginatorOrg: intel.com

> From: Yi Liu <yi.l.liu@intel.com>
> Sent: Thursday, January 11, 2024 12:10 PM
>=20
> v11:
>  - Drop hw_error field in vtd cache invalidation uapi. devTLB invalidatio=
n
>    error is a serious security emergency requiring the host kernel to han=
dle.
>    No need to expose it to userspace (especially given existing VMs doesn=
't
>    issue devTLB invalidation at all).
>  - The vtd qi_submit_sync() and related callers are reverted back to the
>    original state due to above drop.
>  - Align with the vtd path, drop the hw_error reporting in mock driver an=
d
>    selftest as well since selftest is a demo of the real driver.
>  - Drop iommu_respond_struct_to_user_array() since no more driver want to
>    respond single entry in the user_array.
>  - Two typos from Wubinbin
>=20

this looks good to me. so my r-b still holds.