Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1472360rdd; Wed, 10 Jan 2024 23:21:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IECfbN5PIZHmI2yqWdXQ1SfxIBlp/YhrOBmliMyqWKEezoUNQSeRZs4Kcpa+fXf7gkCXbJl X-Received: by 2002:a05:6a00:3d42:b0:6d9:f593:fbcc with SMTP id lp2-20020a056a003d4200b006d9f593fbccmr727676pfb.44.1704957685693; Wed, 10 Jan 2024 23:21:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704957685; cv=none; d=google.com; s=arc-20160816; b=VJXEhvvxRETp2+TfAcOdiO1phPEiuVj6GAqaMqNYB4Hus/jZdKoCx+ZLeLugQyiUE5 lpKiUyZamTJ82hAvwuLm6f1t2xrj0bl8Q8OFa8IPFccbUVu2OSEh7E3vMUKQIvPgPtUG tHaAXgIlEmYhJ3ETUebpN3zhHhqncx8ggZlwy8SYfgcdY0xZLhZcJGAxH/lX93SKxymo 25RQcVfvjakMLyHWKhlBEIur/kbZOstDv4t8F8RucpwBhrXNZes6/K1eSsYJUzur48ww 1Sm5G55j7KSb0W3BaHyRZSgTfNHpkvC1XySHN5LP6uy4JtxU6ZrrsJ/X9xUuKCvNuyZX bK2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=wQw8+XzmBReOjoLXNdhad/jG/bwh8i2k+fbmUmB717s=; fh=RBJUN28e3bUW3BQOzrokO2BRuv77YS3zXOqoxzq6Bk8=; b=rtYQR/89Hi8VzHgMKqKLGWgaTK1HZRsjAVN3aBMzlEJneAzpU0/k2XHBlWCcpkoltB 0I4HstY7vK6wfVc7US5AqMKl0FcMYrV0CQHvqHWqABYSF3KhQEB0O0p3xvrccSXJiuc6 LfzTT8tjM1+4jkSzIFfJSUEVwlOP3Mb7r6ubvJPfgKEAaVdiqP9oj3a8SjyBc5ahDbBz g2+/9Qr5o6UYRWF+vZjDllwY2hTVOwYwT66aQzjIJpokGeHC4kq/uq12S8YLF3Yqyi6B fd6nrSriBZe4Vj2Hh0MnkMcD0da6hj8HBLXN0ZWpAFBTnwHUbrwcvlyEvTM5fhXuFnn0 4NZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-23144-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23144-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h1-20020a056a00230100b006d9b27c5d49si475436pfh.269.2024.01.10.23.21.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 23:21:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23144-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-23144-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23144-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 39355285268 for ; Thu, 11 Jan 2024 07:21:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 87CF4D2EA; Thu, 11 Jan 2024 07:21:16 +0000 (UTC) Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E49BD26A; Thu, 11 Jan 2024 07:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: b7cd09d420d94f19811b04062ad9c350-20240111 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:c326e1df-2d80-4da9-8998-92b09fd30125,IP:10, URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:-10 X-CID-INFO: VERSION:1.1.35,REQID:c326e1df-2d80-4da9-8998-92b09fd30125,IP:10,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-10 X-CID-META: VersionHash:5d391d7,CLOUDID:546b0c2f-1ab8-4133-9780-81938111c800,B ulkID:240111152103SQJRIDPO,BulkQuantity:0,Recheck:0,SF:19|44|66|38|24|17|1 02,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: b7cd09d420d94f19811b04062ad9c350-20240111 X-User: chentao@kylinos.cn Received: from kernel.. [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1491165561; Thu, 11 Jan 2024 15:21:01 +0800 From: Kunwu Chan To: andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan , Kunwu Chan Subject: [PATCH v2] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe Date: Thu, 11 Jan 2024 15:20:18 +0800 Message-Id: <20240111072018.75971-1-chentao@kylinos.cn> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit devm_kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Cc: Kunwu Chan Signed-off-by: Kunwu Chan Suggested-by: Jakub Kicinski --- v2: Remove error print --- drivers/net/dsa/vitesse-vsc73xx-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c index e6f29e4e508c..571f037fe649 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-core.c +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c @@ -1135,6 +1135,8 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc) vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x", vsc->chipid); + if (!vsc->gc.label) + return -ENOMEM; vsc->gc.ngpio = 4; vsc->gc.owner = THIS_MODULE; vsc->gc.parent = vsc->dev; -- 2.39.2