Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1495429rdd; Thu, 11 Jan 2024 00:23:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFihVbeLj1eqrmg42CYRW9jRwRf2GMQ/hHn60817OzkZQd2a10RXizKJZxEsvazyYOASbb7 X-Received: by 2002:a05:622a:189:b0:429:c6fc:f4c5 with SMTP id s9-20020a05622a018900b00429c6fcf4c5mr259288qtw.0.1704961432999; Thu, 11 Jan 2024 00:23:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704961432; cv=none; d=google.com; s=arc-20160816; b=EqzryoHUKdDyRbzr9neY/TWVeEEESfXLgk2/mOCl7eYiCTjhumpBAxp8mjvlnBDeNv 100P8FthJz55oIJ6rmmdUg17j/9Ot+Kueqk6ZFzAOrrf+Nbd4sC7hhCWfvWzzabU1WSf ydCAZB0TPpj4kCdnZR60ALdPrzJbx7wb0RVQtj7bPTLMmKVw/gdL2QW4uCVpjsAaiu84 B63kYq0dlJm2WTl3E90GqHTFTqajaqOYhIzSopwFo2r8JTUm6oqnEiNSmnaN3BK8uLbK 2/fwzEQJM6J1bdl4l3YvU/5JLjMygPj/LBnBx/VMnVkLVh2wHW6+TslSc1hGGpHNzbKz /I8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=FFrOhLqLHBhQK8g4tGHoyZu2BFidPN3Brloj+ylOX7k=; fh=fOK6zjavol3C3g0eFtJ6K3S2i7s/isUjr3IZmjTaJw0=; b=jhT2PxoOEBHWtNlDzHPpxcybwzXuYVz6OSSc9xDXpvFVbzXZdfTM1pq1kp3t+5bR8H SnWFvMy46TE1+fIOvrwe6ksjbzbZS8Lb8qfrbiaMvyd/NsUuce5IQqC+XkUNpF/37ouH nWlVUQeq7VO+sZ7cqny5EipRJQPFhuFav5U9KyyEAtxMBX2NP1KixS5/qGiCv2bnerGB 8RITQKPrmLpoMsMcgC7C7QLK1iwli/WTf1+8SAKg4pKWh9X063O1/TpFmVCwBhVYAmck k/hgAXFBBiX90/yj4gxo5ooM2m+Ol6r5YzydbdepXC/Ld0p7r5IPzNDgBeBv9Yrd2m4W 2N4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZZGX4L9W; spf=pass (google.com: domain of linux-kernel+bounces-23215-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23215-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o8-20020a05622a138800b0042987b99e71si493272qtk.401.2024.01.11.00.23.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 00:23:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23215-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZZGX4L9W; spf=pass (google.com: domain of linux-kernel+bounces-23215-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23215-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8FBA21C20C1A for ; Thu, 11 Jan 2024 08:23:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E5138F9CC; Thu, 11 Jan 2024 08:23:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZZGX4L9W" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C18FF517 for ; Thu, 11 Jan 2024 08:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704961383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FFrOhLqLHBhQK8g4tGHoyZu2BFidPN3Brloj+ylOX7k=; b=ZZGX4L9WbcmxBjw95dBTUN1mM8zzTMb7jXLOLfHD4MpNcpyltYLwq2q5vjqLkNebfEHEnP Ik9kgVyTB/hDVQA/l8cx8BJt1eeNA7EBLfXzBoTqLWYTUfSEN/BK58HvLLn87V7e/anH3D zRxiIa8ow2DO8QqQDpauMw5hc6Ai628= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-nG-O8M7sMUqQ_6xxLifg3Q-1; Thu, 11 Jan 2024 03:23:01 -0500 X-MC-Unique: nG-O8M7sMUqQ_6xxLifg3Q-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3369382a524so3217007f8f.1 for ; Thu, 11 Jan 2024 00:22:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704961378; x=1705566178; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FFrOhLqLHBhQK8g4tGHoyZu2BFidPN3Brloj+ylOX7k=; b=kGBDS4DyXtocW/TmlE6M47o3SBuBdnoyelYibmVSokMWA3KG7/kh01EQNGmKo+1r7m QwJavZOJmHzBkUHwrSAR5h2nFm1OamQPUbOzz9n/u+LUVw6ahAa3e60Dyq2BSODEOGel rcCX/chSvMSDZLpBOLdVM64MzfwrV1SMme57ZnpnjhKrhQ1bbNnwchZrBze5SlVgDks2 UDczDjU4fhJZAh0aLNckZRGfO7BR8uE+V4eZBKEUKBd80gRLEcDgnrT3ZTh0FZ0yL+NM RwO8Z9X6PeEaI0d1W1oxwgGXftWlFSnb4owLUTPatVODI2HKHeHFwMXAwtPROukaBTjU dEqw== X-Gm-Message-State: AOJu0YwOTg996ON5KC5dAqNyT0mGF1CycPjquIndoWHKH+Ok/9Uwgxbg X/CrpCymK1MyW38ZNFYucrQdPDeXnFvJOEYT0WLQp43/m0eJllrytsAZxBG4sJg70IIGGtABz/L zgWr95xfQaF+G3m7bNsp0kdsyjfLRzyiC31rDchh5 X-Received: by 2002:adf:ffc8:0:b0:337:76ae:34ca with SMTP id x8-20020adfffc8000000b0033776ae34camr400228wrs.77.1704961378408; Thu, 11 Jan 2024 00:22:58 -0800 (PST) X-Received: by 2002:adf:ffc8:0:b0:337:76ae:34ca with SMTP id x8-20020adfffc8000000b0033776ae34camr400222wrs.77.1704961377953; Thu, 11 Jan 2024 00:22:57 -0800 (PST) Received: from ?IPV6:2003:cb:c747:f900:6099:1901:b863:450f? (p200300cbc747f90060991901b863450f.dip0.t-ipconnect.de. [2003:cb:c747:f900:6099:1901:b863:450f]) by smtp.gmail.com with ESMTPSA id q2-20020a056000136200b003373fe3d345sm555704wrz.65.2024.01.11.00.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 00:22:57 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 09:22:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] driver/virtio: Add Memory Balloon Support for SEV/SEV-ES To: Zheyun Shen , Jason Wang , mst Cc: linux-kernel , virtualization , xuanzhuo References: <1824181559.1228150.1704954908335.JavaMail.zimbra@sjtu.edu.cn> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1824181559.1228150.1704954908335.JavaMail.zimbra@sjtu.edu.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >>> For now, SEV pins guest's memory to avoid swapping or >>> moving ciphertext, but leading to the inhibition of >>> Memory Ballooning. >>> >>> In Memory Ballooning, only guest's free pages will be relocated >>> in balloon inflation and deflation, so the difference of plaintext >>> doesn't matter to guest. > >> This seems only true if the page is zeroed, is this true here? > > Sorry, I cannot figure out why the pages should be zeroed. I think > both host kernel and guest kernel assume that the pages are not > zeroed and will use kzalloc or manually zero them in real applications, > which is same as non-SEV environments. balloon_page_alloc() will not zero the memory (no __GFP_ZERO set). Only in some configurations (zero-on-alloc, zero-on-free), the kernel would do that implicitly. So we'd eventually be leaking secrets to the untrusted hypervisor? > I have tested in SEV-ES, reclaiming memory by balloon inflation and reuse > them after balloon deflation both works well with the patch. Hypervisor > can normally give the reclaimed memory from one CVM to another, or give > back to the origin CVM. I'll comment on your misconception of memory overcommit separately. -- Cheers, David / dhildenb