Received-SPF: pass (google.com: domain of linux-kernel+bounces-23247-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240110131707.437301-1-keisuke.nishimura@inria.fr>
 <CAKfTPtCgqkUUtWMknyHrNeb994V_L4T9bxV9A=bUXCQu-+S1SQ@mail.gmail.com> <8d9e076c-8505-4538-83f5-506ccf62f7a9@inria.fr>
In-Reply-To: <8d9e076c-8505-4538-83f5-506ccf62f7a9@inria.fr>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Thu, 11 Jan 2024 09:52:53 +0100
Message-ID: <CAKfTPtDN0X3eern3DDj9JVh10YJ=YX9OHW0HYJscoi+P-4_v4w@mail.gmail.com>
Subject: Re: [PATCH v2 1/2 RESEND] sched/fair: take into account scheduling
 domain in select_idle_smt()
To: Keisuke Nishimura <keisuke.nishimura@inria.fr>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org, 
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Mel Gorman <mgorman@suse.de>, 
	Valentin Schneider <vschneid@redhat.com>, Julia Lawall <julia.lawall@inria.fr>, 
	Xunlei Pang <xlpang@linux.alibaba.com>, Abel Wu <wuyun.abel@bytedance.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 10 Jan 2024 at 18:57, Keisuke Nishimura
<keisuke.nishimura@inria.fr> wrote:
>
> >>
> >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> >> index 533547e3c90a..66457d4b8965 100644
> >> --- a/kernel/sched/fair.c
> >> +++ b/kernel/sched/fair.c
> >> @@ -7311,13 +7311,19 @@ static int select_idle_core(struct task_struct *p, int core, struct cpumask *cpu
> >>   /*
> >>    * Scan the local SMT mask for idle CPUs.
> >>    */
> >> -static int select_idle_smt(struct task_struct *p, int target)
> >> +static int select_idle_smt(struct task_struct *p, struct sched_domain *sd, int target)
> >>   {
> >>          int cpu;
> >>
> >>          for_each_cpu_and(cpu, cpu_smt_mask(target), p->cpus_ptr) {
> >>                  if (cpu == target)
> >>                          continue;
> >> +               /*
> >> +                * Check if the CPU is in the LLC scheduling domain of @target.
> >> +                * Due to isolcpus, there is no guarantee that all the siblings are in the domain.
> >> +                */
> >> +               if (!cpumask_test_cpu(cpu, sched_domain_span(sd)))
> >
> > commit df3cb4ea1fb6 ("sched/fair: Fix wrong cpu selecting from isolated domain")
> > also checked if (!cpumask_test_cpu(cpu, p->cpus_ptr) ||
> >
> > Why didn't you also re-add this test ?
> >
> >
>
> Thank you for your comment. This is because the iterator "for_each_cpu_and(cpu,
> cpu_smt_mask(target), p->cpus_ptr)" ensures that cpu is included in p->cpus_ptr.

Ah yes indeed. I didn't notice that it was now included in the for_each_cpu_and

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>


>
> The iterator has changed. FYI, here is the change made in commit df3cb4ea1fb6:
>
>          for_each_cpu(cpu, cpu_smt_mask(target)) {
> -               if (!cpumask_test_cpu(cpu, p->cpus_ptr))
> +               if (!cpumask_test_cpu(cpu, p->cpus_ptr) ||
> +                   !cpumask_test_cpu(cpu, sched_domain_span(sd)))
>                          continue;
>                  if (available_idle_cpu(cpu) || sched_idle_cpu(cpu))
>
> best,
> Keisuke
>