Received-SPF: pass (google.com: domain of linux-kernel+bounces-23279-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Conor Dooley <conor@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Lucas Stach <l.stach@pengutronix.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: interrupt-controller: fsl, irqsteer: Add power-domains
Date: Thu, 11 Jan 2024 09:59:54 +0100
Message-ID: <9230083.CDJkKcVGEf@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20240110-ignore-womanhood-a7ee7caa71f1@spud>
References: <20240110094338.472304-1-alexander.stein@ew.tq-group.com> <20240110-ignore-womanhood-a7ee7caa71f1@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hi Conor,

Am Mittwoch, 10. Januar 2024, 17:09:07 CET schrieb Conor Dooley:
> On Wed, Jan 10, 2024 at 10:43:38AM +0100, Alexander Stein wrote:
> > Some SoC like i.MX8QXP use a power-domain for this IP add it to the
> > supported proerties. Fixes the dtbs_check warning:
> > freescale/imx8qxp-tqma8xqp-mba8xx.dtb: irqsteer@56000000: 'power-domain=
s'
> >=20
> >  does not match any of the regexes: 'pinctrl-[0-9]+'
> >=20
> > from schema $id:
> > http://devicetree.org/schemas/interrupt-controller/fsl,irqsteer.yaml#
> >=20
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >=20
> > Notes:
> >     Please note that both the board dts and the DT node for irqsteer be=
ing
> >     used, are still work-in-progress.
>=20
> The binding doesn't even support the imx8qxp's irqsteer yet, I think
> this should be added alongside support for that SoC. Am I missing
> something?

I'm not sure if any additional SoC support is actually needed. 'fsl,imx-
irqsteer' is available and that's what I use in my WiP. Also imx8mp also ju=
st=20
uses the generic compatible. Only imx8mq uses 'fsl,imx8m-irqsteer'.
AFAICS the bindings support the different amount of IRQs already.

Best regards,
Alexander

>=20
> >  .../devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >=20
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.y=
am
> > l
> > b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.y=
am
> > l index 20ad4ad82ad64..cb4fcd23627f6 100644
> > ---
> > a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.y=
am
> > l +++
> > b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.y=
am
> > l>=20
> > @@ -42,6 +42,9 @@ properties:
> >    clock-names:
> >      const: ipg
> >=20
> > +  power-domains:
> > +    maxItems: 1
> > +
> >=20
> >    interrupt-controller: true
> >   =20
> >    "#interrupt-cells":


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/