Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1530176rdd; Thu, 11 Jan 2024 01:48:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQ1KZyLBKMggqnEMKTAhvOSCa2+BriHJjUEJl/GBU4/NqPWWaARtVQgVogcwIM2aKss38i X-Received: by 2002:a17:906:dacd:b0:a27:e2b2:783d with SMTP id xi13-20020a170906dacd00b00a27e2b2783dmr477750ejb.116.1704966508302; Thu, 11 Jan 2024 01:48:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704966508; cv=none; d=google.com; s=arc-20160816; b=PStb2vc37sExUrHYxONwbBUcOboYc7uUXnGlauzLJxr+TUcAfnUJ+aFfGngAt1vcPm WMGag3ufdSBdGfvr/SsulBVzu3WmpnhcQGAh5opRLYmKWwVqX6SFV/ps65YRbCMpFr0t zdssonkn6gxlQHtiM2spCIbHIpHK6qfYIxaKCTUCr9xTVnBDvv04NHK3Xtv5XSlpsLd/ 7/OkHxnlVGVLV85y+iwrlxWWlDoiGkGj9qWS1rXIsaSzYMJ8lNrgc/SInb3qVCT07f6D mFYBvK3bUtAN9/L+J2zwSqHIn6HHPqcNi9/tpwtXBKcKRpwlw7Gkg281qSEMpXa1wUGK MZcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=5adUtgne4jMaQu6ceUWNoNLxWhqRojcfBCn+PSBQ4qk=; fh=Kj8VHwtO20zPm6tbqcfhRUeHvXD9k8SgMrXQf/TnRAY=; b=ytNlpgUnP5R1R3dFH5Lo+hYqCRDeRBW7Sw3bNvsltfLUzC7iRhhC55hk6ZDQD/6NYH TAhBNAZKvFBP7kJ0uz0Y5u1+cSq500lmTVzqnNlUtf0WZ/85n4ouhqfh99Gf2SvPGxH3 /XUBtaN1Z7IrRrIN04ISp7kQ+oYQ8/Sq/o08smTdiljAMKoyysN9oBoqx/TYnbzPpy3M wEGi66CV67xgrfJ7DQVDnGn1gmSYlgRfKDr2E/rks+vYIvdaeVhDSkDZsqhwJVGaBGPW ZWItfOFwIQj3rugtKkEdIxRnoRswlFWUNnV2xdU26KiTKF5kn7S4CsrRYK3lao4Yd/Vz ggzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GhC7MZlT; spf=pass (google.com: domain of linux-kernel+bounces-23333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23333-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id b9-20020a170906708900b00a26e48fd0dbsi343875ejk.577.2024.01.11.01.48.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 01:48:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GhC7MZlT; spf=pass (google.com: domain of linux-kernel+bounces-23333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23333-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DDDD61F227AA for ; Thu, 11 Jan 2024 09:48:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C3770125B5; Thu, 11 Jan 2024 09:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GhC7MZlT" Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E443711733 for ; Thu, 11 Jan 2024 09:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3368abe1093so4076018f8f.2 for ; Thu, 11 Jan 2024 01:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704966491; x=1705571291; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5adUtgne4jMaQu6ceUWNoNLxWhqRojcfBCn+PSBQ4qk=; b=GhC7MZlTj9fogoNQw/Hwv/RsrUBD5L7p6t1v0JyI7Tt9IuMPQE8Mk8DbPGBc7y7+6t e3nGNNQsWz9+7tdHfinoVUbSm48p+eFKY4AjXntYBpPFXkCUMNd4aFhocXW2fQW05Uq9 qLIhg3LheJR/MHIR8fe/P0Mupp070GNcHDOnBy1vKAUK4rLRsqcS8Mp2NY6kMBSaHDpt DzvMUY1UztkcXvTCaHiwsZfhOjZWSqJ3xtyxs3sL2px57rvY7TJ1U5HP+wkeT0g0C8iK JZPVKO41l62k2py+eh5gh5mGVAjVUTfRIY3K4NieNDricYY0Z5sVcjFxoPOZQLTPMxIU jrnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704966491; x=1705571291; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5adUtgne4jMaQu6ceUWNoNLxWhqRojcfBCn+PSBQ4qk=; b=HgL23Ud2v99noWONALJJ2Z1JobGhaMag5VD/QsGVoWu5GxrGLeWcCCTCYTl4bDHgX4 ZM3zJxyNWhW08blJAkk2sB3mzTFU56SJAr7Sprj2jjVhgsOxaBWncdV3FBwxScdUOJN1 59qeRZtABBYwG1BJ1oD68c6UclEmS5eo3YvCl8rRt3zrPa8aOV3tgXPyLgE5ygdYet2k ppcbkrXgXenEbqpa5RHEVOIE097XoBV7eZOBz8OUd/TNNt5olgM3c/jp9QzRwLVWvVBU t7oJ24TUZoVhdAV6UxnvMW58lklrl4r9mE6uU2Bkwy5YiKMA/FZynRhF+orqmTA1icHL U4pA== X-Gm-Message-State: AOJu0Ywi+YnxRfKMGpi/Qw6ET4d0n/u+tF01dKw8GOVF5tINIbnyAbnt 8WOu0K3/0f8Xh6LadkYAsPEnA+um1g2Dyg== X-Received: by 2002:a5d:558e:0:b0:337:5d86:af03 with SMTP id i14-20020a5d558e000000b003375d86af03mr391634wrv.114.1704966491096; Thu, 11 Jan 2024 01:48:11 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id q5-20020adf9dc5000000b003376dbc75e9sm753018wre.14.2024.01.11.01.48.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 01:48:08 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 10:48:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] reset: Instantiate reset GPIO controller for shared reset-gpios Content-Language: en-US To: Philipp Zabel , Srinivas Kandagatla , Banajit Goswami , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartosz Golaszewski , Sean Anderson References: <20240105155918.279657-1-krzysztof.kozlowski@linaro.org> <20240105155918.279657-3-krzysztof.kozlowski@linaro.org> <767645a7-835d-4ac8-ac70-a701cea6df30@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/01/2024 12:58, Philipp Zabel wrote: >>>> + /* Not freed in normal path, persisent subsyst data */ >>>> + rgpio_dev = kzalloc(sizeof(*rgpio_dev), GFP_KERNEL); >>> >>> Since this is persistent, instead of letting the reset-gpio driver call >>> of_parse_phandle_with_args() again, this could be passed in via >>> platform data. Is there a reason not to do that instead? >> >> We can pass it as read only platform data, but we cannot pass the >> ownership. This is associated with registered platform device, not with >> bound one device->driver. >> >> Imagine case: >> 1. modprobe reset-gpio, >> 2. Driver is bound to the device, >> 3. unbind (echo > unbind) >> 4. rmmod >> 5. goto 1 > > Keeping ownership on the list is fine, the reset-gpio driver makes its > own copy of of_phandle_args anyway. I was just wondering whether it > could make this copy from platform data instead of from the > of_parse_phandle_with_args() return value. Looks like it could. This could save us few lines of code in reset-gpio.c. I'll try it. > > [...] >>> >>>> @@ -839,21 +960,50 @@ __of_reset_control_get(struct device_node *node, const char *id, int index, >>>> index, &args); >>>> if (ret == -EINVAL) >>>> return ERR_PTR(ret); >>>> - if (ret) >>>> - return optional ? NULL : ERR_PTR(ret); >>>> + if (ret) { >>>> + /* >>>> + * There can be only one reset-gpio for regular devices, so >>>> + * don't bother with GPIO index. >>>> + */ >>> >>> I don't understand this comment. The GPIO index should be checked as >>> part of __reset_gpios_args_match(), or should it not? >> >> This and earlier comment are result of a bit hacky approach to the >> problem: how to find reset controllers for that GPIO? >> >> The point is that our reset gpio controller has only 1 reset, thus >> of_reset_n_cells=1. However args_count from of_parse_handle is >0, which >> later is compared in reset core: >> >> https://elixir.bootlin.com/linux/latest/source/drivers/reset/core.c#L859 >> >> That part we need to match. >> >> I could make the reset-gpio driver to have of_reset_n_cells=2, but what >> would be the point? The rest of the cells are not really relevant, >> because you cannot refer to this reset gpio controller with any other >> arguments. >> >> To remind: my solution spawns one reset-gpio controller for one GPIO. > > Thank you. I think we could also just make that check > > if (WARN_ON(!rcdev->of_args && ...)) > > instead and skip the of_xlate call in that case (or implement of_xlate > in the reset-gpio driver to make this more explicit). Ack > >>> >>>> + ret = of_parse_phandle_with_args(node, "reset-gpios", "#gpio-cells", >>>> + 0, &args); >>>> + if (ret) >>>> + return optional ? NULL : ERR_PTR(ret); >>>> >>>> - mutex_lock(&reset_list_mutex); >>>> - rcdev = NULL; >>>> - list_for_each_entry(r, &reset_controller_list, list) { >>>> - if (args.np == r->of_node) { >>>> - rcdev = r; >>>> - break; >>>> - } >>>> + gpio_fallback = true; >>> >>> Is there a reason not just call __reset_add_reset_gpio_device() here? >>> With that, there should be no need to call __reset_find_rcdev() twice. >> >> Hm, could be, although not sure if code would be simpler. >> >> This entire function handles two cases: >> 1. Get normal reset controller ("resets" OF property), >> 2. If above fails, get reset-gpio controller ("reset-gpios" OF property) >> >> Therefore the entire solution is following approach: >> 1. of_parse_phandle(resets) >> 1b. error? Then of_parse_phandle(reset-gpios) >> 2. Find reset-controller based on any of above phandles. >> 3. error? Check if we created reset-gpios platform device. If not: >> create new reset-gpios platform device/ >> 3b. Platform device could probe, so lookup again for reset controller or >> defer probe. >> >> What type of flow do you propose? > > I propose to reorder after parsing the phandles: check/create the gpio > platform device right after parsing the gpio handle. Only then lock > reset_list_mutex look for the rcdev. > > 1. of_parse_phandle(resets) > 1b. error? Then of_parse_phandle(reset-gpios) > 2b. gpio? Then check if we created reset-gpios platform device. If not: > create new reset-gpios platform device/, defer if probe failed > 3. Lock reset_list_mutex, find reset-controller based on any of above > phandles. Could work, let me try. I have impression this was my first approach which resulted in a bit more complicated code, but I don't remember the details now. > >> >>> >>>> } >>>> >>>> + mutex_lock(&reset_list_mutex); >>>> + rcdev = __reset_find_rcdev(&args, gpio_fallback, NULL); >>> >>> This gets called with args as parsed. If there is a match, this will >>> overwrite args (in the gpio_fallback case) and return NULL. >> >> Overwrite not complete. It will only overwrite args_count and return a >> valid rcdev. >> I do not see overwriting in case of returning NULL. > > Sorry, I meant to write > > "This gets called with args as parsed. If there is a match, this will > overwrite args (in the gpio_fallback case) _or_ return NULL." > > at least at the end, when I understood the following. > >>> >>>> + >>>> if (!rcdev) { > > So in this non-NULL branch there was no overwriting. > >>>> - rstc = ERR_PTR(-EPROBE_DEFER); >>>> - goto out; >>>> + if (gpio_fallback) { >>>> + /* >>>> + * Registering reset-gpio device might cause immediate >>>> + * bind, thus taking reset_list_mutex lock via >>>> + * reset_controller_register(). >>>> + */ >>>> + mutex_unlock(&reset_list_mutex); >>>> + ret = __reset_add_reset_gpio_device(node, &args); >>> >>> So this will also be called with args as parsed. >>> >>>> + mutex_lock(&reset_list_mutex); >>>> + if (ret) { >>>> + rstc = ERR_PTR(ret); >>>> + goto out; >>>> + } >>>> + /* >>>> + * Success: reset-gpio could probe immediately, so >>>> + * re-check the lookup. >>>> + */ >>>> + rcdev = __reset_find_rcdev(&args, gpio_fallback, NULL); >>> >>> And this will again be called with args as parsed and overwrite args >>> again.> >>>> + if (!rcdev) { >>>> + rstc = ERR_PTR(-EPROBE_DEFER); >>>> + goto out; >>>> + } >>>> + /* Success, rcdev is valid thus do not bail out */ >>>> + } else { >>>> + rstc = ERR_PTR(-EPROBE_DEFER); >>>> + goto out; >>>> + } >>>> } >>> >>> So at this point args is overwritten in the gpio_fallback case. I would >>> find it much clearer to just overwrite args here and make the first >>> parameter to __reset_find_rcdev() const. >> >> I think I get your point. Overwriting happens after we store the >> original of_args, but the code is indeed not intuitive. I think I can >> move it further, as you suggested. > > Now I think we can skip the overwriting altogether and just adapt the > following of_reset_n_cells check ad of_xlate call as mentioned above. Yep! Best regards, Krzysztof