Received-SPF: pass (google.com: domain of linux-kernel+bounces-23336-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Jani Nikula <jani.nikula@linux.intel.com>
To: GuoHua Chen <chenguohua_716@163.com>, tzimmermann@suse.de,
 airlied@gmail.com, maarten.lankhorst@linux.intel.com, daniel@ffwll.ch,
 mripard@kernel.org, patrik.r.jakobsson@gmail.com
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, GuoHua
 Chen <chenguohua_716@163.com>
Subject: Re: [PATCH] gma500: Clean up errors in psb_intel_sdvo_regs.h
In-Reply-To: <20240111070720.9602-1-chenguohua_716@163.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20240111070720.9602-1-chenguohua_716@163.com>
Date: Thu, 11 Jan 2024 11:49:48 +0200
Message-ID: <87edeourlv.fsf@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Thu, 11 Jan 2024, GuoHua Chen <chenguohua_716@163.com> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that close brace '}'
>
> Signed-off-by: GuoHua Chen <chenguohua_716@163.com>
> ---
>  drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h b/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> index 600e79744d68..e358a6b1bcce 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> @@ -666,7 +666,7 @@ struct psb_intel_sdvo_enhancement_limits_reply {
>  #define SDVO_CMD_SET_TV_LUMA_FILTER			0x79
>  struct psb_intel_sdvo_enhancements_arg {
>      u16 value;
> -}__attribute__((packed));
> +} __attribute__((packed));

__packed is preferred over __attribute__((packed)) anyway...

BR,
Jani.


>  
>  #define SDVO_CMD_GET_DOT_CRAWL				0x70
>  #define SDVO_CMD_SET_DOT_CRAWL				0x71

-- 
Jani Nikula, Intel