Received-SPF: pass (google.com: domain of linux-kernel+bounces-23348-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 11 Jan 2024 11:59:25 +0200
From: Leon Romanovsky <leon@kernel.org>
To: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
Cc: Greg Sword <gregsword0@gmail.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>
Subject: Re: [PATCH for-next v4 2/2] RDMA/rxe: Remove rxe_info from
 rxe_set_mtu
Message-ID: <20240111095925.GB7488@unreal>
References: <20240109083253.3629967-1-lizhijian@fujitsu.com>
 <20240109083253.3629967-2-lizhijian@fujitsu.com>
 <CAEz=LcvphS6QECpHTFhrRoC=FcSbEU4j_XuqJF7ognjJu+uF6Q@mail.gmail.com>
 <dbbd1887-af93-4323-ac27-f937bafc5756@fujitsu.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <dbbd1887-af93-4323-ac27-f937bafc5756@fujitsu.com>

On Wed, Jan 10, 2024 at 01:22:12AM +0000, Zhijian Li (Fujitsu) wrote:
> 
> 
> On 09/01/2024 17:20, Greg Sword wrote:
> > On Tue, Jan 9, 2024 at 4:41 PM Li Zhijian <lizhijian@fujitsu.com> wrote:
> >>
> >> commit 9ac01f434a1e ("RDMA/rxe: Extend dbg log messages to err and info")
> >> newly added this info. But it did only show null device when
> >> the rdma_rxe is being loaded because dev_name(rxe->ib_dev->dev)
> >> has not yet been assigned at the moment:
> >>
> >> "(null): rxe_set_mtu: Set mtu to 1024"
> >>
> >> Remove it to silent this message, check the mtu from it backend link
> >> instead if needed.
> >>
> >> CC: Bob Pearson <rpearsonhpe@gmail.com>
> >> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> >> ---
> >> V4: Remove it rather than re-order rxe_set_mtu() and rxe_register_device()
> >> ---
> >>   drivers/infiniband/sw/rxe/rxe.c | 2 --
> >>   1 file changed, 2 deletions(-)
> >>
> >> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
> >> index a086d588e159..ae466e72fc43 100644
> >> --- a/drivers/infiniband/sw/rxe/rxe.c
> >> +++ b/drivers/infiniband/sw/rxe/rxe.c
> >> @@ -160,8 +160,6 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu)
> >>
> >>          port->attr.active_mtu = mtu;
> >>          port->mtu_cap = ib_mtu_enum_to_int(mtu);
> >> -
> >> -       rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap);
> > 
> > I'd like to keep this statement so I can tell if the mtu setup was
> > successful or not.
> 
> During the module loading, once it's loaded successfully, the mtu is set as well.
> 
> The another caller rxe_notify()->rxe_set_mtu() already had its own dbg message for this,
> people can enable the dbg if needed.
> 
> Anyway, I'm open to your point.

IMHO, this print can be safely removed.

Thanks

> 
> 
> Thanks
> Zhijian
> 
> 
> > 
> >>   }
> >>
> >>   /* called by ifc layer to create new rxe device.
> >> --
> >> 2.29.2
> >>
> >>