Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1534339rdd; Thu, 11 Jan 2024 01:59:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IESwEO1DqAJg3/EfwUF8lQ2PHJrX+4o4EniO+Yk6GMSDVwEkmlD66SZYPwRvuPbc76+66Pn X-Received: by 2002:a05:622a:1388:b0:429:b149:d260 with SMTP id o8-20020a05622a138800b00429b149d260mr403274qtk.114.1704967193791; Thu, 11 Jan 2024 01:59:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704967193; cv=none; d=google.com; s=arc-20160816; b=g/C44Iegb6wOIRLfodreUYNAV3DlvB3HWT5LziQA3eod0eLRRw02ayD24Cc5+zOL/I +d0+ukEwTk/mieG3a/ejYnE6uPJFPXkcvD2lFPdNYroHONXj3D5NfFtIywWKDHjYqSAI Wbil7zV0FjLsKPYkYwxy5TnGY2ne8NBemIHvc35AepUv8jsWjqLmz4eauwoNDBXEZrl7 1h4iRK79ePOm4Wc9K0MKiI+cURrtVQckod2VkgnRGXbzmDAZRmCj8PSPX248HjfbbCU+ oglo8ip7qxMZdsNf2y+mVjlhvVn9FZLIlrLmTXs/AD/q+XHfuOckWHRoS4TwZ7NfmKW2 cTXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:organization:in-reply-to:subject:cc:to :from:dkim-signature; bh=lycyh94u4Q01kF3xnHBwWtmra1fCOPMishglRD4mtE0=; fh=9XoiD6WH3FIhLqT3zIuwigE4cgfYYKa8l65xKG81GwQ=; b=NGkX/2vBGXPYxzPZgmuFGcTkLSLqbqtZFF8V8ZsxIGePBZaMGvQMvIVV5fVWngvSRl MAehieHkw63SstFywGa/IleaLXsaOFV0IzUBc99SIYX/6vdlKwlCjim0x1BaTosZWwrO wrIutUgBZVbBptozUo2aLSPX4R3sBeiThP/HrzKKBJlJU6SBRnBbZbVbSxWhF1Fvm2XY z4Is0Haz1W82uCX/agCsnYzmkcXHE9KSoQ52gM5xf91Tz0lC5hIxKkovvwiomMT+9HJJ ycG1L08RYprpVBy4PMvvVF095aJj6QnNK1+DSH476iTK/2zGs5T9G+MHl3PbuPSbTLrM 8pdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XYDiGKcn; spf=pass (google.com: domain of linux-kernel+bounces-23349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23349-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d9-20020a05622a100900b00429763179a4si601148qte.571.2024.01.11.01.59.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 01:59:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XYDiGKcn; spf=pass (google.com: domain of linux-kernel+bounces-23349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23349-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 79DF61C22DBA for ; Thu, 11 Jan 2024 09:59:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C04C712B65; Thu, 11 Jan 2024 09:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XYDiGKcn" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE2F212E6B for ; Thu, 11 Jan 2024 09:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704967177; x=1736503177; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=wWtjtpvLpCpNq6v6WPPTrwuiaHZ9+Yn/ZZKrzAQXEDo=; b=XYDiGKcnNutdLGi4OZPb2N/dnzrmfFYD570fsPl3jzDXnlGPCWwHkt42 7ROI9med6L8rJL5hfYeMs/1N50k0KimkmfAXjXpagYKcXfWkLDceRmP6a sBamzBB+4sLCFxb7hVbgk8GlgotWYjXHCsqPBe6CaabpjExQy5eR2/XRs 862/qyqpq1PzrgBNX+FXxRJ6T4pyqMxko9pvQQuQkNj0NqaQE4UIK+2rB 4JLFL6KHCLeKiAFJuyajq9HoOHVDxlTT6/FsFR+GoIkZA8tMWyYEC0AmL Ju8FRrL2PjOBUZXaspzH07+rjSenr0hXcsFFut6PyNYcXbtKbmrc9LfeG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="5530914" X-IronPort-AV: E=Sophos;i="6.04,185,1695711600"; d="scan'208";a="5530914" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2024 01:59:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="782568762" X-IronPort-AV: E=Sophos;i="6.04,185,1695711600"; d="scan'208";a="782568762" Received: from gaertgee-mobl.ger.corp.intel.com (HELO localhost) ([10.252.54.206]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2024 01:59:24 -0800 From: Jani Nikula To: chenxuebing , airlied@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, daniel@ffwll.ch, tzimmermann@suse.de Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, chenxuebing Subject: Re: [PATCH] drm: Clean up errors in drm_dp_mst_topology.h In-Reply-To: <20240111064245.8789-1-chenxb_99091@126.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240111064245.8789-1-chenxb_99091@126.com> Date: Thu, 11 Jan 2024 11:59:21 +0200 Message-ID: <875y00ur5y.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, 11 Jan 2024, chenxuebing wrote: > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before open square bracket '[' Same here, checkpatch just isn't clever enough to realize it's within a macro. BR, Jani. > > Signed-off-by: chenxuebing > --- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c > index bd6c24d4213c..a4a24ec11b80 100644 > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c > @@ -100,7 +100,7 @@ static bool drm_dp_mst_port_downstream_of_branch(struct drm_dp_mst_port *port, > > #define DBG_PREFIX "[dp_mst]" > > -#define DP_STR(x) [DP_ ## x] = #x > +#define DP_STR(x)[DP_ ## x] = #x > > static const char *drm_dp_mst_req_type_str(u8 req_type) > { > @@ -131,7 +131,7 @@ static const char *drm_dp_mst_req_type_str(u8 req_type) > } > > #undef DP_STR > -#define DP_STR(x) [DP_NAK_ ## x] = #x > +#define DP_STR(x)[DP_NAK_ ## x] = #x > > static const char *drm_dp_mst_nak_reason_str(u8 nak_reason) > { > @@ -156,7 +156,7 @@ static const char *drm_dp_mst_nak_reason_str(u8 nak_reason) > } > > #undef DP_STR > -#define DP_STR(x) [DRM_DP_SIDEBAND_TX_ ## x] = #x > +#define DP_STR(x)[DRM_DP_SIDEBAND_TX_ ## x] = #x > > static const char *drm_dp_mst_sideband_tx_state_str(int state) > { -- Jani Nikula, Intel