Received-SPF: pass (google.com: domain of linux-kernel+bounces-23392-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 11 Jan 2024 10:41:09 +0000
From: Lee Jones <lee@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Pavel Machek <pavel@ucw.cz>, LKML <linux-kernel@vger.kernel.org>,
	cocci@inria.fr
Subject: Re: [PATCH] leds: trigger: oneshot: One function call less in
 pattern_init() after error detection
Message-ID: <20240111104109.GB1665043@google.com>
References: <c73761c5-7150-4f20-9b3e-1da680400250@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c73761c5-7150-4f20-9b3e-1da680400250@web.de>

On Tue, 26 Dec 2023, Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 26 Dec 2023 22:02:08 +0100
> 
> The kfree() function was called in one case by
> the pattern_init() function during error handling
> even if the passed variable contained a null pointer.

It's totally valid to call kfree() on a NULL pointer:

  * If @object is NULL, no operation is performed.

Why do we care all that much?

> This issue was detected by using the Coccinelle software.
> 
> Thus use another label.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/leds/trigger/ledtrig-oneshot.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/trigger/ledtrig-oneshot.c b/drivers/leds/trigger/ledtrig-oneshot.c
> index bee3bd452abf..31061ec0afe6 100644
> --- a/drivers/leds/trigger/ledtrig-oneshot.c
> +++ b/drivers/leds/trigger/ledtrig-oneshot.c
> @@ -134,7 +134,7 @@ static void pattern_init(struct led_classdev *led_cdev)
> 
>  	pattern = led_get_default_pattern(led_cdev, &size);
>  	if (!pattern)
> -		goto out_default;
> +		goto out_settings;
> 
>  	if (size != 2) {
>  		dev_warn(led_cdev->dev,
> @@ -151,6 +151,7 @@ static void pattern_init(struct led_classdev *led_cdev)
> 
>  out_default:
>  	kfree(pattern);
> +out_settings:
>  	led_cdev->blink_delay_on = DEFAULT_DELAY;
>  	led_cdev->blink_delay_off = DEFAULT_DELAY;
>  }
> --
> 2.43.0
> 

-- 
Lee Jones [李琼斯]