Received-SPF: pass (google.com: domain of linux-kernel+bounces-23409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Peng Fan <peng.fan@nxp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: "rafael@kernel.org" <rafael@kernel.org>, "daniel.lezcano@linaro.org"
	<daniel.lezcano@linaro.org>, "rui.zhang@intel.com" <rui.zhang@intel.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] thermal/drivers/qoriq: fix getting tmu range
Thread-Topic: [PATCH] thermal/drivers/qoriq: fix getting tmu range
Thread-Index: AQHaAyyxm4iPh0Sv7U243t/NmfenWrDU4peAgAANj2A=
Date: Thu, 11 Jan 2024 10:47:12 +0000
Message-ID:
 <DU0PR04MB9417DEC3852F9D6036B858D188682@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20231020081337.3141488-1-peng.fan@oss.nxp.com>
 <ZZ-7V2bGL3c1RuZw@pengutronix.de>
In-Reply-To: <ZZ-7V2bGL3c1RuZw@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?HR3EthmquQguiocOSfcbnq82sU1e7jxSsJ7kiRB0CxLSke/tH+F2SRSQ3Len?=
 =?us-ascii?Q?+6Id5Gvp8iYPmKzNvdo/y7A3ljdAWwUf0CTtYCjQeJ2lqsisuBs+oregCYvJ?=
 =?us-ascii?Q?0eSf4K1QOz3LCxFefg8722FKk0USIyr9DZ7HZ4X9AwKK8ZZ3aV/jN3HC6Ylu?=
 =?us-ascii?Q?OxQTzIO584Lo1gP1fzXKnBBxoAB7uPvnU9KWcmTZDkO+FZevJ6YlSPBIvP0p?=
 =?us-ascii?Q?yR1quyyT0/mLhiDxcQg5jBLnURfcsnLxBbp+hfv0qnMZer0N+QRNBkPYBvk5?=
 =?us-ascii?Q?lD/S7b1byd8pNmB9sRsXV7l4aAQxahzfSS/UJRPziJ9E01YlC2m0u+JGUzCP?=
 =?us-ascii?Q?1YhQkrk7UquEBap79XKm4nrxnU6PDRdMqjR1zOfJd3PpvIRa/5QzwT428c4g?=
 =?us-ascii?Q?Q8c8Xz7JJows8icc6z3ffc/Mm4U6tJNlal1uas/uKK9RGd+xYjLtVjOAzAhM?=
 =?us-ascii?Q?KrkOepK+SQmfy2WJ9FttzKd+M7FA3Jj4volcRgOhDyYoHw5fiHNzSPBqyXcQ?=
 =?us-ascii?Q?xqEMjl7B56tSKF9oOdUAOKfzM0+bPrLRGjJckIYpRvEnZ82UP0hpoPHu5Jzx?=
 =?us-ascii?Q?Ta/UUaxNHIuB+XCbAyaE7q6Vca26yjGSh6E3YiawMfr2GoCUJNuM6/tj7+Th?=
 =?us-ascii?Q?wr6vJkYLPKjmGxUwvHcJqEmVDCS5Qb9eGFqNI3E+0dyatJx6scbse9ha08r3?=
 =?us-ascii?Q?4cC7MtVwt26mvtcxPUG0rvWvNpqcsGF2D+7OjsQmjth/evBwxlgQdslmwSbz?=
 =?us-ascii?Q?yRh5U9JwPzZcVTZKpEuc3IpJAW/jHCdlfkMIXUuw4kqtnZQ9BKQiVsJ0HzSL?=
 =?us-ascii?Q?4MTY1Tie7NhtK/+uQrjtuCRpPHvxlpAYYJvkt2q8DlJzev63dYhYLNacphHA?=
 =?us-ascii?Q?hb41cTfd70d0s0qtaQP2xM2r7sJCN5qTJ8k0asfHpNdvpp5jYRBICvY6+Y5K?=
 =?us-ascii?Q?P6N1jmULJWt1mhT0Xe2csf+a6iHi5hNDGypjWrM1agB2yBXLJcK9AurRjTJo?=
 =?us-ascii?Q?jPi/E2M46W5UUs+6G06v9RCB5hLGamgJ7aP+i9AofUzs+raWi6GoL0cHaDRv?=
 =?us-ascii?Q?5ezdDnbpcIMTvlpoomidnMq7pPCb+ghHc8GxabvrXJMNffB5Z7X2tyVExxdB?=
 =?us-ascii?Q?MW3AVcY3XsSLUU5+LXduSuADytaiiHC/wcp80Aslt62ACk8Qobq8NvB7LN5h?=
 =?us-ascii?Q?mhra5unsTwjYHQMK8Bj3UCwtVBg1ARbkgUGuXeUn9eK7vYba+kYQltLe5rKg?=
 =?us-ascii?Q?WVnY06YOgZQqvu1HLcq6Bd40lhDIK8PBOQx70Gmc2CT2tylY1trmzoD8MBZx?=
 =?us-ascii?Q?mEiugJAC7g2uzttpHOdWrkLrq772chMGoZK+PpTNz4zxJBE2nDaY7eQ3EzR6?=
 =?us-ascii?Q?1788wk8faJGBQa+NENtetnoeLrfZJJrphJdHpuJtArPFs4ILZttnGwSKQsHi?=
 =?us-ascii?Q?Y+hbAzDlqalbxi7kkTSsKW7HOkrL21OzemVM+nTaN0/jQMWNKW6JQx54J3MC?=
 =?us-ascii?Q?KCZikaIp0jC2pbeB4EBgJgNG+Dmk3KXJnesu0e93lpoST/Hw0CvnetXKBFi2?=
 =?us-ascii?Q?LFx9EMmZPhFpdsQE6do=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40b4b7e6-7d1a-4f12-d15c-08dc1292ab1e
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2024 10:47:12.4938
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: F0G0d16H6SvG7Ul/ZL25SLOyDM1H626LvdV9b6/LhzcgfFI5Bs8qb4keyKJnLr4+EU1TaIYwq5v91J5/MRA1Mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8948

Hi Sascha,

> Subject: Re: [PATCH] thermal/drivers/qoriq: fix getting tmu range
>
> Hi Peng,
>
> On Fri, Oct 20, 2023 at 04:13:37PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > TMU Version 1 has 4 TTRCRs, while TMU Version >=3D2 has 16 TTRCRs.
> > So limit the len to 4 will report "invalid range data" for i.MX93.
> >
> > This patch drop the local array with allocated ttrcr array and able to
> > support larger tmu ranges.
> >
> > Fixes: f12d60c81fce ("thermal/drivers/qoriq: Support version 2.1")
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/thermal/qoriq_thermal.c | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/thermal/qoriq_thermal.c
> > b/drivers/thermal/qoriq_thermal.c index ccc2eea7f9f5..404f01cca4da
> > 100644
> > --- a/drivers/thermal/qoriq_thermal.c
> > +++ b/drivers/thermal/qoriq_thermal.c
> > @@ -57,6 +57,9 @@
> >  #define REGS_TTRnCR(n)     (0xf10 + 4 * (n)) /* Temperature Range n
> >                                        * Control Register
> >                                        */
> > +#define NUM_TTRCR_V1       4
> > +#define NUM_TTRCR_MAX      16
> > +
> >  #define REGS_IPBRR(n)              (0xbf8 + 4 * (n)) /* IP Block Revis=
ion
> >                                                * Register n
> >                                                */
> > @@ -71,6 +74,7 @@ struct qoriq_sensor {
> >
> >  struct qoriq_tmu_data {
> >     int ver;
> > +   u32 ttrcr[NUM_TTRCR_MAX];
> >     struct regmap *regmap;
> >     struct clk *clk;
> >     struct qoriq_sensor     sensor[SITES_MAX];
> > @@ -182,17 +186,17 @@ static int qoriq_tmu_calibration(struct device
> *dev,
> >                              struct qoriq_tmu_data *data)
> >  {
> >     int i, val, len;
> > -   u32 range[4];
>
> Why don't you keep the array locally on the stack? Will it be needed
> elsewhere later?

Because max 16 as of now, it will consume 64bytes in stack, so I
move it out.

>
> Other than that:
>
> Tested-by: Sascha Hauer <s.hauer@pengutronix.de>
>

Thanks for testing this patch.

Thanks,
Peng.

> Would be great if this could be picked up anytime soon.
>
> Sascha
>
> --
> Pengutronix e.K.                           |                             =
|
> Steuerwalder Str. 21                       |
> http://www.p/
> engutronix.de%2F&data=3D05%7C02%7Cpeng.fan%40nxp.com%7C227277d8c0
> 20468aaf6e08dc128ba2ab%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%
> 7C0%7C638405638133353126%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%
> 7C%7C%7C&sdata=3DilwPz4Bs6f7CLf2snic7S%2FUsff0AYCgsFuZP9d2UExo%3D&
> reserved=3D0  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    =
|
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 =
|