Date: Thu, 13 Dec 2007 11:17:11 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org,
       "Rafael J. Wysocki" <rjw@sisk.pl>, venkatesh.pallipadi@intel.com
Subject: Re: [crash] kernel BUG at drivers/cpufreq/cpufreq.c:1060!
Message-ID: <20071213101711.GN8977@elte.hu>
References: <20071212091144.GA11986@elte.hu> <20071212164013.GA2359@redhat.com> <20071212181828.GA27675@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071212181828.GA27675@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 979
Lines: 23


* Dave Jones <davej@redhat.com> wrote:

>  > It _looks_ like we're leaking a refcount on that lock, but I don't 
>  > see where.  It's a shame you can't reproduce this easily, as 
>  > cpufreq.debug=7 would give us more clues. (And 
>  > CONFIG_CPUFREQ_DEBUG=y)
> 
> So we're missing some unlocks in some error paths. It's feasible you 
> hit one of those. This patch should be the fix for that.

since it's not really reproducible (i failed to get it since then), how 
about you push your fix upstream (it's an obviously correct fix), we 
consider this regression fixed and i'll re-notify you if there's still 
any problem left. It's not like there's any escape from make randconfig 
bootup test coverage in the long run ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/