Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761387AbXLMKXf (ORCPT ); Thu, 13 Dec 2007 05:23:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755655AbXLMKX1 (ORCPT ); Thu, 13 Dec 2007 05:23:27 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:54180 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755644AbXLMKX0 (ORCPT ); Thu, 13 Dec 2007 05:23:26 -0500 Date: Thu, 13 Dec 2007 11:22:59 +0100 From: Ingo Molnar To: Steven Rostedt Cc: LKML , Russell King , Thomas Gleixner , Remy Bohmer , Daniel Walker , Linus Torvalds , Andrew Morton Subject: Re: [PATCH] Revert lazy irq disable for simple irqs Message-ID: <20071213102259.GQ8977@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 28 * Steven Rostedt wrote: > [This patch *is* for mainline Linux] > > In commit 76d2160147f43f982dfe881404cfde9fd0a9da21 lazy irq disabling > was implemented, and the simple irq handler had a masking set to it. > > Remy Bohmer discovered that some devices in the ARM architecture would > trigger the mask, but never unmask it. His patch to do the unmasking > was questioned by Russell King about masking simple irqs to begin > with. Looking further, it was discovered that the problems Remy was > seeing was due to improper use of the simple handler by devices, and > he later submitted patches to fix those. But the issue that was > uncovered was that the simple handler should never mask. > > This patch reverts the masking in the simple handler. > > Signed-off-by: Steven Rostedt thanks, applied. This is for v2.6.24 too, right? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/