Received-SPF: pass (google.com: domain of linux-kernel+bounces-23482-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 11 Jan 2024 11:26:38 +0000
From: Lee Jones <lee@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Daniel Golle <daniel@makrotopia.org>,
	"David S. Miller" <davem@davemloft.net>,
	Li Zetao <lizetao1@huawei.com>, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v6 2/2] docs: ABI: sysfs-class-led-trigger-netdev:
 Document now hidable link_*
Message-ID: <20240111112638.GG1678981@google.com>
References: <20231221171125.1732-1-ansuelsmth@gmail.com>
 <20231221171125.1732-2-ansuelsmth@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231221171125.1732-2-ansuelsmth@gmail.com>

On Thu, 21 Dec 2023, Christian Marangi wrote:

> Document now hidable link speed modes for the LED netdev trigger.
> 
> Link speed modes are now showed only if the named network device
> supports them and are hidden if not.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> Reviewed-by: Marek Behún <kabel@kernel.org>
> ---
> Changes v6:
> - Add Reviewed-by tag
> Changes v2:
> - Add this patch
> 
>  .../ABI/testing/sysfs-class-led-trigger-netdev       | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

Reviewed-by: Lee Jones <lee@kernel.org>

> diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-netdev b/Documentation/ABI/testing/sysfs-class-led-trigger-netdev
> index a6c307c4befa..ed46b37ab8a2 100644
> --- a/Documentation/ABI/testing/sysfs-class-led-trigger-netdev
> +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-netdev
> @@ -88,6 +88,8 @@ Description:
>  		speed of 10MBps of the named network device.
>  		Setting this value also immediately changes the LED state.
>  
> +		Present only if the named network device supports 10Mbps link speed.
> +
>  What:		/sys/class/leds/<led>/link_100
>  Date:		Jun 2023
>  KernelVersion:	6.5
> @@ -101,6 +103,8 @@ Description:
>  		speed of 100Mbps of the named network device.
>  		Setting this value also immediately changes the LED state.
>  
> +		Present only if the named network device supports 100Mbps link speed.
> +
>  What:		/sys/class/leds/<led>/link_1000
>  Date:		Jun 2023
>  KernelVersion:	6.5
> @@ -114,6 +118,8 @@ Description:
>  		speed of 1000Mbps of the named network device.
>  		Setting this value also immediately changes the LED state.
>  
> +		Present only if the named network device supports 1000Mbps link speed.
> +
>  What:		/sys/class/leds/<led>/link_2500
>  Date:		Nov 2023
>  KernelVersion:	6.8
> @@ -127,6 +133,8 @@ Description:
>  		speed of 2500Mbps of the named network device.
>  		Setting this value also immediately changes the LED state.
>  
> +		Present only if the named network device supports 2500Mbps link speed.
> +
>  What:		/sys/class/leds/<led>/link_5000
>  Date:		Nov 2023
>  KernelVersion:	6.8
> @@ -140,6 +148,8 @@ Description:
>  		speed of 5000Mbps of the named network device.
>  		Setting this value also immediately changes the LED state.
>  
> +		Present only if the named network device supports 5000Mbps link speed.
> +
>  What:		/sys/class/leds/<led>/link_10000
>  Date:		Nov 2023
>  KernelVersion:	6.8
> @@ -153,6 +163,8 @@ Description:
>  		speed of 10000Mbps of the named network device.
>  		Setting this value also immediately changes the LED state.
>  
> +		Present only if the named network device supports 10000Mbps link speed.
> +
>  What:		/sys/class/leds/<led>/half_duplex
>  Date:		Jun 2023
>  KernelVersion:	6.5
> -- 
> 2.40.1
> 

-- 
Lee Jones [李琼斯]