Received-SPF: pass (google.com: domain of linux-kernel+bounces-23483-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240110080729.3238251-1-dario.binacchi@amarulasolutions.com>
 <20240110080729.3238251-6-dario.binacchi@amarulasolutions.com> <7889dff7-2c38-43c0-b6f7-281a20ae9733@foss.st.com>
In-Reply-To: <7889dff7-2c38-43c0-b6f7-281a20ae9733@foss.st.com>
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Date: Thu, 11 Jan 2024 12:27:00 +0100
Message-ID: <CABGWkvoatqxz2_8_7khHAC8n4gFNyvfDPR3A88fsfuppJxN_5Q@mail.gmail.com>
Subject: Re: [Linux-stm32] [PATCH v6 5/5] ARM: dts: add stm32f769-disco-mb1225-revb03-mb1166-reva09
To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 
	Conor Dooley <conor+dt@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, 
	Maxime Coquelin <mcoquelin.stm32@gmail.com>, Manivannan Sadhasivam <mani@kernel.org>, 
	Andre Przywara <andre.przywara@arm.com>, linux-stm32@st-md-mailman.stormreply.com, 
	=?UTF-8?Q?Leonard_G=C3=B6hrs?= <l.goehrs@pengutronix.de>, 
	Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Sean Nyekjaer <sean@geanix.com>, 
	linux-amarula@amarulasolutions.com, Peter Rosin <peda@axentia.se>, 
	linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Raphael,

On Thu, Jan 11, 2024 at 12:22=E2=80=AFPM Raphael Gallais-Pou
<raphael.gallais-pou@foss.st.com> wrote:
>
>
> On 1/10/24 09:05, Dario Binacchi wrote:
> > As reported in the section 8.3 (i. e. Board revision history) of docume=
nt
> > UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes
> > related to the board revisions addressed by the patch:
> > - Board MB1225 revision B-03:
> >   - Memory MICRON MT48LC4M32B2B5-6A replaced by ISSI IS42S32400F-6BL
> > - Board MB1166 revision A-09:
> >   - LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK
> >
> > The patch only adds the DTS support for the new display which belongs t=
o
> > to the Novatek NT35510-based panel family.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >
> > ---
> >
> > Changes in v6:
> > - Drop patches
> >   - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A=
-CTK
> >   - [7/8] drm/panel: nt35510: move hardwired parameters to configuratio=
n
> >   - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK
> >   because applied by the maintainer Linus Walleij
> >
> > Changes in v5:
> > - Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_=
optional().
> >
> > Changes in v2:
> > - Change the status of panel_backlight node to "disabled"
> > - Delete backlight property from panel0 node.
> > - Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25=
025-A-CTK"
> >   in the same style as the original driver.
> >
> >  arch/arm/boot/dts/st/Makefile                  |  1 +
> >  ...2f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 ++++++++++++++++++
> >  2 files changed, 19 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-=
mb1166-reva09.dts
> >
> > diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makef=
ile
> > index 7892ad69b441..390dbd300a57 100644
> > --- a/arch/arm/boot/dts/st/Makefile
> > +++ b/arch/arm/boot/dts/st/Makefile
> > @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) +=3D \
> >       stm32f469-disco.dtb \
> >       stm32f746-disco.dtb \
> >       stm32f769-disco.dtb \
>
> Hi Dario,
>
>
> Did you meant dtb here ? ;)
Good catch!
Thanks for the review!

Regards,
Dario

>
>
> Regards,
>
> Rapha=C3=ABl
>
> > +     stm32f769-disco-mb1225-revb03-mb1166-reva09.dts \
> >       stm32429i-eval.dtb \
> >       stm32746g-eval.dtb \
> >       stm32h743i-eval.dtb \
> > diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-=
reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva=
09.dts
> > new file mode 100644
> > index 000000000000..014cac192375
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.=
dts
> > @@ -0,0 +1,18 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2023 Dario Binacchi <dario.binacchi@amarulasolutions.=
com>
> > + */
> > +
> > +#include "stm32f769-disco.dts"
> > +
> > +&panel_backlight {
> > +     status =3D "disabled";
> > +};
> > +
> > +&panel0 {
> > +     compatible =3D "frida,frd400b25025", "novatek,nt35510";
> > +     vddi-supply =3D <&vcc_3v3>;
> > +     vdd-supply =3D <&vcc_3v3>;
> > +     /delete-property/backlight;
> > +     /delete-property/power-supply;
> > +};


--=20

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi@amarulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@amarulasolutions.com

www.amarulasolutions.com