Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1576152rdd; Thu, 11 Jan 2024 03:30:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyGqZG2eTdZB7Jl55rUIejXYGWm4IO7ZK/0uwaqszCRmkc82h1P+hWrUDkg7Nb/mnaUlQX X-Received: by 2002:a17:90b:38c6:b0:28c:17de:c8ce with SMTP id nn6-20020a17090b38c600b0028c17dec8cemr871559pjb.2.1704972640469; Thu, 11 Jan 2024 03:30:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704972640; cv=none; d=google.com; s=arc-20160816; b=SGFCgFPNIAl9xIUngwOZ09HumewPi1jsnBvZWXxE6stCh3r4KiT/ARHVAcpxm4YnzR ny1XIgD8GETfHAZB1Yd9YBlEFXbcjcVQKhpk5kqNgC0bI4fmVV/4ewLRg6ZXC3J9WASE aqQoS5SsOpKAfbsLqF5fPcBY+O97zdQBroKmQbyYUZsHhz5iWtae5VqzbJZxvfSuhw6i sISh8uPvtmdk8OeodoATqPXtDEE3vMj68Q7AKIbGfr4uTJ593uq6nYyv9RdhWlEHnTgm bSdI7VXpq5VR5lyDdQ6Z+LetXiWVf/ucghH4KEiMzwviSTINMAOG+LJgbWTD/eMQlXVr H8WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=GV0FRwagi1eC6Ri+CqYf3SFvZZbKN4cbsP98/huTeY8=; fh=qGaTjgV7Umk/mTxgJgaSzmlIyXMtiiH0XeDOTL+8I+A=; b=hl5giJGEG5PBdOEbwnDXhwS19D7ws5NSnBiE1/n7aNeUlQTHNkaCaMkFZdzFYpa7wG jyCR6UvSJSE/uvcGhqRKzBUjPgCrYkf3dyWgB2V9L1wghXXvEWGZCX7WLKN3OP/nUtY3 qCBbXWlV2f+7fP99gJU0SKtYGPr7LRSLOtztkJCRM6rJLLgLaiWmLT+rc4Lyx9kaS2P+ TSsfx2dN4VYNorZgU7Lpzul2bLvN4aR8Q6RLVh7y3K+7a/+iUvaEfmsEKKfPN8fbZP9r cJ9PY7iWdfLY6vFEATFspCZ2mO1WHAhT4GizgAOSpbFANRjTK2+kS12n52ocwP2jy7Xa qM9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BVSdJ9Aq; spf=pass (google.com: domain of linux-kernel+bounces-23487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23487-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id la14-20020a170902fa0e00b001d55deaa459si260237plb.610.2024.01.11.03.30.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 03:30:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BVSdJ9Aq; spf=pass (google.com: domain of linux-kernel+bounces-23487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23487-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 58FEC2862DE for ; Thu, 11 Jan 2024 11:30:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 17B9D154A7; Thu, 11 Jan 2024 11:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BVSdJ9Aq" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9A8715482 for ; Thu, 11 Jan 2024 11:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704972621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GV0FRwagi1eC6Ri+CqYf3SFvZZbKN4cbsP98/huTeY8=; b=BVSdJ9AqmT7nPNaP6gWLwo+hDL7KXjhIz81pWEt4IT69VxsfY3jjbcgq3nmjkwjyErfz+y gTcvRKtdJGPfYnHEfEpQORbPMiQ5BnUaXGnv6UK4vHsxPgLbAJM6Ov52mMCPuIdCudnbPi 2YrP+n81jeYBabWup9nYFGkMVhHRTZk= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-dECkgHjMMvGHbx6IkwDxqw-1; Thu, 11 Jan 2024 06:30:19 -0500 X-MC-Unique: dECkgHjMMvGHbx6IkwDxqw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a2777fdf6d4so51242266b.0 for ; Thu, 11 Jan 2024 03:30:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704972618; x=1705577418; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GV0FRwagi1eC6Ri+CqYf3SFvZZbKN4cbsP98/huTeY8=; b=nDIJ9KS35UjBDcya5udPy3Q0TKxStJ/wj0btXTGe2Bwnpypczi4fl1YqEEEWppxSI4 r7CHmfeN4m4Pmy+FueADTwWnj96lpjPB9rBhUGTdhBthXX1gulhh/zDdZvWFz6r3yk+K B17M9dxfr3ikCKKkpKizHtvuhjUhpfhQGmod0pFtTnVXAeYGyOYst9IbkzdQZB3il8E9 U62gwRmaPgX/jR2SRAlJhjk3EA9e5KvpWxtrhiWZ4V7S3rCZVvp0ercEQ99Te3a1XAJv HE40Ay4BQCY2I+U8FLwko1bt85LIkuUZqNZTa018OEwjoEXc2s/K4mSy6yNMxl1xPyHO 4Hlw== X-Gm-Message-State: AOJu0YytOq/m/kIx9cJ6QwRV/4E2hH6Nl6w4/oYJAozrdjRDbZNAivZ6 bFgSUk3DOSvwuSCSxkl1bkYKwvdvkQIvC7aooRkC9XdP8uYUY8R0uaaXeMHTU/7g5ehiZc3NXNm d9QF+l0rqrR/xu+0G+QUKB9UFsbzEoM7e X-Received: by 2002:a17:907:7215:b0:a2b:1e1a:ac4c with SMTP id dr21-20020a170907721500b00a2b1e1aac4cmr1194953ejc.6.1704972618542; Thu, 11 Jan 2024 03:30:18 -0800 (PST) X-Received: by 2002:a17:907:7215:b0:a2b:1e1a:ac4c with SMTP id dr21-20020a170907721500b00a2b1e1aac4cmr1194935ejc.6.1704972618217; Thu, 11 Jan 2024 03:30:18 -0800 (PST) Received: from gerbillo.redhat.com (146-241-244-191.dyn.eolo.it. [146.241.244.191]) by smtp.gmail.com with ESMTPSA id ox9-20020a170907100900b00a2825a9e1d0sm469304ejb.174.2024.01.11.03.30.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 03:30:17 -0800 (PST) Message-ID: <4d927762575cb4b453d6651dcf8f2d1e58b1c778.camel@redhat.com> Subject: Re: [PATCH net] ethtool: netlink: Add missing ethnl_ops_begin/complete From: Paolo Abeni To: Ludvig =?ISO-8859-1?Q?P=E4rsson?= , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com Date: Thu, 11 Jan 2024 12:30:16 +0100 In-Reply-To: <20240108-etht2-v1-1-beab95e80f7e@axis.com> References: <20240108-etht2-v1-1-beab95e80f7e@axis.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-01-08 at 16:17 +0100, Ludvig P=C3=A4rsson wrote: > Accessing an ethernet device that is powered off or clock gated might > cause the CPU to hang. Add ethnl_ops_begin/complete in > ethnl_set_features() to protect against this. >=20 We need a suitable Fixes tag here > Signed-off-by: Ludvig P=C3=A4rsson > --- > net/ethtool/features.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/net/ethtool/features.c b/net/ethtool/features.c > index a79af8c25a07..b6cb101d7f19 100644 > --- a/net/ethtool/features.c > +++ b/net/ethtool/features.c > @@ -234,17 +234,20 @@ int ethnl_set_features(struct sk_buff *skb, struct = genl_info *info) > dev =3D req_info.dev; > =20 > rtnl_lock(); > + ret =3D ethnl_ops_begin(dev); > + if (ret < 0) > + goto out_rtnl; You should likely follow-up on net-next only converting ethnl_set_features to ethnl_default_set_doit. Cheers, Paolo