Received-SPF: pass (google.com: domain of linux-kernel+bounces-23505-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240110222210.193479-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <CAMuHMdXSLBARbtc91F=cWqTdL+UcT4wJbr0_m5+iz_6BXA4Acw@mail.gmail.com>
In-Reply-To: <CAMuHMdXSLBARbtc91F=cWqTdL+UcT4wJbr0_m5+iz_6BXA4Acw@mail.gmail.com>
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: Thu, 11 Jan 2024 11:41:54 +0000
Message-ID: <CA+V-a8vwcyVbxyKkZyepcQsxSooa-gy_-KYDJdTnQkRW9MQ01w@mail.gmail.com>
Subject: Re: [PATCH] dmaengine: usb-dmac: Avoid format-overflow warning
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Vinod Koul <vkoul@kernel.org>, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, 
	Tudor Ambarus <tudor.ambarus@linaro.org>, Kees Cook <keescook@chromium.org>, 
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-renesas-soc@vger.kernel.org, 
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Geert,

Thank you for the review.

On Thu, Jan 11, 2024 at 9:05=E2=80=AFAM Geert Uytterhoeven <geert@linux-m68=
k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, Jan 10, 2024 at 11:23=E2=80=AFPM Prabhakar <prabhakar.csengg@gmai=
l.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > gcc points out that the fix-byte buffer might be too small:
> > drivers/dma/sh/usb-dmac.c: In function 'usb_dmac_probe':
> > drivers/dma/sh/usb-dmac.c:720:34: warning: '%u' directive writing betwe=
en 1 and 10 bytes into a region of size 3 [-Wformat-overflow=3D]
> >   720 |         sprintf(pdev_irqname, "ch%u", index);
> >       |                                  ^~
> > In function 'usb_dmac_chan_probe',
> >     inlined from 'usb_dmac_probe' at drivers/dma/sh/usb-dmac.c:814:9:
> > drivers/dma/sh/usb-dmac.c:720:31: note: directive argument in the range=
 [0, 4294967294]
> >   720 |         sprintf(pdev_irqname, "ch%u", index);
> >       |                               ^~~~~~
> > drivers/dma/sh/usb-dmac.c:720:9: note: 'sprintf' output between 4 and 1=
3 bytes into a destination of size 5
> >   720 |         sprintf(pdev_irqname, "ch%u", index);
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Maximum number of channels for USB-DMAC as per the driver is 1-99 so us=
e
> > u8 instead of unsigned int/int for DMAC channel indexing and make the
> > pdev_irqname string long enough to avoid the warning.
> >
> > While at it use scnprintf() instead of sprintf() to make the code more
> > robust.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> One nit below.
>
> > --- a/drivers/dma/sh/usb-dmac.c
> > +++ b/drivers/dma/sh/usb-dmac.c
>
> > @@ -768,8 +768,8 @@ static int usb_dmac_probe(struct platform_device *p=
dev)
> >         const enum dma_slave_buswidth widths =3D USB_DMAC_SLAVE_BUSWIDT=
H;
> >         struct dma_device *engine;
> >         struct usb_dmac *dmac;
> > -       unsigned int i;
> >         int ret;
> > +       u8 i;
>
> Personally, I'm not much a fan of making loop counters smaller than
> (unsigned) int.  If you do go this way, there are more loops over all
> channels still using int.
>
Agreed. So shall I drop Kees suggestion and leave the patch as is?

Cheers,
Prabhakar