Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761646AbXLMKbm (ORCPT ); Thu, 13 Dec 2007 05:31:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753904AbXLMKbc (ORCPT ); Thu, 13 Dec 2007 05:31:32 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:52200 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757955AbXLMKbb (ORCPT ); Thu, 13 Dec 2007 05:31:31 -0500 Date: Thu, 13 Dec 2007 02:31:11 -0800 From: Andrew Morton To: Marcin =?UTF-8?B?xZpsdXNhcno=?= Cc: linux-kernel@vger.kernel.org, Antonino Daplas , linux-fbdev-devel@lists.sourceforge.net Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h Message-Id: <20071213023111.30ddc487.akpm@linux-foundation.org> In-Reply-To: <20071209214027.GG9440@joi> References: <20071209214027.GG9440@joi> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 20 On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ĺšlusarz wrote: > logo: move declarations of logos to linux_logo.h > > there was a mismatch between externs in logo.c and code generated by pnmtologo > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation) This patch (after I fixed it) keeps on causing trouble: mismatches between the header file declarations and the actual definitions of the lookup tables. This happens as I apply and unapply the patch. It _shouldn't_ happen, but there would appear to be some missing makefile rules. I guess the C files aren't being regenerated when scripts/pnmtologo.c has been altered, so the C files aren't matching the header which this patch alters. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/