Received-SPF: pass (google.com: domain of linux-kernel+bounces-23523-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240110133038.46903-1-wudaemon@163.com>
In-Reply-To: <20240110133038.46903-1-wudaemon@163.com>
From: Yafang Shao <laoar.shao@gmail.com>
Date: Thu, 11 Jan 2024 19:52:30 +0800
Message-ID: <CALOAHbAtXQsqi5ny58NRG9wOmZpOVkCi7yyy-ZtZdTnHZcPz5g@mail.gmail.com>
Subject: Re: [PATCH v4] sched/stats: Fix rt/dl task's sched latency statistics
 error in sched_stat_wait trace_point
To: Junwen Wu <wudaemon@163.com>
Cc: bristot@redhat.com, mingo@redhat.com, peterz@infradead.org, 
	juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, 
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 10, 2024 at 9:32=E2=80=AFPM Junwen Wu <wudaemon@163.com> wrote:
>
> The sched_stat_wait tracepoint is showing unreasonably long
> latencies for real-time tasks. For example:
>
> sched_stat_wait: comm=3Drcu_preempt pid=3D14 delay=3D4936139545261 [ns]
>
> This error happens when the rt task balances off the source CPU because
> the dequeue operation is not updating the sched_statistics. So, follow
> update_stats_wait_end_fair() and update the stats. Do the same for
> SCHED_DEADLINE.
>
> Fixes: 57a5c2dafca8 ("sched/rt: Support schedstats for RT sched class")
> Fixes: b5eb4a5f6521 ("sched/dl: Support schedstats for deadline sched cla=
ss")
> Signed-off-by: Junwen Wu <wudaemon@163.com>

Acked-by: Yafang Shao <laoar.shao@gmail.com>

BTW, feel free to include the 'acked-by' in a newer version if your
modifications are only minor.

> ---
>  kernel/sched/deadline.c | 5 ++++-
>  kernel/sched/rt.c       | 4 ++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index b28114478b82..4a9aad291fb9 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1558,10 +1558,13 @@ update_stats_dequeue_dl(struct dl_rq *dl_rq, stru=
ct sched_dl_entity *dl_se,
>                         int flags)
>  {
>         struct task_struct *p =3D dl_task_of(dl_se);
> +       struct rq *rq =3D rq_of_dl_rq(dl_rq);
>
>         if (!schedstat_enabled())
>                 return;
> -
> +       /*  Mark the end of the wait period if dequeueing a waiting task.=
*/
> +       if (p && (p !=3D rq->curr))
> +                update_stats_wait_end_dl(dl_rq, dl_se);
>         if ((flags & DEQUEUE_SLEEP)) {
>                 unsigned int state;
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 6aaf0a3d6081..5cb3a54d6b13 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1360,12 +1360,16 @@ update_stats_dequeue_rt(struct rt_rq *rt_rq, stru=
ct sched_rt_entity *rt_se,
>                         int flags)
>  {
>         struct task_struct *p =3D NULL;
> +       struct rq *rq =3D rq_of_rt_se(rt_se);
>
>         if (!schedstat_enabled())
>                 return;
>
>         if (rt_entity_is_task(rt_se))
>                 p =3D rt_task_of(rt_se);
> +       /* Mark the end of the wait period if dequeueing a waiting task. =
*/
> +       if (p && (p !=3D rq->curr))
> +               update_stats_wait_end_rt(rt_rq, rt_se);
>
>         if ((flags & DEQUEUE_SLEEP) && p) {
>                 unsigned int state;
> --
> 2.34.1
>


--=20
Regards
Yafang