Received-SPF: pass (google.com: domain of linux-kernel+bounces-23696-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 11 Jan 2024 21:04:33 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Vegard Nossum <vegard.nossum@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Documentation <linux-doc@vger.kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Randy Dunlap <rdunlap@infradead.org>,
	Attreyee M <tintinm2017@gmail.com>,
	Adam Turner <9087854+aa-turner@users.noreply.github.com>
Subject: Re: [PATCH] Documentation: sphinx: Require alabaster <0.7.14
Message-ID: <ZZ_1cflRM2jo22on@archie.me>
References: <20240111102128.37192-4-bagasdotme@gmail.com>
 <50045aff-91f9-4809-ba3e-b722b325d233@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="L2BJbRGut8pyO475"
Content-Disposition: inline
In-Reply-To: <50045aff-91f9-4809-ba3e-b722b325d233@oracle.com>


--L2BJbRGut8pyO475
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 11, 2024 at 12:18:44PM +0100, Vegard Nossum wrote:
> On 11/01/2024 11:21, Bagas Sanjaya wrote:
> > Alabaster commit 640273fd3ca7 ("Drop support for Python 3.8 and
> > earlier") [1] bumps minimum Sphinx version to v3.4, which breaks
> > htmldocs build due to version incompatibility with Sphinx version used
> > in Linux kernel documentation (v2.4.4):
> >=20
> > ```
> > Sphinx version error:
> > The alabaster extension used by this project needs at least Sphinx v3.4=
; it therefore cannot be built with this version.
> > ```
> >=20
> > Fix the build error by requiring alabaster version less than 0.7.14 (in
> > other words, at most 0.7.13).
> >=20
> > Link: https://github.com/sphinx-doc/alabaster/commit/640273fd3ca7cdc152=
8c591172fd9cce2ead911c [1]
> > Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> > ---
> >   I'm noticing htmldocs error when trying to build current master (stil=
l in
> >   merge window). Is this patch OK for 6.8 material after v6.8-rc1 is re=
leased
> >   (as stabilizing fix)?
> >=20
> >   Documentation/sphinx/requirements.txt | 2 ++
> >   1 file changed, 2 insertions(+)
> >=20
> > diff --git a/Documentation/sphinx/requirements.txt b/Documentation/sphi=
nx/requirements.txt
> > index 335b53df35e22f..b2ca7432437518 100644
> > --- a/Documentation/sphinx/requirements.txt
> > +++ b/Documentation/sphinx/requirements.txt
> > @@ -1,3 +1,5 @@
> >   # jinja2>=3D3.1 is not compatible with Sphinx<4.0
> >   jinja2<3.1
> >   Sphinx=3D=3D2.4.4
> > +# alabaster>=3D0.7.14 is not compatible with Sphinx<3.4
> > +alabaster<0.7.14
> >=20
> > base-commit: de927f6c0b07d9e698416c5b287c521b07694cac
>=20
> Note: I submitted almost exactly the same patch yesterday:
>=20
> https://lore.kernel.org/linux-doc/20240110104646.3647600-1-vegard.nossum@=
oracle.com/
>=20

Oops, I didn't see your patch before I submitted mine. Thanks anyway.

--=20
An old man doll... just what I always wanted! - Clara

--L2BJbRGut8pyO475
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZZ/1bAAKCRD2uYlJVVFO
oy3oAP9GYFmuXacSSlb14NeuB+XhxDnep0fl0SrVFtmbzVDL7gEAwM5XgEn1Xb3N
0CQwjNNN+Mz2PMDM1r9o3GSn8LYcKgo=
=gEdX
-----END PGP SIGNATURE-----

--L2BJbRGut8pyO475--