Received-SPF: pass (google.com: domain of linux-kernel+bounces-23702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d3ad9479-f92a-4f79-b97c-0bb17ab0e7b4@vivo.com>
Date: Thu, 11 Jan 2024 22:15:53 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/2] mm:vmscan: fix workingset eviction memcg issue
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
 David Hildenbrand <david@redhat.com>, Matthew Wilcox <willy@infradead.org>,
 Chris Li <chrisl@kernel.org>, Michal Hocko <mhocko@suse.com>,
 Kefeng Wang <wangkefeng.wang@huawei.com>,
 Dan Schatzberg <schatzberg.dan@gmail.com>,
 Yosry Ahmed <yosryahmed@google.com>, Yue Zhao <findns94@gmail.com>,
 Hugh Dickins <hughd@google.com>, linux-kernel@vger.kernel.org,
 linux-mm@kvack.org, opensource.kernel@vivo.com
References: <20240111122451.682-1-justinjiang@vivo.com>
 <20240111122451.682-2-justinjiang@vivo.com>
 <20240111134125.GA390292@cmpxchg.org>
From: zhiguojiang <justinjiang@vivo.com>
In-Reply-To: <20240111134125.GA390292@cmpxchg.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NEpKeGEybjZodFQ0K050V0FnSm45OENJdGRWdnhiNTdTTFlWVDZCTTdaZmlK?=
 =?utf-8?B?dzJsSEdkZklyMEhlUUN6eFNpcjRoZlpRTlVmMTRZdGF6TnNEd3JVTlhsSW5l?=
 =?utf-8?B?OHBXSGUyUlpqcEhPamVWMzVzV3BJVWxISVo1QmNZSkg5Z2gvMy9LeXk1cFJK?=
 =?utf-8?B?bWp1WE9qbVpnaWZ4RnBtREtIQ2RXSzE1YUgyKzh1VVdNdVNSWHBsK3NVZjZB?=
 =?utf-8?B?YzlJNXlsUEEvdkwvTzlIU1IvL1ZhbVVHWSt2TkNpZE9VMitMYS8yNTl2b1dk?=
 =?utf-8?B?YUFWTVJaRjBzc2NWcGRDN2NnS3VoYlgvS3JPM0J5L0xRTWNIcEh3QVRlRUhH?=
 =?utf-8?B?a2RXT0FjTjMzakcwS2gxalI0Z0dyUzR0OHozYm9GalhidlJTeDI4aTNrRzJP?=
 =?utf-8?B?OXpXMDlrV01nQlVHNjBOd1AwRithTGxaNSt5TW01MWQzRXZUQzg4YjNwajBu?=
 =?utf-8?B?WHg3NlN2Zm9BOS9oalRRcE5Mc3ZrUGtkNVEza3hEclh4dHRqVkFHZ2s2U0RM?=
 =?utf-8?B?a2MxY21ZN1h5U1FyRXhaL1JNakd3Rk9qVDNpNTh2ditFZHZNY3BuU09hNndI?=
 =?utf-8?B?S1ppSWFtTGN3UlpHY09vcVlySityZldUMVdoUVB2L0JSNlhrUXNJWWdyU2xs?=
 =?utf-8?B?NWo1WFE2MHA2UWk2bllnTHJqamRTTG1OdDU1cWVHM28wVE9DU0ZhTGFKVkhO?=
 =?utf-8?B?WXhGUHlLdlFzV1ZYcmZpY0pOUWJ4Y1dWN3BxaEU0cE9vZWRnSmthcmhmRkhQ?=
 =?utf-8?B?U3NjWnhvNk1qdXM1VWhwbUlwbUNhUFZDTldGVndPVmxFQlNUa3JYNlZBa2Zt?=
 =?utf-8?B?OWNxMStUOFgzWG1kb1FkNnBjYm9iOHVKRUdqU20vaGdSRmIwZEJCTnhaQ0Ux?=
 =?utf-8?B?MWNlekhTam03aFg3T1JzaVRvd2luSmZ4aHBRNk1nR2N0cHNxUFhZYVBxVGJv?=
 =?utf-8?B?L1hFbVhpVTZBblRFZnpHRi9rd0Q1MjBiaEl1bkcyRGNoS3dCMGlTbTBidEk4?=
 =?utf-8?B?eXRyNjU1OHcrRmZVeENNN2dCUHdobk9OTWZsc2tsMksxQU4weFJKcnJ4Y0g5?=
 =?utf-8?B?M2pIYlRGOFkrYkhITlhRTzBDbEVUeFZzLytIaVRBWmY2TTkxSVMzYWp0alFq?=
 =?utf-8?B?TmF5SUNaamhTcEZaYk9PWHZCUWpQeUZVa1RhTG13VGJlbEI3cThLenM1aURN?=
 =?utf-8?B?R2FvNDQxYm82Ty9GcWwrNDRCTWVneVFKWXpUS3hFTldnc3FObjg3WlFnV252?=
 =?utf-8?B?UUtVdzg1U01KR1pLd3ZFQWVBSWhFUVh4dVhQdWwxNnlGeml3QlljNCtUMGtz?=
 =?utf-8?B?bkFoV0s1RnBVL2VwTHRPYWRRWW5XbGdaVTVjRzdCNytlQ2FIbGdhODA1SFBD?=
 =?utf-8?B?dEowcTRhTFRpYjg1MHZJaHhLU29rREhMVWhKYnNhSC9iSUZWVTRzQzhYcGhj?=
 =?utf-8?B?SGJWcFNXVHA5NXk0THpVRUc5OVZHK01BbmU0VVpBUUZGVkIrckRXcm52UG9y?=
 =?utf-8?B?Nk11ODFQMkxaTXVoZGJYZXVNeURFR2tBcmxlR0dEa000K2FiWWJLRDVHU3l5?=
 =?utf-8?B?ejZjVlV3SmxWSEgydzZGblQvM2tvdGJQL0grbG1PY08vSWZzN3RGVmRIYi85?=
 =?utf-8?B?WVFXMUIzL0hNbTRHN0t4VFRyYzFBT2ZKanIrY3JXcGhIWlhUdE5kakdHL3g3?=
 =?utf-8?B?VnRHYWdkbXFsRWVYcHBXNnVuVEUxdXJCaTRqWm1uaHZOeXhKSmZkbjJsODNn?=
 =?utf-8?B?YmhFY09wRElMUlVBZmI5VkZtcVVudHUyTndWTUxKWCtabmdGaHpEQm92Y0dp?=
 =?utf-8?B?UHJQTk1JREllWlBTZlRlWE9qa080dkkvUWlhQkQ3WXdTMkQvU3prMjBtNkRE?=
 =?utf-8?B?cTJYRlVGVlE2UlZoRUU3TWZrNzZWSWRUUEg3TGllU1h6RENYaHZpWG42d084?=
 =?utf-8?B?SkcxSWdla2lpeENwQ25mbU1GckNQSmJCY2dCZ01tV2tsMjFiVUE2UmR4OVA5?=
 =?utf-8?B?UXJVYzM3Mk56VVg4b2NCcnY1Z0sxcHFCZWJhOVdNRVh1WTBJbVl4T3RvRXQ5?=
 =?utf-8?B?b0pFREsxY0w5U3hHeXRsalAyWmFUMzkzTm5EMmlqTnpwaFYvRnlPMEZEWGFn?=
 =?utf-8?Q?GPAT4VkOnX822MQ5RjZ510y4u?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 358943b8-44f5-4050-9818-08dc12afd351
X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB6849.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 14:15:55.5113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U7FLqZLxDqouc+JDEhCtgX2r2uP4uy1+kS33YJqQ6GeOLbIJd5X+TgV2+C2siT9ApKWNCElm6E9lk8IuMRwJog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4476


在 2024/1/11 21:41, Johannes Weiner 写道:
> On Thu, Jan 11, 2024 at 08:24:50PM +0800, Zhiguo Jiang wrote:
>> The parameter of target_memcg is NULL in workingset_eviction(), and
>> the lruvec obtained by mem_cgroup_lruvec(target_memcg, pgdat) is always
>> root_mem_cgroup->lruvec, rather than the lruvec of mem_cgroup where
>> folio is actually located.
> WTF? No!
>
> 	/*
> 	 * The memory cgroup that hit its limit and as a result is the
> 	 * primary target of this reclaim invocation.
> 	 */
> 	struct mem_cgroup *target_mem_cgroup;
>
> The cgroup that is stored in the eviction cookie is the one whose
> limit triggered the reclaim cycle. This is often several levels above
> the cgroups that own the pages. Subsequent refaults need to be
> evaluated at the eviction level:
>
> 	/*
> 	 * The activation decision for this folio is made at the level
> 	 * where the eviction occurred, as that is where the LRU order
> 	 * during folio reclaim is being determined.
> 	 *
> 	 * However, the cgroup that will own the folio is the one that
> 	 * is actually experiencing the refault event.
> 	 */
May I ask three questions: 1.I don't understand the meaning of this 
paragraph. Can you explain it in detail ? 2.What are the characteristics 
of folios managed by the root_mem_cgroup differring from other memcgs? 
3.If shrink flow uses target_lruvec->anon_cost/file_cost, what is the 
purposr of calculating the actual memcg's lruvec->anon_cost/file_cost in 
lru_note_cost(), and the actual memcg's lruvec->anon_cost/file_cost 
values are unused in shrink flow ? Thanks
>> Fix target_memcg to the memcg obtained by folio_memcg(folio).
>>
>> Signed-off-by: Zhiguo Jiang <justinjiang@vivo.com>
> Nacked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> Please take more time to read into the code you're proposing to
> change. You made it sound like a trivial simplification, but this
> totally screws up aging and pressure detection in containers.