Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1674208rdd; Thu, 11 Jan 2024 06:17:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsT60LhDd5I7aibwIHBeohYQ5Hj9LrQdA8xDoAid8iK8POUhR1dqi4BQSbZlhOOQ7E1mJq X-Received: by 2002:a17:90b:14d:b0:28c:d0ab:adf0 with SMTP id em13-20020a17090b014d00b0028cd0abadf0mr978383pjb.96.1704982631205; Thu, 11 Jan 2024 06:17:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704982631; cv=none; d=google.com; s=arc-20160816; b=JFOOu9xX70USWZnS4Z8v6ZMA6/UE1oaQAkfsXfWdn/H5/vgO4NOXz6UlRRgr4GeY99 SZqrPuw+l+I9au/jjuPGD8isAyVy3TPNanWgJf8nCnzQBnU2Bj+GeZrh3OUHQgudM4Lm V1DA4O3ufehRLZqly0mRJ+rGOpiVI0MHoeU46IQyo+ic3TpOFic2t7nhoo4+MtV4be/A mH3SDqFIyyoHr8IHlS+ovyB8QW8RJbU9xRjUU4TUdif/Y1hPGogpqKTygAx/ddTkJF4Y YhRAc4JKh/J0WhACPYeQG3B1JR+1oFNif5CXp/RijdE8DK3s/SteUZIqsFe764Y8zalu 352w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=C7HNZaDiw/8JtL+WOdbC/TQ6GQKXbKUvja93oq/W0PE=; fh=owht9b4qBhHgu9FJV+9bmVGxj3RRl0PrGOsGNChGyW8=; b=jvSM2VS4SnZ3wFIiNnHVwpiO7ChKqW3oZHwY1le28qvbZvbRcyp6fZT8qeYmv7WLqj XcWqImHh5qIApmvhi592mRPH9uqk26RQBPnf2SrNTtea8Ww3OODBnyS9t3vztJhwwWuC 2uywpCwGZZuI+wm1rt8txHrvQBb/tDl4tdsq+xJ404smrR6EgPIlrpkbvCezHetmf55F BgRR0HqrPG/ajUmh4EohceLSHI1+wT4/7hHTODnGvVZ0Q1Uwf/w9B35sJRkLbEN0HGlp YqXNGbPQca1nyaB0hohU50XHZYVsnL8YcjzfOFVCipHV31d4Lzz574TSzWSi6PbUbJzJ qAIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vkfbozRu; spf=pass (google.com: domain of linux-kernel+bounces-23703-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id cp12-20020a17090afb8c00b0028d27328f1esi3781178pjb.112.2024.01.11.06.17.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 06:17:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23703-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vkfbozRu; spf=pass (google.com: domain of linux-kernel+bounces-23703-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D51E828740F for ; Thu, 11 Jan 2024 14:17:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BE0A3D384; Thu, 11 Jan 2024 14:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vkfbozRu" Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48CE53B185 for ; Thu, 11 Jan 2024 14:16:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-40e6296636fso1915405e9.2 for ; Thu, 11 Jan 2024 06:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704982617; x=1705587417; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C7HNZaDiw/8JtL+WOdbC/TQ6GQKXbKUvja93oq/W0PE=; b=vkfbozRugNDFIpcNpfzHeIZCjYgnTFaMzo6J/h5C+anLIsuqkYLV6lWJPxLtybrlA6 xrZ3ofRaT181Khw9JAwfnj1hC8oU5YNJVHW7sqTfe7LTHSOojrfRb3ZImLiRLr5nQtNM uulJKizhcZScFhkUfOGqLHjpMhl3TLLOG0NBqiULUOw2HuGCfF6d7rmccRpb+T1DK5z1 2bT84SglewgV95Kmhq4YpEVQ3PhAQq/Z9+7vFWE+C/vXBxYvfe4BvQv3ivkqAiVF3p/o pv52e2wznEGu6JaxUTlKuUIowSyzdGPOKXTWoAo3QWetSZKqQ88AyiXczuhrkGKrR+6w zt+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704982617; x=1705587417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C7HNZaDiw/8JtL+WOdbC/TQ6GQKXbKUvja93oq/W0PE=; b=QkEnB8yLRIAPlQlx0uUEswmYIWiq3hWBM99zAKx6RNwfj/fR+ovf+RV0hNebFlJjZG JwcP5OND3GDCssa4QCw1x74weOZ2BD5YGCowyfsA5mKAtMuQ89cGGz4N2fKvnVaMjMOl bZOZlHayspzhOKBxqTeAHucK48U5e4AthFtzTNwDD+iuVMc4YtWNmYnZR7Cw3jVZfrPb PkFLZeAZCGg5rtgGTY7/B0+8Rlg22UpSAHJBVsTx6CaqVkj5Qf2KnVFnndWA7TtgY/Re wy6AjgzFKiMl7Fhxpn+R9YJkxpIMXZuZyBFbgapbytD06LVOr2Oqc7bDjof7NL8jrwnx d9Nw== X-Gm-Message-State: AOJu0YzAyMuIdSlcyfz7ktb9k7feWnewkHNF60Q3s1u4ahYjmdMS7oLc VH49t6GTa4s9LhWS1SVKF+pNQdukuoj0Ow== X-Received: by 2002:a05:600c:a47:b0:40e:5421:e2dc with SMTP id c7-20020a05600c0a4700b0040e5421e2dcmr444019wmq.198.1704982617490; Thu, 11 Jan 2024 06:16:57 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id o8-20020a05600c4fc800b0040e549c77a1sm6035367wmq.32.2024.01.11.06.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 06:16:57 -0800 (PST) Date: Thu, 11 Jan 2024 17:16:53 +0300 From: Dan Carpenter To: Christian Heusel Cc: Jason Gunthorpe , Leon Romanovsky , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] RDMA/ipoib: print symbolic error name instead of error code Message-ID: <102549f3-2169-40b7-b413-b86bc7965c4c@moroto.mountain> References: <20240111141311.987098-1-christian@heusel.eu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111141311.987098-1-christian@heusel.eu> On Thu, Jan 11, 2024 at 03:13:07PM +0100, Christian Heusel wrote: > Utilize the %pe print specifier to get the symbolic error name as a > string (i.e "-ENOMEM") in the log message instead of the error code to > increase its readablility. > > This change was suggested in > https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/ > > Signed-off-by: Christian Heusel Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter