Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1675114rdd; Thu, 11 Jan 2024 06:18:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IEK9cFYRBaC9KleUMJEMymzxWLKMZkYjIKcY/NOZAkbp/+TAZwOBkg1ftudXPvy/y8rKAY3 X-Received: by 2002:a05:6a20:3954:b0:199:bbc9:3df1 with SMTP id r20-20020a056a20395400b00199bbc93df1mr1043781pzg.3.1704982702940; Thu, 11 Jan 2024 06:18:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704982702; cv=none; d=google.com; s=arc-20160816; b=qZb5HaTCRmU/M3D5Xt3qO+GpllvssRiSuO2/SzYEwO9biMNBjG4H/M3RAM16io9gLA V9Do/0kraYa1CEc9+1Av3aXyyHKRgcOMSBnAtjSJvFvH5hpZJs3nKVlEgmIjnaA+lFvn 3PfXCEJgE0UBRfV8yn0Oot+c9JJH1fGspXPcUJnpvRVbsuaAdcVvGSSisftUJyBLPNqG UNub9qRIY9wNp5kUeW2iabkuE/MEO7H0kUvdsRAB3v3KNxBDoamAvc1pUBB2jb6wm5Vo 2CIy3oIFSiGIvHI4NXE51QXQ7Ed6v6ENfVvtcxQM1Y50SUJRpa99vTlOAgs6Y18YE4/+ T1OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=mTSColWjPxMy5hFmeWj7zZt2o1PCif6a70FoRgHVrZQ=; fh=vjcsHQHnFC79T0LrO8B8Oeq3VJQ333vkPAP4+e/kmvc=; b=Bn7617Vz41tpw+9aM5Ny9JB22lI6cV7A2dxw5LMQvzkKfw10NstFhDLOAGJDLycsd/ tU+O8TetJtFsfTrHTrU95GCalHeUVr5edajEdhh9N2AsPAsfx+gCj5cgjJPgXS2YhKGt uZJoqSyCy41g1YLWRlMr6CmwkdIFuyptBt0nSKSw6D+gs/o1T7vHsEsN2qbsmGyEANvD YOSoL6zTy6CmaV8+JgjP8kT1CUd6Mw1CEMmx7pAMcZY32QpBZPxcKqXpCtn3sAirMsQD aHD2od0wZEn1MnyHxElo+/fgUoUj7po9F+/L9oFIDOifnhsTtLKMiUYeUprcNQWvvEGU o+8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=aTWSFowT; spf=pass (google.com: domain of linux-kernel+bounces-23704-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23704-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id z10-20020a056a001d8a00b006db05853158si1149449pfw.158.2024.01.11.06.18.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 06:18:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23704-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=aTWSFowT; spf=pass (google.com: domain of linux-kernel+bounces-23704-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23704-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C0CCDB20C70 for ; Thu, 11 Jan 2024 14:18:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83A2F3D3B1; Thu, 11 Jan 2024 14:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="aTWSFowT" Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D7DD29CFA; Thu, 11 Jan 2024 14:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40BDUnAQ019952; Thu, 11 Jan 2024 14:18:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=mTSColWjPxMy5hFmeWj7zZt2o1PCif6a70FoRgHVrZQ=; b=aTWSFowTkjelJhZBVITSLaXkzq3HRXeI5eTrgg3uwZCeXNIyg0mve+dUxrQpx6kNUy6c mwXJi7oh+C1zpGEj6Rwt1EK7DILkw8G9EO+J090O43zfnWHD5J36oVKdSCZ9qzRMR2ym THXeqNr3rpmaqZZQ0354vRxve7flgMSxLfxXcpXd13h9eBhy4nsgz064P0OpWKQbSNmO 0bOfgu+Xau/ePlskVXhWWGkt+2BiHj7lPKDutU2XZGJRDRR3KtVzTC3r7JR/WpYVfyRh zLwCjpAhHWVOLoP5MCQhfHtQXr/n3wJ7QhWTUJ7mPjlE1DnI/Cj3lquQrCWj8NAlaCuN 3g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vjh2yhgtr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jan 2024 14:18:02 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40BDYLoM001569; Thu, 11 Jan 2024 14:18:01 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vjh2yhgt2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jan 2024 14:18:00 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40BE1gOo027421; Thu, 11 Jan 2024 14:17:59 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3vfkw2bd00-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jan 2024 14:17:59 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40BEHsvW61342140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jan 2024 14:17:54 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 974B42004D; Thu, 11 Jan 2024 14:17:54 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6CB1920043; Thu, 11 Jan 2024 14:17:54 +0000 (GMT) Received: from li-ce58cfcc-320b-11b2-a85c-85e19b5285e0 (unknown [9.152.224.212]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 11 Jan 2024 14:17:54 +0000 (GMT) Date: Thu, 11 Jan 2024 15:17:18 +0100 From: Halil Pasic To: Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jjherne@linux.ibm.com, borntraeger@de.ibm.com, pbonzini@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, alex.williamson@redhat.com, kwankhede@nvidia.com, stable@vger.kernel.org, Halil Pasic Subject: Re: [PATCH v2 6/6] s390/vfio-ap: do not reset queue removed from host config Message-ID: <20240111151718.5d32e747.pasic@linux.ibm.com> In-Reply-To: <20231212212522.307893-7-akrowiak@linux.ibm.com> References: <20231212212522.307893-1-akrowiak@linux.ibm.com> <20231212212522.307893-7-akrowiak@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: oNnj3N06fsAPsUgWGBMUGXTJnQ03Nntt X-Proofpoint-ORIG-GUID: yS9H-1cmFgokDSIXfEidxa7IeLBvAi34 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-11_07,2024-01-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1011 bulkscore=0 impostorscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401110113 On Tue, 12 Dec 2023 16:25:17 -0500 Tony Krowiak wrote: > When a queue is unbound from the vfio_ap device driver, it is reset to > ensure its crypto data is not leaked when it is bound to another device > driver. If the queue is unbound due to the fact that the adapter or domain > was removed from the host's AP configuration, then attempting to reset it > will fail with response code 01 (APID not valid) getting returned from the > reset command. Let's ensure that the queue is assigned to the host's > configuration before resetting it. > > Signed-off-by: Tony Krowiak Reviewed-by: Halil Pasic