Received-SPF: pass (google.com: domain of linux-kernel+bounces-23712-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: bartosz.golaszewski@linaro.org, linus.walleij@linaro.org, Hector Palacios <hector.palacios@digi.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, haibo.chen@nxp.com, peng.fan@nxp.com, hector.palacios@digi.com
Subject: Re: [PATCH 2/2] arm64: dts: imx93: specify available 'ngpios' per GPIO port
Date: Thu, 11 Jan 2024 15:26:29 +0100
Message-ID: <4330477.ejJDZkT8p0@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20240111131904.1491496-3-hector.palacios@digi.com>
References: <20240111131904.1491496-1-hector.palacios@digi.com> <20240111131904.1491496-3-hector.palacios@digi.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Am Donnerstag, 11. Januar 2024, 14:19:04 CET schrieb Hector Palacios:
> According to NXP HRM for i.MX93, the following GPIO pins are available:
> - GPIO1: 16 pins (0..15)
> - GPIO2: 30 pins (0..29)
> - GPIO3: 32 pins (0..31)
> - GPIO4: 30 pins (0..29)
>=20
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi index 34c0540276d1..7eb2cab7c7=
49
> 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -970,6 +970,7 @@ gpio2: gpio@43810000 {
>  				 <&clk IMX93_CLK_GPIO2_GATE>;
>  			clock-names =3D "gpio", "port";
>  			gpio-ranges =3D <&iomuxc 0 4 30>;
> +			ngpios =3D <30>;
>  		};
>=20
>  		gpio3: gpio@43820000 {
> @@ -986,6 +987,7 @@ gpio3: gpio@43820000 {
>  			clock-names =3D "gpio", "port";
>  			gpio-ranges =3D <&iomuxc 0 84 8>, <&iomuxc 8 66=20
18>,
>  				      <&iomuxc 26 34 2>, <&iomuxc 28 0=20
4>;
> +			ngpios =3D <32>;
>  		};
>=20
>  		gpio4: gpio@43830000 {
> @@ -1001,6 +1003,7 @@ gpio4: gpio@43830000 {
>  				 <&clk IMX93_CLK_GPIO4_GATE>;
>  			clock-names =3D "gpio", "port";
>  			gpio-ranges =3D <&iomuxc 0 38 28>, <&iomuxc 28 36=20
2>;
> +			ngpios =3D <30>;
>  		};
>=20
>  		gpio1: gpio@47400000 {
> @@ -1016,6 +1019,7 @@ gpio1: gpio@47400000 {
>  				 <&clk IMX93_CLK_GPIO1_GATE>;
>  			clock-names =3D "gpio", "port";
>  			gpio-ranges =3D <&iomuxc 0 92 16>;
> +			ngpios =3D <16>;
>  		};
>=20
>  		ocotp: efuse@47510000 {

This leads to warnings upon dtbs_check, e.g.
arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb: gpio@43810000:=
=20
'ngpios' does not match any of the regexes: '^.+-hog(-[0-9]+)?$', 'pinctrl-
[0-9]+'
  from schema $id: http://devicetree.org/schemas/gpio/gpio-vf610.yaml#

Please address this as well.

Best regards,
Alexander
=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/