Received-SPF: pass (google.com: domain of linux-kernel+bounces-23714-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Michael Kelley <mhklinux@outlook.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
CC: Markus Elfring <Markus.Elfring@web.de>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>, Dexuan Cui <decui@microsoft.com>, Haiyang
 Zhang <haiyangz@microsoft.com>, "K. Y. Srinivasan" <kys@microsoft.com>, Wei
 Liu <wei.liu@kernel.org>, "cocci@inria.fr" <cocci@inria.fr>, LKML
	<linux-kernel@vger.kernel.org>
Subject: RE: Drivers: hv: vmbus: One function call less in
 create_gpadl_header() after error detection
Thread-Topic: Drivers: hv: vmbus: One function call less in
 create_gpadl_header() after error detection
Thread-Index: AQHaQ7PyvvrIb8tUYUye7rRKlkvVrLDTNj6ggAAqigCAADt1QIAAlVWAgAB9o+A=
Date: Thu, 11 Jan 2024 14:35:18 +0000
Message-ID:
 <SN6PR02MB41570E0E960C9D588B9EF96DD4682@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <6d97cafb-ad7c-41c1-9f20-41024bb18515@web.de>
 <SN6PR02MB4157AA51AD8AEBB24D0668B7D4692@SN6PR02MB4157.namprd02.prod.outlook.com>
 <82054a0a-72e5-45b2-8808-e411a9587406@web.de>
 <SN6PR02MB4157CA3901DD8D069C755C72D4692@SN6PR02MB4157.namprd02.prod.outlook.com>
 <d3c13efc-a1a3-4f19-b0b9-f8c02cc674d5@moroto.mountain>
 <SN6PR02MB415710A52835BC82B1FA1EAFD4692@SN6PR02MB4157.namprd02.prod.outlook.com>
 <4ba5ab3c-80ae-448f-9377-01087ec9e858@moroto.mountain>
In-Reply-To: <4ba5ab3c-80ae-448f-9377-01087ec9e858@moroto.mountain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?tqX3OrZANY+7JmoUEjtNnu/s4wbkKjpIBJoAXWwTocLRaCm3BFixvlnS8Vtk?=
 =?us-ascii?Q?LQl1906XuRJhxN8R0rfyzvaqT/eW6mmO6QvTsOteJws+SykD8JjGJkXQ8V6g?=
 =?us-ascii?Q?zt1UpplxdvPPVd82atV1E9GOqEbM3iZvf27QKV2U6g4JHa6f25RH4WKeikdj?=
 =?us-ascii?Q?Zj/+BFT878KqMgOyVHZjB6RAL+TtQWE9SMYkS7FYIKxBZRaIwEV+pl9qVrpW?=
 =?us-ascii?Q?TFVIXC0AEvBu+56AcTOvz09p4vbjeqXPABTA3T4MtuU4IdhvtTZEgz57ZnMP?=
 =?us-ascii?Q?ERufldgfGzaAT+0eFtwOYNc0sAmGR3kJM2s7JkL5XxPc0+oAGszMB2+c8cVU?=
 =?us-ascii?Q?jm4wHEA8T+h4h9oBgw2ZuZuA3GRQPXFm66IiRzSj8EcXFmi7TEP+MTJMXAjy?=
 =?us-ascii?Q?/+Q+YspmRpzw5/yVL3pivfviRtHKCjK2IDIDtLfw68SOZQ+oW7I/igrvoazw?=
 =?us-ascii?Q?eqNg+f3IBW5XYWAXEF7jyWFNiCrU1gpizSGLVnmMOvNrj1BB5BXb0cuXipQi?=
 =?us-ascii?Q?gECliG2sVitG8aZM7VZ2MiGA6F0KnfytsxHieM+EFIfW+j0BHnU5Vok4u71m?=
 =?us-ascii?Q?4ZCeRWOyTOdBFEH2XDRmgo1wK1K46cVFLg/Umz+k6spUu7slGT6jC5XwQorB?=
 =?us-ascii?Q?tJ0M/LlRl/SUYjar9U6zU+u3VKiZL9IVSvjGkmH9lfw+XePjbCr2GN8pU2E5?=
 =?us-ascii?Q?md7ZntDzumRP04I1u/+dn9DbctabcKYiF9sqC6uFZZSWC7Ls7Nip3joKjGYb?=
 =?us-ascii?Q?KtVC61wWNyL2mEjo3tD59uHu7cGw8bYJCae7E0vluxgxT8El04ONwMnpvxTK?=
 =?us-ascii?Q?NAy+ksH14R8ScrpieDby+d5bf+XEA7/Uk0xIdgz7unPjjbGsmZ0Nz3EcKmYc?=
 =?us-ascii?Q?FNqvfAhTZc4jV8rYnKwn9Sz3RAi1ng0Cqo1XJ4B/n1sspT1t/AKzPs6fjy82?=
 =?us-ascii?Q?NrUpFZJPQ7xmU52CGmDTGNZYmHzKx4A5odnOh4ynCIou7CwpdBEgCNSFz5C4?=
 =?us-ascii?Q?0YJO06MwedBVfxqhsZ2HfhSWguVG155pUzSxWL81YeZ3JcsauX1Ke4do354H?=
 =?us-ascii?Q?6HlUhDPBtaZsoTP128E2r1szbdpp255Owa7nEUIQwDh7Pg1B06BVkYQZw4Me?=
 =?us-ascii?Q?TwyK9R0EYvMF6kBt5sLSjInBpdp/CU0+yxK/GpHyxIIEQDnn1LQqVmyPXsnM?=
 =?us-ascii?Q?Uenz2eXVJlHwlrAGB4xBts4Ynojzc2bHrcHMYQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: bad24b10-0c51-4995-0566-08dc12b28887
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2024 14:35:18.3518
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR02MB9475

From: Dan Carpenter <dan.carpenter@linaro.org> Sent: Wednesday, January 10,=
 2024 11:05 PM
>=20
> On Wed, Jan 10, 2024 at 10:17:17PM +0000, Michael Kelley wrote:
> > From: Dan Carpenter <dan.carpenter@linaro.org> Sent: Wednesday, January
> 10, 2024 10:38 AM
> > >
> > > The second half of the if statement is basically duplicated.  It does=
n't
> > > need to be treated as a special case.  We could do something like bel=
ow.
> > > I deliberately didn't delete the tabs.  Also I haven't tested it.
> >
> > Indeed!  I looked at the history, and this function has been
> > structured with the duplication since sometime in 2010, which
> > pre-dates my involvement by several years.  I don't know of
> > any reason why the duplication is needed, and agree it could
> > be eliminated.
> >
> > Assuming Markus is OK with my proposal on the handling of
> > memory allocation failures, a single patch could simplify this
> > function quite a bit.
> >
> > Dan -- do you want to create and submit the patch?  I'll test the
> > code on Hyper-V.  Or I can create, test, and submit the patch with
> > a "Suggested-by: Dan Carpenter".
>=20
> I messed up the if statement the first couple times I tried to think
> about it so I don't trust myself here.  Could you give me the
> Suggested-by tag?
>=20

Will do.

Michael