Received-SPF: pass (google.com: domain of linux-kernel+bounces-23730-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Jani Nikula <jani.nikula@linux.intel.com>
To: chenxuebing <chenxb_99091@126.com>, daniel@ffwll.ch, airlied@gmail.com,
 mripard@kernel.org, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
 chenxuebing <chenxb_99091@126.com>
Subject: Re: [PATCH] drm/edid: Clean up errors in drm_edid.h
In-Reply-To: <8734v4ur1g.fsf@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20240111063921.8701-1-chenxb_99091@126.com>
 <8734v4ur1g.fsf@intel.com>
Date: Thu, 11 Jan 2024 16:50:05 +0200
Message-ID: <87r0inudpe.fsf@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Thu, 11 Jan 2024, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 11 Jan 2024, chenxuebing <chenxb_99091@126.com> wrote:
>> Fix the following errors reported by checkpatch:
>>
>> ERROR: do not use assignment in if condition
>>
>> Signed-off-by: chenxuebing <chenxb_99091@126.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

And pushed to drm-misc-next, thanks for the patch.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/drm_edid.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index 69c68804023f..9bcaf76f10fc 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -3611,7 +3611,8 @@ static bool mode_in_range(const struct drm_display_mode *mode,
>>  	if (!mode_in_vsync_range(mode, edid, t))
>>  		return false;
>>  
>> -	if ((max_clock = range_pixel_clock(edid, t)))
>> +	max_clock = range_pixel_clock(edid, t);
>> +	if (max_clock)
>>  		if (mode->clock > max_clock)
>>  			return false;

-- 
Jani Nikula, Intel