Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1699481rdd; Thu, 11 Jan 2024 06:57:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGI+eUoRU8UIkbOkeWHnNSwAW58bPDdZ5UeZTuMMPEUsuvB+XJEr3FisFSVzKOA3aSs1IOK X-Received: by 2002:a05:620a:60f6:b0:783:1887:80e6 with SMTP id dy54-20020a05620a60f600b00783188780e6mr1146081qkb.35.1704985056633; Thu, 11 Jan 2024 06:57:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704985056; cv=none; d=google.com; s=arc-20160816; b=Zy3BXlM6Rdz9dlQnqMUWSS2gKQbXg/ptcE8DlmVQQyhPZQld8a68beYMKknS4gZcro DarbI4PxAHyHeXS74Iq612xFieiKribVKqE7sx16ghqrXc71xssS2k+DHPlzsd+KS7Kv /oiXSIKK1fMSIjRwXsZ9pU99pUtPpmSQBEWBCQsVsUWj6bbcKscxbkwTYUPmDhEj30rl SaBQYj2iWF35+IOgwFWF/c3lKNrzv4WJKmuNEoubH5+WCwPGOP625JpuqJu7VFry1aYD fUrhWgDo6q8k+mhp99ERRqR4bGbjjVnr+Fq5RLnhKEeABbZfhniFe/4obTQT2kYgc14m eKAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=y4QJ/Zk/UxhefO+/Ds686chTEmns6pEsPp66wCH/Tr8=; fh=/0SwOq6w+g6TF1hFbvzoUFMZKdskvJu1istO3sEWw+I=; b=mOTp3TZoXw18fvZ22uCX3I99WKfM6AQffiT3QbWYz9SwaGLXEox5YhKgA6nY3mnvly 18OoF0ISDvM5CD5bULEjd6Rnh10LekKLtBTHGmtAJTOp0Pa9ip7J+9to6viTV+szp8Lz /wdnBGcK4Gt14ASPozuRLBQaWdJORDSY1V9jmdx8wZYHVchmsCetI9sXz3IBzmWk/t2B U9jACy12LNpM4dHvYxz647OEQDHB10KzAMoHtQN2lLcQeOL3UXnRajZE7A3josqTckEV hDL16ZWz4Qo5cl+MwjjEDhcwPN+Xh/6ak4sddXeqAIwGJPMMva2YGrOlOdRLSAfDtcvS Ln/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LtwipY78; spf=pass (google.com: domain of linux-kernel+bounces-23752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23752-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u9-20020a05620a120900b007833008db9bsi1025904qkj.602.2024.01.11.06.57.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 06:57:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LtwipY78; spf=pass (google.com: domain of linux-kernel+bounces-23752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23752-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 637671C216D1 for ; Thu, 11 Jan 2024 14:57:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B8F2C495FB; Thu, 11 Jan 2024 14:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LtwipY78" Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86AFC4B5A9 for ; Thu, 11 Jan 2024 14:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5f2aab1c0c5so49592657b3.0 for ; Thu, 11 Jan 2024 06:57:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704985033; x=1705589833; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y4QJ/Zk/UxhefO+/Ds686chTEmns6pEsPp66wCH/Tr8=; b=LtwipY78GtVt3Y6uFrZXrDiJiH551VQ/8DFSI1guS+otC8ZssAtguJ1jEXgXnmDaDv pue7uidnE6Zzhty2K5sNdSQ1x+oz+bc3+kJ/m+DdkQPPB34IxUesvLmnGlbqgi52FfpY Qj+UqAfLAPoaetCNTINOVtII+ZOpWPLJsU3sthyo3Co3HSDIqGEvNmp9VIeZZlm7TC8O S9gUu+1V16ITU9K5KT1XnI155I/OHMgwtJv4kcct4wK771Hb97GeOEMJoT1djPqFSNyH ECzVsQxERBCpfPhhiiPUq8jwhedDQhIaclKbuclo4nUTJHN+gzdO7062nHzPqcGDp5OA Iq3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704985033; x=1705589833; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y4QJ/Zk/UxhefO+/Ds686chTEmns6pEsPp66wCH/Tr8=; b=JA2kACrCzz6nRR0DHdFmwhac0HukpQnF+ZqFTAs3BugNNlseuR70rS4KtWv94hydYb 84lgBKQ8zvhFeWUxeC5H8AQ4bnnAHJodbsO8E1H9h3WYBQTil4ptogdQBL6gsokuFvIl YljLH4EWItSTB0Ud+Zh4pNt1CLJKYuZq+tmQAEt/Q+8J1XX/F3PDGbu3HtFn8t5wK68W al3GVvS6DgcHiea0M+o2UjqhCv4KIWQusJbKppCOymHD2RVLnnIVB6EO4EEmkANJUk6T QuLmbwCHr/jIj75UbVBlYoAsHixKzSqvYoTxZUZ/UmSM/2RFPpn+Z56TaDrFb7E6fsj6 W7Ow== X-Gm-Message-State: AOJu0YyAVIZ3/KemDvfQR5Br35cYX8s2GQoQAMjN12xgDGugR1PWoWq3 agGMOV8fCXm8b0r51e7eemPzcn70C8QpY1eOPZVqvk6dQjGN7A== X-Received: by 2002:a81:aa11:0:b0:5e7:9454:6a2a with SMTP id i17-20020a81aa11000000b005e794546a2amr407663ywh.42.1704985032557; Thu, 11 Jan 2024 06:57:12 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240110-fp4-panel-v2-0-8ad11174f65b@fairphone.com> <20240110-fp4-panel-v2-2-8ad11174f65b@fairphone.com> In-Reply-To: <20240110-fp4-panel-v2-2-8ad11174f65b@fairphone.com> From: Linus Walleij Date: Thu, 11 Jan 2024 15:57:01 +0100 Message-ID: Subject: Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel To: Luca Weiss Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andy Gross , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 10, 2024 at 4:14=E2=80=AFPM Luca Weiss wrote: > Add support for the 2340x1080 LCD DJN panel bundled with a HX83112A > driver IC, as found on the Fairphone 4 smartphone. > > Signed-off-by: Luca Weiss This makes it sound like the Himax HX83112A is the driver IC. This does not seem to be the case: https://github.com/HimaxSoftware/HX83112_Android_Driver The driver IC seems to be a truly 5p65. If this is right, could you rename the driver file to truly-5p65.c and all symbols containing hx83112 to truly_5965 or something that indicate the driver IC instead of the panel? My main concern is that the next display using the same IC need to find the right file to patch. Yours, Linus Walleij