Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1724869rdd; Thu, 11 Jan 2024 07:32:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiaRfo4TcanZO1WwktIe2vBTvRfFHw4bEYA/Xqo5QKJqaktIQfCIWZfkzHcgBfD6tqEYVB X-Received: by 2002:a17:902:f688:b0:1d4:c339:3a29 with SMTP id l8-20020a170902f68800b001d4c3393a29mr1304268plg.18.1704987148116; Thu, 11 Jan 2024 07:32:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704987148; cv=none; d=google.com; s=arc-20160816; b=0ul41bvNsrVYyAFppqdNQR+GStWZ1HKAQT378M/PA6MWRkRJI2P9FING/ueju/VnOb 5DWjw1RaAMCVno7qUxupK98jaHxThG9i3nq8YwwAPV+MtV7zqDar2iY1My+oIz2+JMd+ MhdUWjnISp2bERSRnxGaorEBGhnQVRE5+7kIgmc53LvoSjPWEfA9jv33RzoGW8Im2ECf ooCvmINIX8vU+8GjY3wooBsKnnbZ18ITH3LWaVU+CIFdkBudBoKmu6/AwetvCRuh/E1F 2S9Cxkk3N4rwE4z3i2R/trk7rKO2gLaO5PUmr0tGHlBGLBYwu29y2zyxsTiocDZEUr3X 7W2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bWePOa8GLZpZTN02izOhGMD/Rc7CJVvB+zX37Yp82gU=; fh=SORsV/x0XBPbstO4jKVXIEp9fAFDuTtp/O6xloObjjE=; b=BN+AHhPeM7WexCAwyVmkzD0ekx4k3FoqSAjJFflN8qGeSPIho+KrTD1C/eoIibnFFu v9u0CcGHMbl91TLoVjyXpJsIvnworLWfnhpGl8KX9g+oEsIeJ4hs3mNi5oOoIilJlZ8u V971gsGbuALonFk4LuVeb7Eviy9FiwqPPOnDivg484nVGGpSsNDAqZ9pmJ79fe2dVMiW E57S3fCZQPtEnR2djB9WIQ9dSA8bvuWQtZupjdT4T3Epi9jfeGc7N9BXNpatJ1cp9JnI IbSMB4gdBv4z2Sy7s+7w7xWWJ/Zw25cnLu3VH8cfM6gQ5jTmYaE/voNWJ2m7SBjJZ7Wm PH9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=eDYVkCvm; spf=pass (google.com: domain of linux-kernel+bounces-23796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23796-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id j20-20020a170902f25400b001d58ce5ad4dsi1222505plc.448.2024.01.11.07.32.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 07:32:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=eDYVkCvm; spf=pass (google.com: domain of linux-kernel+bounces-23796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23796-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A21ACB2386B for ; Thu, 11 Jan 2024 15:31:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 63D7C4F1FE; Thu, 11 Jan 2024 15:31:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="eDYVkCvm" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D0C34EB5C; Thu, 11 Jan 2024 15:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bWePOa8GLZpZTN02izOhGMD/Rc7CJVvB+zX37Yp82gU=; b=eDYVkCvmb3TPwZ6xVGBlnXj025 zGxz3Mfnp5uqvF48Js3mxq9WIuc7ujsQLtkU7CsBFblH5mi0nw23nnPMh4X9jnL0QGkY+OMkptcLi OTRVklfR+6gVYOUVHyXpo71PFkPw6ck0ibLiA+E/IHWMc4G+iAfjj9l9zojyjHBFH0aDfJdJcm3Q4 P0jIGhcYwkw5lpcuwHi0A6Bw/UoKbp35xpZp5Ij1j7fYQekMgd/MFiBXxB/8GP82GrnTXX+Ji5g1I 806nh8P5PeqAKAAUSA+WJWZOw1SoiVBuOHwpbUAsJOZMqSTU5kIxgCYV1KQn/wiafidkgA4daYwLS lEgrcmdw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rNx1U-00EB3W-L9; Thu, 11 Jan 2024 15:31:12 +0000 Date: Thu, 11 Jan 2024 15:31:12 +0000 From: Matthew Wilcox To: Roman Smirnov Cc: stable@vger.kernel.org, Greg Kroah-Hartman , Andrew Morton , Alexey Khoroshilov , Sergey Shtylyov , Karina Yankevich , lvc-project@linuxtesting.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5.10 0/2] mm/truncate: fix issue in ext4_set_page_dirty() Message-ID: References: <20240111143747.4418-1-r.smirnov@omp.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111143747.4418-1-r.smirnov@omp.ru> On Thu, Jan 11, 2024 at 02:37:45PM +0000, Roman Smirnov wrote: > Syzkaller reports warning in ext4_set_page_dirty() in 5.10 stable > releases. The problem can be fixed by the following patches > which can be cleanly applied to the 5.10 branch. I do not understand the crash, and I do not understand why this patch would fix it. Can you explain either? > Found by Linux Verification Center (linuxtesting.org) with Syzkaller. > > Link: https://syzkaller.appspot.com/bug?extid=02f21431b65c214aa1d6 > > Matthew Wilcox (Oracle) (2): > mm/truncate: Inline invalidate_complete_page() into its one caller > mm/truncate: Replace page_mapped() call in invalidate_inode_page() > > kernel/futex/core.c | 2 +- > mm/truncate.c | 34 +++++++--------------------------- > 2 files changed, 8 insertions(+), 28 deletions(-) > > -- > 2.34.1 >