Received-SPF: pass (google.com: domain of linux-kernel+bounces-23810-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 11 Jan 2024 21:13:26 +0530
From: Ajay Agarwal <ajayagarwal@google.com>
To: Johan Hovold <johan@kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Andersson <quic_bjorande@quicinc.com>,
	Sajid Dalvi <sdalvi@google.com>
Subject: Re: [PATCH] Revert "PCI: dwc: Wait for link up only if link is
 started"
Message-ID: <ZaAMnh8lae_Cxvtm@google.com>
References: <20230706082610.26584-1-johan+linaro@kernel.org>
 <20230706125811.GD4808@thinkpad>
 <ZKgJfG5Mi-e77LQT@hovoldconsulting.com>
 <ZKwwAin4FcCETGq/@google.com>
 <ZKw03xjH5VdL/JHD@google.com>
 <20230710170608.GA346178@rocinante>
 <ZKz8J1jM7zxt3wR7@hovoldconsulting.com>
 <ZK7m0hjQg7H5rANZ@google.com>
 <ZLENgbMe4YVOINRQ@hovoldconsulting.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZLENgbMe4YVOINRQ@hovoldconsulting.com>

On Fri, Jul 14, 2023 at 10:55:29AM +0200, Johan Hovold wrote:
> On Wed, Jul 12, 2023 at 11:15:54PM +0530, Ajay Agarwal wrote:
> > On Tue, Jul 11, 2023 at 08:52:23AM +0200, Johan Hovold wrote:
> 
> > > All mainline drivers already start the link before that
> > > wait-for-link-up, so the commit in question makes very little sense.
> > > That's why I prefer reverting it, so as to not pollute the git logs
> > > (e.g. for git blame) with misleading justifications.
> 
> > I am developing a PCIe driver which will not have the start_link
> > callback defined. Instead, the link will be coming up much later based
> > on some other trigger. So my driver will not attempt the LTSSM training
> > on probe. So even if the probe is made asynchronous, it will still end
> > up wasting 1 second of time.
> 
> Yeah, I had the suspicion that this was really motivated by some
> out-of-tree driver, which as I'm sure you know, is not a concern for
> mainline.
> 
> Vendor drivers do all sorts of crazy stuff and we don't carry code in
> mainline for the sole benefit of such drivers that have not been
> upstreamed (and likely never will be).
> 
> So again, I think this patch should just be reverted.
> 
> If you want to get something like this in, you can send a follow-on
> patch describing your actual motivation and use case. But as it appears
> to boil down to "I need this for my out-of-tree driver", I suspect such
> a patch would still be rejected.
> 
> Johan

Johan, Mani,
I submitted https://lore.kernel.org/all/20240111152517.1881382-1-ajayagarwal@google.com/
which does not return an error value if the dw_pcie_wait_for_link fails
in probe. Can you please check and provide your comments?

Thanks
Ajay