Received-SPF: pass (google.com: domain of linux-kernel+bounces-23814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 11 Jan 2024 15:49:43 +0000
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>,
	Mengyuan Lou <mengyuanlou@net-swift.com>,
	Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wangxunx: select CONFIG_PHYLINK where needed
Message-ID: <ZaAOF/esan+HnufM@shell.armlinux.org.uk>
References: <20240109075656.2656359-1-arnd@kernel.org>
 <ZZ0TdiIDE2lqHE+8@shell.armlinux.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZZ0TdiIDE2lqHE+8@shell.armlinux.org.uk>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Tue, Jan 09, 2024 at 09:35:50AM +0000, Russell King (Oracle) wrote:
> On Tue, Jan 09, 2024 at 08:56:21AM +0100, Arnd Bergmann wrote:
> > diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> > index 23cd610bd376..46630f05d8dd 100644
> > --- a/drivers/net/ethernet/wangxun/Kconfig
> > +++ b/drivers/net/ethernet/wangxun/Kconfig
> > @@ -26,6 +26,7 @@ config NGBE
> >  	tristate "Wangxun(R) GbE PCI Express adapters support"
> >  	depends on PCI
> >  	select LIBWX
> > +	select PHYLINK
> >  	select PHYLIB
> 
> You can drop PHYLIB when adding PHYLINK.

Arnd,

There are repeated complaints from the kernel build bot about this, and
it would be good to get it solved. Could we have an updated patch
submitted to netdev please? This is in net-next only at the moment,
so I think that means it needs to be submitted with:

	[PATCH net-next ...]

and please make it clear that it is a fix for code only in net-next.
(However, netdev folk may request it to be referred until net-next is
merged and then against the net tree...)

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!