Received-SPF: pass (google.com: domain of linux-kernel+bounces-23818-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b1adbb1c-62b7-459f-a1bb-63774895fbb3@I-love.SAKURA.ne.jp>
Date: Thu, 11 Jan 2024 23:59:53 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [linus:master] [kasan] a414d4286f:
 INFO:trying_to_register_non-static_key
Content-Language: en-US
To: kernel test robot <oliver.sang@intel.com>,
        Andrey Konovalov <andreyknvl@google.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Marco Elver <elver@google.com>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Evgenii Stepanov <eugenis@google.com>,
        Vlastimil Babka <vbabka@suse.cz>, kasan-dev@googlegroups.com
References: <202401111558.1374ae6f-oliver.sang@intel.com>
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
In-Reply-To: <202401111558.1374ae6f-oliver.sang@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Commit a414d4286f34 ("kasan: handle concurrent kasan_record_aux_stack calls")
calls raw_spin_lock_init(&alloc_meta->aux_lock) after __memset() in
kasan_init_object_meta(), but does not call raw_spin_lock_init() after __memset()
in release_alloc_meta(), resulting in lock map information being zeroed out?

We should not zero out the whole sizeof(struct kasan_alloc_meta) bytes from
release_alloc_meta() in order not to undo raw_spin_lock_init() from
kasan_init_object_meta() ?

On 2024/01/11 16:29, kernel test robot wrote:
> [    1.582812][    T0] INFO: trying to register non-static key.
> [    1.583305][    T0] The code is fine but needs lockdep annotation, or maybe
> [    1.583887][    T0] you didn't initialize this object before use?
> [    1.584409][    T0] turning off the locking correctness validator.