Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1752977rdd; Thu, 11 Jan 2024 08:15:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNFzuSPe0KCenWqmMBWb/mya2EBn1aKa6Cq6lPN1QctWULMReRYEQh3RKAZa82XPLtlgFk X-Received: by 2002:a05:6808:3b0:b0:3bc:24e4:4514 with SMTP id n16-20020a05680803b000b003bc24e44514mr1500489oie.85.1704989747820; Thu, 11 Jan 2024 08:15:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704989747; cv=none; d=google.com; s=arc-20160816; b=SPeoC1mu7hpiOI/xyn6xrP6ZTs1tBj96V9gUi/4edBlv5AeTumiCaySGy0AKxD4ThJ /DxZDx66ikjUQkik1rAls54ujMRQ/IHuVqKVcALzaGXvprjFiwI/wsvGpLJe6Hqsbyda ScOaNdK0Vvc6b9dp/vHFtlYaiBcFNMDxPNG+7Nb0VyZcLnP+yNq00CpgVu19IJ/5Ae8L /mIotktp5T77Koje1t7X4PV9Wnd06nPxBu3B+ivqYTXJrYGyXkDuE7odDpT5GqC0mNnu P9UsTGM4brtQN074rBAfmkySR88dNvSUVVUrl3vgJwtlR1G/rzL77VZKYmcMhzNpwvhJ sj/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=Jkwarm5DpHDFsyYgiYQsfxjChtXkaV+MJAHY1naVkW8=; fh=0JBwPAvmw/CoYJXkESbcZb/xSyhS+2+H3qemEDrBPR0=; b=R1xtr6zgNHWdBsWLcnAbQkFrBjA5qvAFIH098Y7NW54E9Z02ZLOqTj7U84p4DURsXW 8ot713raIKY+1Zwe3X0+lKPYw6dMxgTogS773+Z/vxexYEpBgZmtmv/FmwfwqpK8gSsN f5fGqiYVO0gAJMj5W98mnzwnT3Of3WgNFTFoXaJwfvczYpGNMxBapukftedLZokimwcG EFHKzwYBrMfAnmyDf6zor/eH2DZOBqlURcDK5bHeAg2xrEhh8lRdPnl8/B8CUdW/hHPz KCM0jrsBLku/E0jwv0N2UDJu7T4heBMP9HW+HsGPTmjblaM/lpfD62fyc1VHWSHe/cJ/ Ffog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-23837-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23837-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id n7-20020a0ce487000000b0067f9c41923esi1060360qvl.32.2024.01.11.08.15.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 08:15:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23837-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-23837-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23837-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8C2D91C23263 for ; Thu, 11 Jan 2024 16:15:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A3784F8B7; Thu, 11 Jan 2024 16:15:30 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99FE28E33; Thu, 11 Jan 2024 16:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 8034F68CFE; Thu, 11 Jan 2024 17:15:22 +0100 (CET) Date: Thu, 11 Jan 2024 17:15:22 +0100 From: Christoph Hellwig To: John Garry Cc: Christoph Hellwig , "Darrick J. Wong" , Dave Chinner , axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com, jack@suse.cz, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org, ming.lei@redhat.com, bvanassche@acm.org, ojaswin@linux.ibm.com Subject: Re: [PATCH v2 00/16] block atomic writes Message-ID: <20240111161522.GB16626@lst.de> References: <20231221065031.GA25778@lst.de> <73d03703-6c57-424a-80ea-965e636c34d6@oracle.com> <20240110091929.GA31003@lst.de> <20240111014056.GL722975@frogsfrogsfrogs> <20240111050257.GA4457@lst.de> <20240111144537.GA9295@lst.de> <71063aee-8ba9-4a02-8c09-9b3a9982f6e0@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71063aee-8ba9-4a02-8c09-9b3a9982f6e0@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Jan 11, 2024 at 04:11:38PM +0000, John Garry wrote: > Could we just error the SETXATTR ioctl when FS_XFLAG_FORCEALIGN is not set > (and it is required)? The problem is that ioctl reports -EINVAL for any > such errors, so hard for the user to know the issue... Sure. Pick a good unique error code, though.