Received-SPF: pass (google.com: domain of linux-kernel+bounces-23870-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 11 Jan 2024 16:31:40 +0000
From: Conor Dooley <conor@kernel.org>
To: Ceclan Dumitru <mitrutzceclan@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ceclan Dumitru <dumitru.ceclan@analog.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: hmc425a: add conditional GPIO
 array size constraints
Message-ID: <20240111-suitcase-collage-889fa8404ab2@spud>
References: <20240110153757.5754-1-mitrutzceclan@gmail.com>
 <20240110153757.5754-2-mitrutzceclan@gmail.com>
 <20240110-unfitting-squander-b1d71c185bb7@spud>
 <478d9445-96aa-44b3-b598-8f7d7716dbba@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="T/gFBDvK/h08vZL+"
Content-Disposition: inline
In-Reply-To: <478d9445-96aa-44b3-b598-8f7d7716dbba@gmail.com>


--T/gFBDvK/h08vZL+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 11, 2024 at 10:17:58AM +0200, Ceclan Dumitru wrote:
>=20
>=20
> On 1/10/24 18:17, Conor Dooley wrote:
> > On Wed, Jan 10, 2024 at 05:37:09PM +0200, Dumitru Ceclan wrote:...
> >>    ctrl-gpios:
> >>      description:
> >> -      Must contain an array of 6 GPIO specifiers, referring to the GP=
IO pins
> >> -      connected to the control pins V1-V6.
> >> -    minItems: 6
> >> +      Must contain an array of GPIO specifiers, referring to the GPIO=
 pins
> >> +      connected to the control pins.
> >> +        ADRF5740  - 4 GPIO connected to D2-D5
> >> +        HMC540S   - 4 GPIO connected to V1-V4
> >> +        HMC425A   - 6 GPIO connected to V1-V6
> >> +    minItems: 1
> >>      maxItems: 6
> >> =20
> >> +allOf:
> >> +  - if:
> >> +      properties:
> >> +        compatible:
> >> +          contains:
> >> +            const: adi,hmc425a
> >> +    then:
> >> +      properties:
> >> +        ctrl-gpios:
> >> +          minItems: 6
> >=20
> >> +          maxItems: 6
> >=20
> > This one should not be needed, it's already set by constraints on the
> > property above.
> >=20
>=20
> No, not needed, just inspired from:
>  /bindings/clock/samsung,exynos7-clock.yaml
>=20
> Specifically, the top constraints:
>   clocks:
>=20
>     minItems: 1
>=20
>     maxItems: 13
>=20
> One of the conditional constraints:
>   clocks:
>=20
>     minItems: 13
>=20
>     maxItems: 13
>=20
>=20
> I would only have two arguments for this staying here:
>  - It stays consistent with other cases
>  - In the case a new device with more than 6 GPIOs is added, this would
> need to be put back in

Okay.

--T/gFBDvK/h08vZL+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZaAX7AAKCRB4tDGHoIJi
0ru8AQCdBU5wVGAEWO/zsKHdUGmfoPuB9Zz97glaVc3CR4U+UgEApoGcVfC+1Ta7
DEGHEfg/LLqoQLprkP33lsaWkNIUTwQ=
=xcFx
-----END PGP SIGNATURE-----

--T/gFBDvK/h08vZL+--