Received-SPF: pass (google.com: domain of linux-kernel+bounces-23883-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <77fe0ccd-53ff-4773-9787-0d038434297f@linux.ibm.com>
Date: Thu, 11 Jan 2024 10:43:08 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/1] tpm: tis-i2c: Add more compatible strings
To: Conor Dooley <conor@kernel.org>
Cc: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
        Joel Stanley <joel@jms.id.au>, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
References: <20231214144954.3833998-1-ninad@linux.ibm.com>
 <20231214144954.3833998-2-ninad@linux.ibm.com>
 <20240109-saddling-nintendo-c7fbb46bb0dd@spud>
Content-Language: en-US
From: Ninad Palsule <ninad@linux.ibm.com>
In-Reply-To: <20240109-saddling-nintendo-c7fbb46bb0dd@spud>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0

Hello Conor,

On 1/9/24 11:11, Conor Dooley wrote:
> On Thu, Dec 14, 2023 at 08:49:53AM -0600, Ninad Palsule wrote:
>> From: Joel Stanley <joel@jms.id.au>
>>
>> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
>>
>> https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
>>
>> Add a compatible string for it, and the generic compatible.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
>> Link: https://lore.kernel.org/r/20220928043957.2636877-4-joel@jms.id.au
>> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> I don't understand why you broke this series up and dropped patches.
> NAK, these compatibles are not documented.
>
The original series has three patches:

1) Adding compatibility string which I am adding in this series.

2) Adding schema for the TIS I2c devices which is already covered by 
Lukas's patch (already merged in linux-next) 
https://lore.kernel.org/all/3f56f0a2bb90697a23e83583a21684b75dc7eea2.1701093036.git.lukas@wunner.de/

3) Removing "Infineon,slb9673" from trivial-devices.yaml which is not 
done as it is already added in the TPM specific file. I will add it in 
my patch. Good catch!

Thanks for the review.

Regards,

Ninad