Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1772081rdd; Thu, 11 Jan 2024 08:49:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQ5jbzSqjOIDWK3W2pK6wUZfSPoma9qdLrvtyR2fKBs9TwwSKQhvQiIZJ06+rpaTvH8Mjl X-Received: by 2002:a05:6e02:1d03:b0:360:128e:a400 with SMTP id i3-20020a056e021d0300b00360128ea400mr1798436ila.16.1704991750734; Thu, 11 Jan 2024 08:49:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704991750; cv=none; d=google.com; s=arc-20160816; b=V5UUHG3YbY81ZHb7Y3HYIOohI8Hl87pyGb78qpt1sBdNVlaUQo8fJe+RMblqA4LKbG 4bky7iuesrE8pzKkVxYcolpc/sSvwk7O/Hi8rNRB1FU6mgr/58tq6DtCr0EryATv3Eq4 gHHvNNeridQBF3X661yJ40MPeJSwEoxpIMCoNicGETzhuNQbeJZAQUkrU1V+4pD+41gu 9XvrQPjtmOMfo7h8XcsC/Ce17vnlIMGhucB10MsUG0ao8gc4lTaD5NmtLCCNLs9fWlEr C4iHeatvN/8u4C05fW9GnE7LY2zvUAZLFnvT8/oljyADhRpBlfAwc3nvKcfQ46g9mw3w 6ETw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3whPCu9T/Xx4lp3PbnviQeKrWYOvHEvUnRUF2/ZVJe8=; fh=tVFK6CYlvPnvX85pdYGRN5N5jHvnRXl+3Cqy2E6QKOM=; b=KHHELtpltOOUW/2Rf2jQkHUdRFra/wr51L5BZqULjGTznhpo4Dv99a9zb9RD42XPp2 J0JVeA/8+iAEsqxXhhHNrkcs6/gsyfU42TICrkbx1Q0pUvN/7W/Ci0flPZQQGLkfNYcY O6tch1nDGf+45UchgBbECGVRBS/dXDkbv0coETrFNyeQ2IvzKE6uzZW6QVxuKSAlGQj9 Icgm3vZpKp3aiI99s+76kPzqB6o/lq9XM2k+H8DCtUxs2jPtTqHr6AUqlcV3TnuCHYPg XqAhBdNz2VT12Ni9KxdmEUuxctKKhrw3Ej/lnV4Vk+F/3Tit5HFlrZqqO7Zt6IsKdQfl I6Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="GNueH/jD"; spf=pass (google.com: domain of linux-kernel+bounces-23892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23892-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y17-20020a634b11000000b005cec8ed4f83si1446782pga.587.2024.01.11.08.49.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 08:49:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="GNueH/jD"; spf=pass (google.com: domain of linux-kernel+bounces-23892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23892-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5E0D1281899 for ; Thu, 11 Jan 2024 16:49:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6695251000; Thu, 11 Jan 2024 16:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="GNueH/jD" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5417729423; Thu, 11 Jan 2024 16:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=3whPCu9T/Xx4lp3PbnviQeKrWYOvHEvUnRUF2/ZVJe8=; b=GNueH/jDQxY7E0hVBtBkZvMDNe QHEcr5GY06S1/x9WTP44SAIM+p5+OwpXT4ulanTRQoHVZ6ZIHlFmSGTtwnZ9I3bIUGlacwcjGlNkj fsJmZhB89a7BOHa8jKYinZf5I35G+OkDMNHCdgYOCs5EVztVYn2vIew/poHInP+y0Y0c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rNyEV-00510l-F5; Thu, 11 Jan 2024 17:48:43 +0100 Date: Thu, 11 Jan 2024 17:48:43 +0100 From: Andrew Lunn To: Arnd Bergmann Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arnd Bergmann , Jiawen Wu , Mengyuan Lou , Russell King , Maciej Fijalkowski , Andy Shevchenko , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next v2] wangxunx: select CONFIG_PHYLINK where needed Message-ID: References: <20240111162828.68564-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111162828.68564-1-arnd@kernel.org> On Thu, Jan 11, 2024 at 05:27:53PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The ngbe driver needs phylink: > > arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset': > wx_ethtool.c:(.text+0x458): undefined reference to `phylink_ethtool_nway_reset' > arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_remove': > ngbe_main.c:(.text+0x7c): undefined reference to `phylink_destroy' > arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_open': > ngbe_main.c:(.text+0xf90): undefined reference to `phylink_connect_phy' > arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.o: in function `ngbe_mdio_init': > ngbe_mdio.c:(.text+0x314): undefined reference to `phylink_create' > > Add the missing Kconfig description for this. > > Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink") > Signed-off-by: Arnd Bergmann Reviewed-by: Andrew Lunn Andrew